From 2a048ca4df14ed37fb4d84f14c9bae663b50eb61 Mon Sep 17 00:00:00 2001 From: Lubos Slovak <lubos.slovak@nic.cz> Date: Tue, 16 Nov 2010 16:37:10 +0100 Subject: [PATCH] Fixed comparation function. Was comparing RDATA domain names as domain names, should compare as binary data. --- src/dnslib/rdata.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/dnslib/rdata.c b/src/dnslib/rdata.c index 2cb3d8911..51ac0b1cd 100644 --- a/src/dnslib/rdata.c +++ b/src/dnslib/rdata.c @@ -285,8 +285,11 @@ int dnslib_rdata_compare( const dnslib_rdata_t *r1, const dnslib_rdata_t *r2, case DNSLIB_RDATA_WF_COMPRESSED_DNAME: case DNSLIB_RDATA_WF_UNCOMPRESSED_DNAME: case DNSLIB_RDATA_WF_LITERAL_DNAME: - // maybe also compare with dnslib_rdata_compare_binary() - cmp = dnslib_dname_compare(item1->dname, item2->dname); + cmp = dnslib_rdata_compare_binary( + dnslib_dname_name(item1->dname), + dnslib_dname_name(item2->dname), + dnslib_dname_size(item1->dname), + dnslib_dname_size(item2->dname)); break; case DNSLIB_RDATA_WF_BYTE: cmp = (item1->int8 == item2->int8) ? 0 : ( -- GitLab