From 3286f7e88cfa113c83f5470cd65f46f258ddef24 Mon Sep 17 00:00:00 2001
From: Jan Kadlec <jan.kadlec@nic.cz>
Date: Tue, 19 Feb 2013 22:49:39 +0100
Subject: [PATCH] Added missing return.
---
src/libknot/rrset.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/libknot/rrset.c b/src/libknot/rrset.c
index 5e93d1e15..8e9bf2f79 100644
--- a/src/libknot/rrset.c
+++ b/src/libknot/rrset.c
@@ -1936,7 +1936,7 @@ knot_dname_t **knot_rrset_get_next_rr_dname(const knot_rrset_t *rrset,
knot_dname_t **prev_dname,
size_t rr_pos)
{
- if (rrset == NULL || rrset->rdata_count == 0) {
+ if (rrset == NULL || rr_pos >= rrset->rdata_count) {
return NULL;
}
@@ -1974,6 +1974,8 @@ knot_dname_t **knot_rrset_get_next_rr_dname(const knot_rrset_t *rrset,
}
}
}
+
+ return NULL;
}
knot_dname_t **knot_rrset_get_next_dname(const knot_rrset_t *rrset,
@@ -2629,7 +2631,7 @@ dbg_rrset_exec_detail(
knot_dname_t **dname = NULL;
while ((dname = knot_rrset_get_next_rr_dname(rrset, dname,
rdata_pos))) {
- assert(dname);
+ assert(dname && *dname);
dbg_rrset_exec_detail(
char *name = knot_dname_to_str(*dname);
dbg_rrset_detail("rr: dnames_apply: Got dname %s.\n", name);
--
GitLab