diff --git a/src/knot/zone/semantic-check.c b/src/knot/zone/semantic-check.c index 5135adb978fe1c49125e8062abcc067a8612e7dd..ffa7f4f16706e8cca7d326c5447b18f809b833ca 100644 --- a/src/knot/zone/semantic-check.c +++ b/src/knot/zone/semantic-check.c @@ -301,9 +301,6 @@ static int check_rrsig_rdata(err_handler_t *handler, } if (knot_rrs_rrsig_type_covered(rrsig, 0) != rrset->type) { - /* zoneparser would not let this happen - * but to be on the safe side - */ err_handler_handle_error(handler, node, ZC_ERR_RRSIG_RDATA_TYPE_COVERED, info_str); @@ -1089,9 +1086,6 @@ void log_cyclic_errors_in_zone(err_handler_t *handler, /* Check it points somewhere first. */ if (knot_zone_contents_find_nsec3_node(zone, next_dname) == NULL) { - assert(knot_zone_contents_find_node(zone, - next_dname) == - NULL); err_handler_handle_error(handler, last_nsec3_node, ZC_ERR_NSEC3_RDATA_CHAIN, NULL); } else { @@ -1105,9 +1099,9 @@ void log_cyclic_errors_in_zone(err_handler_t *handler, /* Directly discard. */ knot_dname_free(&next_dname, NULL); - } else if (do_checks == 2 ) { + } else if (do_checks == SEM_CHECK_NSEC) { if (last_node == NULL) { - err_handler_handle_error(handler, last_node, + err_handler_handle_error(handler, zone->apex, ZC_ERR_NSEC_RDATA_CHAIN_NOT_CYCLIC, NULL); return; } else { diff --git a/src/knot/zone/zone-create.c b/src/knot/zone/zone-create.c index cc6fd779662d7f66bd07ffb003364cbc2aa5fd3b..0fd0301b631ea355acb4b9bc6afa94e3816b04e6 100644 --- a/src/knot/zone/zone-create.c +++ b/src/knot/zone/zone-create.c @@ -290,7 +290,7 @@ knot_zone_contents_t *zonefile_load(zloader_t *loader) assert(!knot_rrset_empty(&soa_rr)); // In this point, SOA has to exist const bool have_nsec3param = knot_node_rrtype_exists(zc->z->apex, KNOT_RRTYPE_NSEC3PARAM); - if (knot_zone_contents_is_signed(zc->z) && have_nsec3param) { + if (knot_zone_contents_is_signed(zc->z) && !have_nsec3param) { /* Set check level to DNSSEC. */ check_level = SEM_CHECK_NSEC; } else if (knot_zone_contents_is_signed(zc->z) && have_nsec3param) {