GitLab

Deckard's responses to resolvers might be delayed due to load which leads the resolver to close the port and to the test failing in the end. We partially detect these by checking the PCAP for ICMP packets.

Deckard now can run multiple processes inside single simulated network
and communicate with each other.

This introduces couple of incompatible changes:
- command line syntax was changed to accomodate new possibilities (see --help)
- SOCKET_WRAPPER environment variables except DIR are always managed by Deckard

This is again handy for testing pydnstest.testserver.

The testserver can now read scenario specified on command line and use
it instead of the built-in one. This is very useful for testing
pydnstest.testserver module.

Testserver already had all the information so it was unnecessary to pass
them again. The improved TestServer.start() method is going to be
handy in future.

Further work requires importing pydnstest.scenario into testserver.
Socket functions were moved into scenario to avoid cyclic imports
between testserver and scenario modules.

We should be moving the socket functions in the other way,
from scenario into testserver. This will be subject of later
refactoring.

This follows the same behavior as testbound.

Variable names in handle_query were quite confusing so I've renamed
to express their real content. One log message used wrong arguments
because of that so I've fixed that at the same time.

Socket family selectino logic was unnecessarily duplicated several times.

The fallback for None values was never used so it was just rotting
and cluttering the code. Remove it!

Cheap re-indentation using python-autopep8-1.2.1-3.fc25 with few manual
tweaks for very long lines.

This costs nothing and will avoid PEP8 complaints about whitespace in CI.

Cheap re-indentation using reindent.py from python-2.7.13.
This costs nothing and will avoid PEP8 complaints about tabs in CI.

The main problem was that socket.type from Python standard library is
not an integer anymore. It is EnumInt object which is used instead of
bit field. To make the code compatible with both versions of Python we
had to replace all exact value comparisons with bitwise masking.

dnspython library by default coalesces RRsets of same type into one and
automaticaly deduplicates equicalent RRs inside one RRset.
This prevented Deckard from testing DNS messages with duplicate RR.

To prevent this, all DNS messages are now parsed using option
one_rr_per_rrset=True. This setting may create multiple RRsets
of the same type but it seems okay for Deckard because the comparison
algorithms compare individual RRs and ignore how they are distributed
among RRsets.

it is possible for scenario to play on multiple
test subjects, the [servername] in test case file
should either correspond to test subject symbolic
name or be empty (in that case, the first subject is used)

first parameter to STEP QUERY may be "TCP"
in this case, the test subject is queried over TCP

the pydnstest is a generic library
scenario is not responsible for any socket binding
testserver provides mock servers
deckard picks eligible addresses from scenario,
and tells testserver to listen there

this makes the library standalone useable even
without prebinding