kresd is not terminated after KeyboardInterupt of kresd_run.sh

Terminal window remains hanging after the line:

KeyboardInterrupt

kresd has to be killed manually.

changed title from {-kresd is not terminated after user interrupts test execution (^C)-} to kresd is not terminated after KeyboardInterupt of kresd_run.sh

assigned to @skotek

changed time estimate to 3h

To reproduce function conncheck_daemon has to raise KeyboardInterrupt

mentioned in commit 3a747236

mentioned in merge request !76 (merged)

closed via merge request !76 (merged)

reopened

!76 (merged) fixes only part of the problem. kresd can still get stuck in later stages of test execution.

Reproducer:

1. run ./kresd_run.sh
2. terminate it using Ctrl+C
3. look for kresd process using command ps -eF | grep kresd
4. if there is none, goto step 1 :-)

I'm can see stuck kresd process from time to time. There should be none at all when Deckard is terminated (assuming no kresd was run outside of Deckard, of course).

Can I close this issue? @pspacek @sbalazik

removed assignee

assigned to @skotek

I assume you have seen my comment https://gitlab.labs.nic.cz/knot/deckard/issues/3#note_54592 - i.e. it is not fixed yet, please continue work on it.

removed assignee

assigned to @tkrizek

assigned to @sbalazik and unassigned @tkrizek

mentioned in merge request !172 (merged)

Fixing this became rather complicated since the switch to pytest as runner.

Pytest catches ^C and to the best of my knowledge it doesn't pass KeyboardInterrupt to the scripts in any clear way. Python should however kill all its children on any kind of merciful exit.

I tried starting the daemons with subprocess.Popen without the start_new_session=True parameter which seems to solve the issue. (See !172 (merged) for more discussion on this).

closed via merge request !172 (merged)

mentioned in commit e60e2ccc