Deckard: fail on unknown keywords in CONFIG section

All unknown (and, formerly, silently ignored) keywords were removed from
existing tests. This allows us to detect typos.

pydnstest/scenario.py

@@ -947,11 +947,11 @@ def parse_config(scn_cfg, qmin, installdir):
         # Enable selectively for some tests
         if k == 'do-not-query-localhost':
             do_not_query_localhost = str2bool(v)
-        if k == 'domain-insecure':
+        elif k == 'domain-insecure':
             negative_ta_list.append(v)
-        if k == 'harden-glue':
+        elif k == 'harden-glue':
             harden_glue = str2bool(v)
-        if k == 'query-minimization':
+        elif k == 'query-minimization':
             qmin = str2bool(v)
         elif k == 'trust-anchor':
             trust_anchor = v.strip('"\'')
@@ -1003,6 +1003,8 @@ def parse_config(scn_cfg, qmin, installdir):
                                % (v, str(ex)))
         elif k == 'force-ipv6' and v.upper() == 'TRUE':
             sockfamily = socket.AF_INET6
+        else:
+            raise NotImplementedError('unsupported CONFIG key "%s"' % k)
 
     ctx = {
         "DO_NOT_QUERY_LOCALHOST": str(do_not_query_localhost).lower(),

sets/resolver/iter_badraw.rpl

-	name: "."
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_cname_badauth.rpl

 ; config options
-	target-fetch-policy: "3 2 1 0 0"
-	name: "."
+;	target-fetch-policy: "3 2 1 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_cname_cache.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
-	name: "."
+;	target-fetch-policy: "0 0 0 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_cname_double.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
-	name: "."
+;	target-fetch-policy: "0 0 0 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_cname_nx.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
-	name: "."
+;	target-fetch-policy: "0 0 0 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_cname_qnamecopy.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
-	name: "."
+;	target-fetch-policy: "0 0 0 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_cycle.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
-	name: "."
+;	target-fetch-policy: "0 0 0 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_cycle_noh.rpl

 ; config options
 	harden-glue: "no"
-	target-fetch-policy: "0 0 0 0 0"
-	name: "."
+;	target-fetch-policy: "0 0 0 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_domain_sale.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
-	name: "."
+;	target-fetch-policy: "0 0 0 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_domain_sale_nschange.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
-	name: "."
+;	target-fetch-policy: "0 0 0 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_donotq127.rpl

 ; config options
-	name: "."
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_formerr.rpl

 ; config options
-	harden-referral-path: no
-	target-fetch-policy: "0 0 0 0 0"
-        name: "."
+;	harden-referral-path: no
+;	target-fetch-policy: "0 0 0 0 0"
+;        name: "."
 	stub-addr: 193.0.14.129         # K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_hint_lame.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
-	name: "."
+;	target-fetch-policy: "0 0 0 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 	; minimization does not affect priming query
 	query-minimization: off

sets/resolver/iter_lame_aaaa.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
-	name: "."
+;	target-fetch-policy: "0 0 0 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_lame_noaa.rpl

 ; config options
-	harden-referral-path: no
-	target-fetch-policy: "0 0 0 0 0"
-        name: "."
+;	harden-referral-path: no
+;	target-fetch-policy: "0 0 0 0 0"
+;        name: "."
 	stub-addr: 193.0.14.129         # K.ROOT-SERVERS.NET.
 	; test with pre-scripted replies does not make sense with qmin
 	query-minimization: off

sets/resolver/iter_lame_nosoa.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
-	name: "."
+;	target-fetch-policy: "0 0 0 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_lamescrub.rpl

 ; config options
-	name: "."
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_minim_a.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
+;	target-fetch-policy: "0 0 0 0 0"
 	query-minimization: on
-	name: "."
+;	name: "."
 	stub-addr: 127.0.0.10 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_minim_a_nxdomain.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
+;	target-fetch-policy: "0 0 0 0 0"
 	query-minimization: on
-	name: "."
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_minim_nonempty.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
+;	target-fetch-policy: "0 0 0 0 0"
 	query-minimization: on
-	name: "."
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_minim_ns.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
+;	target-fetch-policy: "0 0 0 0 0"
 	query-minimization: on
-	name: "."
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_mod.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
-	module-config: "iterator"
-	name: "."
+;	target-fetch-policy: "0 0 0 0 0"
+;	module-config: "iterator"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_multiple_A.rpl

 ; config options
 ; The island of trust is at example.com
-server:
+;server:
 	trust-anchor: "example.com.		IN DS 438 10 2 33F8133EB48EDB093839E985600EB7B7009EB5AC312D11CCA9007F6B 71D94D7B"
 	val-override-date: "20160308103040"
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.

sets/resolver/iter_ns_badaa.rpl

 ; config options
-	target-fetch-policy: "3 2 1 0 0"
-	name: "."
+;	target-fetch-policy: "3 2 1 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_ns_badglue.rpl

 ; config options
-	target-fetch-policy: "3 2 1 0 0"
-	name: "."
+;	target-fetch-policy: "3 2 1 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_ns_badip.rpl

 ; config options
-	target-fetch-policy: "3 2 1 0 0"
-	name: "."
+;	target-fetch-policy: "3 2 1 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_ns_noglue.rpl

 ; config options
-	target-fetch-policy: "3 2 1 0 0"
-	name: "."
+;	target-fetch-policy: "3 2 1 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_ns_spoof.rpl

 ; config options
-	harden-referral-path: yes
-	target-fetch-policy: "0 0 0 0 0"
-	name: "."
+;	harden-referral-path: yes
+;	target-fetch-policy: "0 0 0 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_pc_a.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
-	name: "."
+;	target-fetch-policy: "0 0 0 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_pc_aaaa.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
-	name: "."
+;	target-fetch-policy: "0 0 0 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_pcdirect.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
-	name: "."
+;	target-fetch-policy: "0 0 0 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_pclame.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
-	name: "."
+;	target-fetch-policy: "0 0 0 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_pcname.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
-	name: "."
+;	target-fetch-policy: "0 0 0 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_pcnamech.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
-	name: "."
+;	target-fetch-policy: "0 0 0 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_pcnamechrec.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
-	name: "."
+;	target-fetch-policy: "0 0 0 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_pcttl.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
-	do-ip6: no
-	name: "."
+;	target-fetch-policy: "0 0 0 0 0"
+;	do-ip6: no
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_reclame_one.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
-	name: "."
+;	target-fetch-policy: "0 0 0 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_reclame_two.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
-	name: "."
+;	target-fetch-policy: "0 0 0 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_recurse.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
-	name: "."
+;	target-fetch-policy: "0 0 0 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_refuse.rpl

 ; config options
-server:
+;server:
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_req_qname.rpl

 ; config options
-server:
-	target-fetch-policy: "0 0 0 0 0"
+;server:
+;	target-fetch-policy: "0 0 0 0 0"
 
-stub-zone:
-	name: "."
+;stub-zone:
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_resolve.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
-	name: "."
+;	target-fetch-policy: "0 0 0 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_soamin.rpl

 ; config options
-	target-fetch-policy: "0 0 0 0 0"
-	name: "."
+;	target-fetch-policy: "0 0 0 0 0"
+;	name: "."
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_tcbit.rpl

 ; config options
-	harden-referral-path: no
-	target-fetch-policy: "0 0 0 0 0"
-        name: "."
+;	harden-referral-path: no
+;	target-fetch-policy: "0 0 0 0 0"
+;        name: "."
 	stub-addr: 193.0.14.129         # K.ROOT-SERVERS.NET.
 CONFIG_END
 

sets/resolver/iter_validate.rpl

 ; config options
-server:
+;server:
 	trust-anchor: ". 3600 IN DS 19036 8 2 49AAC11D7B6F6446702E54A1607371607A1A41855200FD2CE1CDDE32F24E8FB5"
 	val-override-timestamp: "1437625000"
 
-stub-zone:
-	name: "."
+;stub-zone:
+;	name: "."
 	stub-addr: 198.41.0.4 	# a.root-servers.net.
 CONFIG_END
 

sets/resolver/iter_validate_child_zone_noaddr.rpl

 ; config options
-server:
+;server:
 	trust-anchor: ". 3600 IN DS 19036 8 2 49AAC11D7B6F6446702E54A1607371607A1A41855200FD2CE1CDDE32F24E8FB5"
 	val-override-timestamp: "1441892800"
 	query-minimization: off
 
-stub-zone:
-	name: "."
+;stub-zone:
+;	name: "."
 	stub-addr: 198.41.0.4 	# a.root-servers.net.
 CONFIG_END
 

sets/resolver/iter_validate_extradata.rpl

 ; config options
-server:
+;server:
 	trust-anchor: ". 3600 IN DS 19036 8 2 49AAC11D7B6F6446702E54A1607371607A1A41855200FD2CE1CDDE32F24E8FB5"
 	val-override-timestamp: "1437625000"
 
-stub-zone:
-	name: "."
+;stub-zone:
+;	name: "."
 	stub-addr: 198.41.0.4 	# a.root-servers.net.
 CONFIG_END
 

sets/resolver/iter_validate_nsec_nxdomain.rpl

 ; config options
-server:
+;server:
 	trust-anchor: ". 3600 IN DS 19036 8 2 49AAC11D7B6F6446702E54A1607371607A1A41855200FD2CE1CDDE32F24E8FB5"
 	val-override-timestamp: "1438783903"
 	query-minimization: off
 
-stub-zone:
-	name: "."
+;stub-zone:
+;	name: "."
 	stub-addr: 198.41.0.4 	# a.root-servers.net.
 CONFIG_END
 

sets/resolver/nsec3_wildcard_no_data_response.rpl

 ; config options
-server:
+;server:
         stub-addr: 193.0.14.129
 	trust-anchor: ". 3600 IN DS 19036 8 2 49AAC11D7B6F6446702E54A1607371607A1A41855200FD2CE1CDDE32F24E8FB5"
 	val-override-timestamp: "1450794800"

sets/resolver/nsec_name_error_response-part2.rpl

 ; config options
-server:
+;server:
 	trust-anchor: ". 3600 IN DS 17272 13 4 B87AD8C76DC2244E7AA57285057BF533F2E248CC8D7E1A071D8A3837A711A5EA705C4707E6E8911DA653BE1AE019927B"
 	val-override-timestamp: "1442323400"
 	do-not-query-localhost: off
 
-stub-zone:
-	name: "."
+;stub-zone:
+;	name: "."
 	stub-addr: 127.0.0.1 	# ns.
 CONFIG_END
 

sets/resolver/nsec_name_error_response.rpl

 ; config options
-server:
+;server:
 	trust-anchor: ". 3600 IN DS 17272 13 4 B87AD8C76DC2244E7AA57285057BF533F2E248CC8D7E1A071D8A3837A711A5EA705C4707E6E8911DA653BE1AE019927B"
 	val-override-timestamp: "1442323400"
 	do-not-query-localhost: off
 
-stub-zone:
-	name: "."
+;stub-zone:
+;	name: "."
 	stub-addr: 127.0.0.1 	# ns.
 CONFIG_END
 

sets/resolver/nsec_no_data_response.rpl

 ; config options
-server:
+;server:
 	trust-anchor: ". 3600 IN DS 17272 13 4 B87AD8C76DC2244E7AA57285057BF533F2E248CC8D7E1A071D8A3837A711A5EA705C4707E6E8911DA653BE1AE019927B"
 	val-override-timestamp: "1442839270"
 	do-not-query-localhost: off
 
-stub-zone:
-	name: "."
+;stub-zone:
+;	name: "."
 	stub-addr: 127.0.0.1 	# ns.
 CONFIG_END
 

sets/resolver/nsec_ref_to_unsigned1.rpl

 ; config options
 ; The island of trust is at example.com
-server:
+;server:
 	trust-anchor: "example.com.		IN DS 438 10 2 33F8133EB48EDB093839E985600EB7B7009EB5AC312D11CCA9007F6B 71D94D7B"
 	val-override-date: "20160308103040"
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.

sets/resolver/nsec_ref_to_unsigned2.rpl

 ; config options
 ; The island of trust is at example.com
-server:
+;server:
 	trust-anchor: "example.com.		IN DS 438 10 2 33F8133EB48EDB093839E985600EB7B7009EB5AC312D11CCA9007F6B 71D94D7B"
 	val-override-date: "20160308103040"
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.

sets/resolver/nsec_ref_to_unsigned3.rpl

 ; config options
 ; The island of trust is at example.com
-server:
+;server:
 	trust-anchor: "example.com.		IN DS 438 10 2 33F8133EB48EDB093839E985600EB7B7009EB5AC312D11CCA9007F6B 71D94D7B"
 	val-override-date: "20160308103040"
 	stub-addr: 193.0.14.129 	# K.ROOT-SERVERS.NET.

sets/resolver/nsec_wildcard_answer_response.rpl

 ; config options
-server:
+;server:
 	trust-anchor: ". IN DS 41524 8 2 5175938255D97A88F9D16A5A46ED3AE373441DF5058C1666D953005D A6BD57F3"
 	val-override-date: "20170401000000"
 
-stub-zone:
-	name: "."
+;stub-zone:
+;	name: "."
 	stub-addr: 192.0.2.1 	# ns.
 CONFIG_END
 

sets/resolver/nsec_wildcard_no_data_response-part2.rpl

 ; config options
-server:
+;server:
 	trust-anchor: "nsec.example.           IN DS 41524 8 2 D6B102667845D6CDDC05B44466426D9CCC189989BF67ADB23605EED0 BFE2A443"
 	val-override-date: "20170401000000"
 
-stub-zone:
-	name: "."