diff --git a/Doxyfile.in b/Doxyfile.in index 639c7f6bd0799e01f7589d7b4e3df628206bea3e..1f37d48462eb5feabc117571d75b73341773a6c4 100644 --- a/Doxyfile.in +++ b/Doxyfile.in @@ -1465,7 +1465,7 @@ EXT_LINKS_IN_WINDOW = NO FORMULA_FONTSIZE = 10 -# Use the FORMULA_TRANPARENT tag to determine whether or not the images +# Use the FORMULA_TRANSPARENT tag to determine whether or not the images # generated for formulas are transparent PNGs. Transparent PNGs are not # supported properly for IE 6.0, but are supported on all modern browsers. # diff --git a/NEWS b/NEWS index 8f40a00663630c2af4062e9dee62073c35a52190..667f547824faab8f1242da0ae02a58c9ebe88a52 100644 --- a/NEWS +++ b/NEWS @@ -60,7 +60,7 @@ Compatibility: -------------- - configure: option '--enable-xdp=yes' means use an external libbpf if available or use the embedded one - - libzsanner: omitted TTL value is correctly set to the last explicitly stated value (RFC 1035) + - libzscanner: omitted TTL value is correctly set to the last explicitly stated value (RFC 1035) - knotc: zone restore from an old backup (3.0.x) requires forced operation - knotd: configuration option 'server.listen-xdp' is replaced with 'xdp.listen' - knotd: zone file loading with automatic SOA serial incrementation newly @@ -306,7 +306,7 @@ Improvements: ------------- - Processing depth of CNAME and DNAME chains is limited to 20 - Non-FQDN is allowed as 'update-owner-name' configuration option value - - Kdig prints detailed algorithm idendifier for PRIVATEDNS and PRIVATEOID + - Kdig prints detailed algorithm identifier for PRIVATEDNS and PRIVATEOID in multiline mode #334 - Queries with QTYPE ANY or RRSIG are always responded with at most one random RRSet - The statistics module has negligible performance overhead on modern CPUs @@ -321,7 +321,7 @@ Improvements: Bugfixes: --------- - - Module onlinesign responds NXDOMAIN insted of NOERROR (NODATA) if DNSSEC not requested + - Module onlinesign responds NXDOMAIN instead of NOERROR (NODATA) if DNSSEC not requested - Outgoing multi-message transfer can contain invalid compression pointers under specific conditions Knot DNS 2.9.9 (2021-04-01) @@ -427,13 +427,13 @@ Bugfixes: - Shared KSK doesn't work with an initial key - Self-created RRSIGs are still cryptographically verified in some unnecessary cases - Changed NSEC3PARAM not correctly detected during zone update - - NSEC(3) chain not fixed if affected by zone udpate + - NSEC(3) chain not fixed if affected by zone update - knotc orphan purge doesn't work on journal - Online signing configured along with DNSSEC signing can cause MDB_BAD_RSLOT error during server reload - Zone journal access can stuck if mismanaged zone serial - Concurrently added and removed same records in a DDNS message are not properly handled - - Zone check logs error instead of warning after a first error occured + - Zone check logs error instead of warning after a first error occurred Knot DNS 2.9.3 (2020-03-03) =========================== @@ -975,7 +975,7 @@ Improvements: Bugfixes: --------- - - Creeping memory consuption upon server reload #584 + - Creeping memory consumption upon server reload #584 - Kdig incorrectly detects QNAME if 'notify' is a prefix - Server crashes when zone sign fails #587 - CSK->KZSK rollover retires CSK early #588 @@ -1012,7 +1012,7 @@ Features: Improvements: ------------- - - Reduced memory consuption of disabled statistics metrics + - Reduced memory consumption of disabled statistics metrics - Some spelling fixes (Thanks to Daniel Kahn Gillmor) - Server no longer fails to start if MODULE_DIR doesn't exist - Configuration include doesn't fail if empty wildcard match @@ -1033,7 +1033,7 @@ Knot DNS 2.6.5 (2018-02-12) Features: --------- - New 'zone-notify' command in knotc - - Kdig uses '@server' as a hostname for TLS authenticaion if '+tls-ca' is set + - Kdig uses '@server' as a hostname for TLS authentication if '+tls-ca' is set Improvements: ------------- @@ -1145,7 +1145,7 @@ Improvements: - NSEC(3) chain is no longer recomputed whole on every update - Remove inconsistent and unnecessary quoting in log files - Avoiding of overlapping key rollovers at a time - - More DNSSSEC-related semantic checks + - More DNSSEC-related semantic checks - Extended timestamp format in keymgr Bugfixes: @@ -1225,7 +1225,7 @@ Features: Improvements: ------------- - - Allowed binding to non-local adresses for TCP (Thanks to Julian Brost!) + - Allowed binding to non-local addresses for TCP (Thanks to Julian Brost!) - New documentation section for manual DNSSEC key algorithm rollover - Initial KSK also generated in the submission state - The 'ds' keymgr command with no parameter uses all KSK keys @@ -1383,7 +1383,7 @@ Bugfixes: - Timers for expired zones are reset on reload - Zone doesn't expire when the server is down - Failed to handle keys with duplicate keytags - - Per zone module and global module insconsistency + - Per zone module and global module inconsistency - Obsolete online signing module configuration - Malformed output from kjournalprint - Redundant SO_REUSEPORT activation on the TCP socket @@ -1634,7 +1634,7 @@ Bugfixes: - Fix TC flag setting in RRL slipped answers - Disable domain name compression for root label - Log via journald only when running under systemd - - Fix CNAME following when quering for NSEC RR type + - Fix CNAME following when querying for NSEC RR type - Fix refreshing of DNSSEC signatures for zone keys - Fix binding an unavailable IPv6 address on Linux (IP_FREEBIND) - Fix infinite loop in knotc zonestatus and memstats @@ -1734,7 +1734,7 @@ Bugfixes: --------- - Journal file would sometimes outgrow its limit (ixfr-fslimit in configuration) - Fixed incompatibility with OpenSSL 0.9.8 - - Proper handling when hostname cannot be retreived (for NSID and CH) + - Proper handling when hostname cannot be retrieved (for NSID and CH) Features: --------- @@ -1779,7 +1779,7 @@ Knot DNS 1.5.3 (2014-09-15) Bugfixes: --------- - Some specific incoming IXFRs were causing server to crash - - Rare sychronization error during reload caused read-after-free + - Rare synchronization error during reload caused read-after-free - Response synthetization module did not work properly with DNSSEC-enabled zones - When Knot sent AXFR when IXFR was requested, message ID and opcode were wrong - Knot failed to send large messages to remote control (present since 1.5.1) @@ -1831,7 +1831,7 @@ Bugfixes: --------- - Zone flush planning after bootstrap - Incorrect incoming AXFR message sizes - - DDNS signing changes were freed too soon, posibility of stale data + - DDNS signing changes were freed too soon, possibility of stale data - knotc remote control key handling Knot DNS 1.5.0-rc2 (2014-06-18) @@ -1979,7 +1979,7 @@ Features: - Defaults for CH TXT id.server,version.server (see doc) - Much faster bootstrap of many zones - --with-configdir option for default config path - - Reintroducted 'pidfile' config option + - Reintroduced 'pidfile' config option - Utility to estimate memory consumption (see 'knotc memstats') - PID file is not created when running on foreground - UNIX sockets support for knotc @@ -2108,7 +2108,7 @@ Features: - Support for '/' in zone names. - Generating journal from reloaded zone (EXPERIMENTAL). - Outgoing-only interfaces in configuration file. - - Following DNAME if the synthetized name is in the same zone. + - Following DNAME if the synthesized name is in the same zone. Bugfixes: --------- @@ -2213,7 +2213,7 @@ Bugfixes: --------- - Fixed leak when querying non-existing name and zone SOA TTL > minimal. - - Fixed some minor bugs in tansfers. + - Fixed some minor bugs in transfers. Improvements: ------------- @@ -2247,7 +2247,7 @@ Features: --------- - Support for subnets in ACL. - Debug messages enabling in configure. - - Optimized memory consuption of zone structures. + - Optimized memory consumption of zone structures. - NSID support (RFC5001). - Root zone support. - Automatic zone compiling on server start. @@ -2335,7 +2335,7 @@ Known issues: - Root zone support - NSID support - Other DNS classes than IN - - RRSet rotation not implmented + - RRSet rotation not implemented - Dynamic update support - IXFR code might be flaky sometimes - IXFR may be slow when too much (10 000+) RRSets are transferred at diff --git a/configure.ac b/configure.ac index 9dffbe1f7b920e3dfa58b89024e7def5e55c1d04..6f4217f4e8cf5c1e08ee96a9f33eb377c7c607d2 100644 --- a/configure.ac +++ b/configure.ac @@ -156,7 +156,7 @@ PKG_CHECK_MODULES([gnutls], [gnutls >= 3.3], [ [#include <gnutls/gnutls.h>]) AC_CHECK_DECL([GNUTLS_PRIVKEY_FLAG_REPRODUCIBLE], - [AC_DEFINE([HAVE_GLNUTLS_REPRODUCIBLE], [1], [GnuTLS reproducible signing available]) + [AC_DEFINE([HAVE_GNUTLS_REPRODUCIBLE], [1], [GnuTLS reproducible signing available]) # Ensure the version is at least 3.6.10 AC_CHECK_FUNC([gnutls_aead_cipher_encryptv2], [enable_repro_signing=yes], [enable_repro_signing=no])], [enable_repro_signing=no], diff --git a/distro/tests/ansible-roles/obs_repos/tasks/main.yaml b/distro/tests/ansible-roles/obs_repos/tasks/main.yaml index 4f17e874d1d040b4332cf445874c30cc07227005..e5c7465c021456b9d1ff762531a739e09f9d879e 100644 --- a/distro/tests/ansible-roles/obs_repos/tasks/main.yaml +++ b/distro/tests/ansible-roles/obs_repos/tasks/main.yaml @@ -7,5 +7,5 @@ include_vars: "{{ obs_distro }}.yaml" when: obs_distro != "Debian" -- name: Configure upstream reporitories +- name: Configure upstream repositories include: "{{ obs_distro }}.yaml" diff --git a/doc/appendices.rst b/doc/appendices.rst index 8b48a9dae5a60a00c9afe9b4f57ed237936eda77..309bb20bd9deb1aefda4f7dd69a87b6a46649d96 100644 --- a/doc/appendices.rst +++ b/doc/appendices.rst @@ -1,5 +1,5 @@ .. highlight:: none -.. _Appendicies: +.. _Appendices: ********** Appendices diff --git a/doc/configuration.rst b/doc/configuration.rst index f28bd4d0cbd2c2343905b23db0288334f3fd27dc..067d2f9ac33c561ec118845f568ae01f8eff2784 100644 --- a/doc/configuration.rst +++ b/doc/configuration.rst @@ -120,7 +120,7 @@ See the following examples and :ref:`ACL section`. zone: - domain: acl1.example.com. - acl: [deny_rule, address_rule] # deny_rule first here to take precendence + acl: [deny_rule, address_rule] # deny_rule first here to take precedence :: diff --git a/doc/doxygen/Doxy.page.h b/doc/doxygen/Doxy.page.h index e4d0242617d587f025c4ea2c5cd559b313f40a70..ba67a798cd05e2e357dba480171f3f5ca4a88d5f 100644 --- a/doc/doxygen/Doxy.page.h +++ b/doc/doxygen/Doxy.page.h @@ -27,7 +27,7 @@ - \ref dname — Domain name manipulation - \ref pkt — DNS packet manipulation - \ref probe — DNS traffic probe interface - - \ref rr — DNS resource record mmanipulation + - \ref rr — DNS resource record manipulation - \ref rrtype — DNS resource record types - \ref knot-tsig — TSIG operations - \ref wire — Packet wire data manipulation diff --git a/doc/introduction.rst b/doc/introduction.rst index fb90b443bc34ad0d4e6da02af068cb5934a65adc..3047e5a174c2266a998c38b944d9b0aff6a76edc 100644 --- a/doc/introduction.rst +++ b/doc/introduction.rst @@ -17,7 +17,7 @@ implementation which allows it to scale well on SMP systems and operate non-stop even when adding or removing zones. The server itself is accompanied by several utilities for general DNS -operations or for maintaing the server. +operations or for maintaining the server. For more info and downloads see `www.knot-dns.cz <https://www.knot-dns.cz>`_. diff --git a/doc/man/keymgr.8in b/doc/man/keymgr.8in index 091a265f68d28f0a7d691fcef36e50e0fc4e474d..d2f86b3f29df273d324aa15483d94ebfd86b48a4 100644 --- a/doc/man/keymgr.8in +++ b/doc/man/keymgr.8in @@ -114,7 +114,7 @@ Imports a BIND\-style key into KASP database (converting it to PEM format). Takes one argument: path to BIND key file (private or public, but both MUST exist). .TP \fBimport\-pub\fP \fIBIND_pubkey_file\fP -Imports a public key into KASP database. This key won\(aqt be rollovered nor used for signing. +Imports a public key into KASP database. This key won\(aqt be rolled over nor used for signing. Takes one argument: path to BIND public key file. .TP \fBimport\-pem\fP \fIPEM_file\fP [\fIarguments\fP\&...] @@ -180,7 +180,7 @@ Delete old keys that are in state \(aqremoved\(aq. Print to stdout KeySigningRequest based on pre\-generated ZSKs for specified period. .TP \fBsign\-ksr\fP \fIksr_file\fP -Read KeySigingRequest from a text file, sign it using local keyset and print SignedKeyResponse to stdout. +Read KeySigningRequest from a text file, sign it using local keyset and print SignedKeyResponse to stdout. .TP \fBvalidate\-skr\fP \fIskr_file\fP Read SignedKeyResponse from a text file and validate the RRSIGs in it if not corrupt. diff --git a/doc/man/knot.conf.5in b/doc/man/knot.conf.5in index 385ce576c45c4db93a3cc8aa87d81c4dff35d397..1b0c746e39ea809ba32330a667116bf6cc832cd8 100644 --- a/doc/man/knot.conf.5in +++ b/doc/man/knot.conf.5in @@ -323,7 +323,7 @@ Set to 0 for infinity. .SS tcp\-reuseport .sp If enabled, each TCP worker listens on its own socket and the OS kernel -socket load balancing is emloyed using SO_REUSEPORT (or SO_REUSEPORT_LB +socket load balancing is employed using SO_REUSEPORT (or SO_REUSEPORT_LB on FreeBSD). Due to the lack of one shared socket, the server can offer higher response rate processing over TCP. However, in the case of time\-consuming requests (e.g. zone transfers of a TLD zone), enabled reuseport @@ -765,7 +765,7 @@ and durability. Possible values: .INDENT 0.0 .IP \(bu 2 -\fBrobust\fP – The journal database disk sychronization ensures database +\fBrobust\fP – The journal database disk synchronization ensures database durability but is generally slower. .IP \(bu 2 \fBasynchronous\fP – The journal database disk synchronization is optimized for @@ -1339,7 +1339,7 @@ A TTL value for DNSKEY records added into zone apex. \fBNOTE:\fP .INDENT 0.0 .INDENT 3.5 -Has infuence over ZSK key lifetime. +Has influence over ZSK key lifetime. .UNINDENT .UNINDENT .sp @@ -1374,7 +1374,7 @@ A period between KSK activation and the next rollover initiation. \fBNOTE:\fP .INDENT 0.0 .INDENT 3.5 -KSK key lifetime is also infuenced by propagation\-delay, dnskey\-ttl, +KSK key lifetime is also influenced by propagation\-delay, dnskey\-ttl, and KSK submission delay. .sp Zero (aka infinity) value causes no KSK rollover as a result. @@ -1395,7 +1395,7 @@ More exactly, this period is measured since a ZSK is activated, and after this, a new ZSK is generated to replace it within following roll\-over. .sp -ZSK key lifetime is also infuenced by propagation\-delay and dnskey\-ttl +ZSK key lifetime is also influenced by propagation\-delay and dnskey\-ttl .sp Zero (aka infinity) value causes no ZSK rollover as a result. .UNINDENT @@ -1419,7 +1419,7 @@ secondary servers. \fBNOTE:\fP .INDENT 0.0 .INDENT 3.5 -Has infuence over ZSK key lifetime. +Has influence over ZSK key lifetime. .UNINDENT .UNINDENT .sp diff --git a/doc/man/kxdpgun.8in b/doc/man/kxdpgun.8in index 84ede9139a7a9e959c416c0be057bf350549052d..d7197b5d0c86b4af4e52af7663ff1fce94355b59 100644 --- a/doc/man/kxdpgun.8in +++ b/doc/man/kxdpgun.8in @@ -42,7 +42,7 @@ in a loop until a configured duration elapses. The order of queries is not guaranteed. Responses are received (unless disabled) and counted, but not checked against queries. .sp -The number of parallel threads is autodected according to the number of queues +The number of parallel threads is autodetected according to the number of queues configured for the network interface. .SS Options .INDENT 0.0 diff --git a/doc/man/kzonesign.1in b/doc/man/kzonesign.1in index 693b17a560e616a60137db0ae6f35258bd26e5cd..e2b93e36f6e905f01d72a7604b16f4d37d225deb 100644 --- a/doc/man/kzonesign.1in +++ b/doc/man/kzonesign.1in @@ -52,7 +52,7 @@ configuration file. .INDENT 0.0 .TP \fB\-o\fP, \fB\-\-outdir\fP \fIdir_name\fP -Write the output zone file to the specified directory insted of the configured one. +Write the output zone file to the specified directory instead of the configured one. .TP \fB\-r\fP, \fB\-\-rollover\fP Allow key roll\-overs and NSEC3 re\-salt. In order to finish possible KSK submission, diff --git a/doc/man_keymgr.rst b/doc/man_keymgr.rst index e3047bc5db77f69c696ee3545c2746ee789bc907..efa0444f0e694935cdc156d8419c9399777479ae 100644 --- a/doc/man_keymgr.rst +++ b/doc/man_keymgr.rst @@ -87,7 +87,7 @@ Commands Takes one argument: path to BIND key file (private or public, but both MUST exist). **import-pub** *BIND_pubkey_file* - Imports a public key into KASP database. This key won't be rollovered nor used for signing. + Imports a public key into KASP database. This key won't be rolled over nor used for signing. Takes one argument: path to BIND public key file. **import-pem** *PEM_file* [*arguments*...] @@ -153,7 +153,7 @@ Commands related to Offline KSK feature Print to stdout KeySigningRequest based on pre-generated ZSKs for specified period. **sign-ksr** *ksr_file* - Read KeySigingRequest from a text file, sign it using local keyset and print SignedKeyResponse to stdout. + Read KeySigningRequest from a text file, sign it using local keyset and print SignedKeyResponse to stdout. **validate-skr** *skr_file* Read SignedKeyResponse from a text file and validate the RRSIGs in it if not corrupt. diff --git a/doc/man_kxdpgun.rst b/doc/man_kxdpgun.rst index 81b7c9b594a21729f7668e307612b5fb169a998d..c024536776af4f95b0091546be2296372ed04b23 100644 --- a/doc/man_kxdpgun.rst +++ b/doc/man_kxdpgun.rst @@ -18,7 +18,7 @@ in a loop until a configured duration elapses. The order of queries is not guaranteed. Responses are received (unless disabled) and counted, but not checked against queries. -The number of parallel threads is autodected according to the number of queues +The number of parallel threads is autodetected according to the number of queues configured for the network interface. Options diff --git a/doc/man_kzonesign.rst b/doc/man_kzonesign.rst index 44004f6c35407d0a00dcd111f47dd9530fbad24d..5c2499da2ea4c37b3ba9e4a962cba00310dfa298 100644 --- a/doc/man_kzonesign.rst +++ b/doc/man_kzonesign.rst @@ -29,7 +29,7 @@ Options ....... **-o**, **--outdir** *dir_name* - Write the output zone file to the specified directory insted of the configured one. + Write the output zone file to the specified directory instead of the configured one. **-r**, **--rollover** Allow key roll-overs and NSEC3 re-salt. In order to finish possible KSK submission, diff --git a/doc/operation.rst b/doc/operation.rst index 2a2ba7ae017eb21d24cf521bb51ef04155f7fb3c..1151380d6e5ffdda60ce662e0414f8b7af84dfab 100644 --- a/doc/operation.rst +++ b/doc/operation.rst @@ -56,7 +56,7 @@ Also the configuration database can be exported into a textual file:: .. WARNING:: The import and export commands access the configuration database directly, without any interaction with the server. Therefore, any data - not yet commited to the database won't be exported. And the server won't + not yet committed to the database won't be exported. And the server won't reflect imported configuration correctly. So it is strictly recommended to import new configuration when the server is not running. diff --git a/doc/reference.rst b/doc/reference.rst index 4fb0615943bd930e3b9eb3c265abd11a9087d68c..63542210e9f622fd6c5d7802fffc4f02f0d2f5ca 100644 --- a/doc/reference.rst +++ b/doc/reference.rst @@ -318,7 +318,7 @@ tcp-reuseport ------------- If enabled, each TCP worker listens on its own socket and the OS kernel -socket load balancing is emloyed using SO_REUSEPORT (or SO_REUSEPORT_LB +socket load balancing is employed using SO_REUSEPORT (or SO_REUSEPORT_LB on FreeBSD). Due to the lack of one shared socket, the server can offer higher response rate processing over TCP. However, in the case of time-consuming requests (e.g. zone transfers of a TLD zone), enabled reuseport @@ -806,7 +806,7 @@ and durability. Possible values: -- ``robust`` – The journal database disk sychronization ensures database +- ``robust`` – The journal database disk synchronization ensures database durability but is generally slower. - ``asynchronous`` – The journal database disk synchronization is optimized for better performance at the expense of lower database durability in the case of @@ -1442,7 +1442,7 @@ dnskey-ttl A TTL value for DNSKEY records added into zone apex. .. NOTE:: - Has infuence over ZSK key lifetime. + Has influence over ZSK key lifetime. .. WARNING:: Ensure all DNSKEYs with updated TTL are propagated before any subsequent @@ -1473,7 +1473,7 @@ ksk-lifetime A period between KSK activation and the next rollover initiation. .. NOTE:: - KSK key lifetime is also infuenced by propagation-delay, dnskey-ttl, + KSK key lifetime is also influenced by propagation-delay, dnskey-ttl, and KSK submission delay. Zero (aka infinity) value causes no KSK rollover as a result. @@ -1494,7 +1494,7 @@ A period between ZSK activation and the next rollover initiation. and after this, a new ZSK is generated to replace it within following roll-over. - ZSK key lifetime is also infuenced by propagation-delay and dnskey-ttl + ZSK key lifetime is also influenced by propagation-delay and dnskey-ttl Zero (aka infinity) value causes no ZSK rollover as a result. @@ -1522,7 +1522,7 @@ enough to cover propagation of data from the primary server to all secondary servers. .. NOTE:: - Has infuence over ZSK key lifetime. + Has influence over ZSK key lifetime. *Default:* 1 hour diff --git a/doc/requirements.rst b/doc/requirements.rst index 6030d5b64f5d7121564937196a8ddca4fab879ad..1741f42fd072d70aa2217c58667c55e3debcb1c1 100644 --- a/doc/requirements.rst +++ b/doc/requirements.rst @@ -98,7 +98,7 @@ DNS-over-HTTPS (DoH) support in :doc:`kdig<man_kdig>`: * libnghttp2 -The :ref:`XDP funcionality <Mode XDP>` and :doc:`kxdpgun <man_kxdpgun>` +The :ref:`XDP functionality <Mode XDP>` and :doc:`kxdpgun <man_kxdpgun>` tool. These are only supported on Linux operating systems. See the chapter :ref:`Mode XDP <Mode XDP_pre-requisites>` for software and hardware recommendations. diff --git a/scripts/dns_sql2zf.py b/scripts/dns_sql2zf.py index a2edee88613dbb600ec20972380e03052035b35f..17d83f5a4db502220c3a0d25ca8716561ad65d6c 100755 --- a/scripts/dns_sql2zf.py +++ b/scripts/dns_sql2zf.py @@ -122,7 +122,7 @@ def knotc_single(*args): raise Exception("error: knotc %s failed: '%s'" % (str(args), stderr)) def zone_template(zone): - # this function is intended to be patched by user's bussiness logic + # this function is intended to be patched by user's business logic return None # param type: diff --git a/scripts/kinquire.sh b/scripts/kinquire.sh index 61211669a7a2c90d83c596ad12fb72273063adc9..86815b7fbd2af91b1c8b7f3591f2ac08a75c87f8 100755 --- a/scripts/kinquire.sh +++ b/scripts/kinquire.sh @@ -7,7 +7,7 @@ # This script collects selected system and Knot DNS configuration # data and prints them out to the standard output. If the output # is sent through a secure channel to the Knot DNS development team, -# the data can serve as a basis for the Knot DNS performace troubleshooting. +# the data can serve as a basis for the Knot DNS performance troubleshooting. # # Usage: ./kinquire.sh <Knot DNS configuration file> # ./kinquire.sh <Knot DNS configuration DB directory> diff --git a/scripts/ksk_submittion_conf.sh b/scripts/ksk_submittion_conf.sh index 94f4c0e37f3282cb2891ed0ed0954002167bf3f7..7b8cb6ed6fe8cfd23eab095d029954e9235a2bd5 100755 --- a/scripts/ksk_submittion_conf.sh +++ b/scripts/ksk_submittion_conf.sh @@ -3,7 +3,7 @@ if [ -z "$1" -o "${1:0:1}" == "-" ]; then echo "Usage: $0 <zone name> [<resolver IP:port>]" >&2 echo "" >&2 - echo "This script generates part of Knot DNS configuration regarding KSK submittion" >&2 + echo "This script generates part of Knot DNS configuration regarding KSK submission" >&2 echo "for automatic KSK rollover. It gathers IP addresses of all parent zone's NS servers." >&2 echo "You shall specify your zone as the first parameter and facultatively your resolver's" >&2 echo "address and port." >&2 @@ -68,7 +68,7 @@ for NS in $ALL_NS; do done echo "# add this to policy section" -echo -n " ksk-submittion-check: [ " +echo -n " ksk-submission-check: [ " for NS in $ALL_NS; do NSID="${NS//./_}" echo -n "$NSID " diff --git a/scripts/make-dev-archive.sh b/scripts/make-dev-archive.sh index 693ca506efece743c0cb68c60baecbbc330c16e5..5f1c38761b0f8f7178285d5129b2e04a77d3441b 100755 --- a/scripts/make-dev-archive.sh +++ b/scripts/make-dev-archive.sh @@ -1,6 +1,6 @@ #!/bin/bash # SPDX-License-Identifier: GPL-3.0-or-later -# Create a develpoment tarball +# Create a development tarball set -o errexit -o nounset -o xtrace cd "$(dirname ${0})/.." diff --git a/src/contrib/files.h b/src/contrib/files.h index 7489eaf647d61c5213d087ba6ce5713f36f0d251..16a0f4412f4927d30a737017ae01269a9b97ccd1 100644 --- a/src/contrib/files.h +++ b/src/contrib/files.h @@ -35,7 +35,7 @@ char* abs_path(const char *path, const char *base_dir); /*! * Try to compare two paths whether they are identical. * - * \note If any of the two paths doesn't physically exist, their indentity can't + * \note If any of the two paths doesn't physically exist, their identity can't * be detected in some special corner cases. * * \param[in] path1 Absolute or a relative path (a file, a directory, etc.) diff --git a/src/contrib/net.c b/src/contrib/net.c index 0650937b12c2eba96d4d0508714a3d332f355a98..4ea4b12f6d4d0dafe0372b8968af27c6a9bd0633 100644 --- a/src/contrib/net.c +++ b/src/contrib/net.c @@ -512,7 +512,7 @@ static ssize_t io_exec(const struct io *io, int fd, struct msghdr *msg, /* Interrupted or transient error, continue waiting. */ continue; } else if (ret == 0) { - /* Timeouted, exit. */ + /* Timed out, exit. */ return KNOT_ETIMEOUT; } else { /* In specific circumstances with Valgrind, diff --git a/src/contrib/net.h b/src/contrib/net.h index e913bb4d8bdd350d0796adf482faea3c7a223b49..d4d2936e49e82efb943c9c1462f1849f4561a269 100644 --- a/src/contrib/net.h +++ b/src/contrib/net.h @@ -124,7 +124,7 @@ int net_accept(int sock, struct sockaddr_storage *addr); * \param[in] buffer Message buffer. * \param[in] size Size of the message. * \param[in] addr Remote address (ignored for SOCK_STREAM). - * \param[in] timeout_ms Write timeout in miliseconds (-1 for infinity, + * \param[in] timeout_ms Write timeout in milliseconds (-1 for infinity, * not valid for SOCK_DGRAM). * * \return Number of bytes sent or negative error code. @@ -139,7 +139,7 @@ ssize_t net_base_send(int sock, const uint8_t *buffer, size_t size, * \param[out] buffer Receiving buffer. * \param[in] size Capacity of the receiving buffer. * \param[out] addr Remote address (can be NULL). - * \param[in] timeout_ms Read timeout in miliseconds (-1 for infinity). + * \param[in] timeout_ms Read timeout in milliseconds (-1 for infinity). * * \return Number of bytes read or negative error code. */ diff --git a/src/contrib/openbsd/siphash.h b/src/contrib/openbsd/siphash.h index d551fe8593eb9205dcfd29622161949d786590cf..59d952d81dfb2417ede13814149f9a2e20a1a0a6 100644 --- a/src/contrib/openbsd/siphash.h +++ b/src/contrib/openbsd/siphash.h @@ -34,7 +34,7 @@ * optimized for speed on short messages returning a 64bit hash/digest value. * * The number of rounds is defined during the initialization: - * SipHash24_Init() for the fast and resonable strong version + * SipHash24_Init() for the fast and reasonable strong version * SipHash48_Init() for the strong version (half as fast) * * struct SIPHASH_CTX ctx; diff --git a/src/contrib/qp-trie/trie.h b/src/contrib/qp-trie/trie.h index 14fb1a2d079903ea13d5f28be57ec012c809a448..d479d3ea9bfa25962bca265d6fe7c77b880d7da5 100644 --- a/src/contrib/qp-trie/trie.h +++ b/src/contrib/qp-trie/trie.h @@ -166,7 +166,7 @@ void trie_it_prev_loop(trie_it_t *it); /*! \brief Advance iterator to the next element while ignoring the subtree. * * \note Another formulation: skip keys that are prefixed by the current key. - * \TODO: name, maybe _noprefixed? The thing is that in the "subtree" meaning + * \TODO: name, maybe _unprefixed? The thing is that in the "subtree" meaning * doesn't correspond to how the pointers go in the implementation, * but we may not care much for implementation in the API... */ @@ -174,7 +174,7 @@ void trie_it_next_nosub(trie_it_t *it); /*! \brief Advance iterator to the longest prefix of the current key. * - * \TODO: name, maybe _prefix? Arguments similar to _nosub vs. _noprefixed. + * \TODO: name, maybe _prefix? Arguments similar to _nosub vs. _unprefixed. */ void trie_it_parent(trie_it_t *it); diff --git a/src/contrib/time.h b/src/contrib/time.h index 019b8c3fbac7f58ead81719bec981a82973d11ba..97b913a21bbab0ce1c3fd4fc81b9707763a5b939 100644 --- a/src/contrib/time.h +++ b/src/contrib/time.h @@ -46,7 +46,7 @@ struct timespec time_now(void); struct timespec time_diff(const struct timespec *begin, const struct timespec *end); /*! - * \brief Get time elapsed between two events in miliseconds. + * \brief Get time elapsed between two events in milliseconds. */ double time_diff_ms(const struct timespec *begin, const struct timespec *end); diff --git a/src/contrib/url-parser/url_parser.c b/src/contrib/url-parser/url_parser.c index 56244b43c3e247a7e8d6eb5619a64b203e7739ce..5084740fe85ca6e33ceb170e4d97acbfe5db489f 100644 --- a/src/contrib/url-parser/url_parser.c +++ b/src/contrib/url-parser/url_parser.c @@ -551,7 +551,7 @@ http_parser_parse_url(const char *buf, size_t buflen, int is_connect, case s_dead: return 1; - /* Skip delimeters */ + /* Skip delimiters */ case s_req_schema_slash: case s_req_schema_slash_slash: case s_req_server_start: @@ -566,7 +566,7 @@ http_parser_parse_url(const char *buf, size_t buflen, int is_connect, case s_req_server_with_at: found_at = 1; - /* FALLTROUGH */ + /* FALLTHROUGH */ case s_req_server: uf = UF_HOST; break; diff --git a/src/knot/catalog/catalog_db.h b/src/knot/catalog/catalog_db.h index 69da1e4cf5a48f87bbe2948d9a327ba2846cd305..3bbc879c2754b1fdc5d48da1e311148074f210bd 100644 --- a/src/knot/catalog/catalog_db.h +++ b/src/knot/catalog/catalog_db.h @@ -91,7 +91,7 @@ void catalog_abort(catalog_t *cat); /*! * \brief Free up old txns. * - * \note This must be called after catalog_commit() with a delay of synchronnize_rcu(). + * \note This must be called after catalog_commit() with a delay of synchronize_rcu(). * * \param cat Catalog. */ @@ -134,7 +134,7 @@ int catalog_del(catalog_t *cat, const knot_dname_t *member); * * \note This function may be called in multithreaded operation. * - * \param cat Catalog datatase. + * \param cat Catalog database. * \param member Member to search for. * \param catz Out: name of catalog zone it resides in. * \param group Out: configuration group the member resides in. diff --git a/src/knot/catalog/catalog_update.c b/src/knot/catalog/catalog_update.c index 576f95929a2dd23dc520f565a8756a77096a6c0b..5ceab863a18fbc473ef109d7655c62b547ebac24 100644 --- a/src/knot/catalog/catalog_update.c +++ b/src/knot/catalog/catalog_update.c @@ -292,7 +292,7 @@ void catalog_update_finalize(catalog_update_t *u, catalog_t *cat, conf_t *conf) catalog_it_free(it); // This checks if the configuration file has not changed in the way - // it conflicts with existing member zone and let config take precendence. + // it conflicts with existing member zone and let config take precedence. if (cat->ro_txn != NULL) { rem_conflict_ctx_t rcctx = { conf, u }; (void)catalog_apply(cat, NULL, rem_conf_conflict, &rcctx, false); diff --git a/src/knot/catalog/catalog_update.h b/src/knot/catalog/catalog_update.h index de47075a68b1db5c6fb5fcc05162f61597a53912..10399baa43e289a9a884bf373571a79ec5a449f1 100644 --- a/src/knot/catalog/catalog_update.h +++ b/src/knot/catalog/catalog_update.h @@ -44,7 +44,7 @@ typedef struct catalog_upd_val { typedef struct { trie_t *upd; // tree of catalog_upd_val_t, that gonna be changed in catalog - int error; // error occured during generating of upd + int error; // error occurred during generating of upd pthread_mutex_t mutex; // lock for accessing this struct } catalog_update_t; @@ -138,7 +138,7 @@ void catalog_update_finalize(catalog_update_t *u, catalog_t *cat, conf_t *conf); /*! * \brief Put changes from Catalog Update into persistent Catalog database. * - * \param u Catalog update to be commited. + * \param u Catalog update to be committed. * \param cat Catalog to be updated. * * \return KNOT_E* diff --git a/src/knot/catalog/interpret.h b/src/knot/catalog/interpret.h index 76ea1386e769ce818d99ad1ac90712a024e86641..94a95fd71a9ed26677e3e5282a89b0d9b3ea8a28 100644 --- a/src/knot/catalog/interpret.h +++ b/src/knot/catalog/interpret.h @@ -25,7 +25,7 @@ struct zone_contents; * * \param zone Catalog zone in question. * - * \retval KNOT_EZONEINVAL Invalid varsion record. + * \retval KNOT_EZONEINVAL Invalid version record. * \retval KNOT_EISRECORD Some of single-record RRSets has multiple RRs. * \return KNOT_EOK All OK. */ diff --git a/src/knot/common/evsched.c b/src/knot/common/evsched.c index 6b9e85983925dd581251449ddf1fc36e0a5d7fea..4cc356f6c3cca7cbd9316b115e7300ae9b6ed18d 100644 --- a/src/knot/common/evsched.c +++ b/src/knot/common/evsched.c @@ -37,7 +37,7 @@ static int compare_event_heap_nodes(void *e1, void *e2) } /*! - * \brief Get time T (now) + dt miliseconds. + * \brief Get time T (now) + dt milliseconds. */ static struct timeval timeval_in(uint32_t dt) { diff --git a/src/knot/common/fdset.c b/src/knot/common/fdset.c index 3514edc524f215b3ae12553f5ddc5c86f7043a80..a4b37d91949043c8482e057394eb058b42cceaf5 100644 --- a/src/knot/common/fdset.c +++ b/src/knot/common/fdset.c @@ -238,7 +238,7 @@ int fdset_poll(fdset_t *set, fdset_it_t *it, const unsigned offset, const int ti /* * NOTE: Can't skip offset without bunch of syscalls! * Because of that it waits for `ctx->n` (every socket). Offset is set when TCP - * trotlling is ON. Sometimes it can return with sockets where none of them is + * throttling is ON. Sometimes it can return with sockets where none of them is * connected socket, but it should not be common. */ while (it->unprocessed > 0 && fdset_it_get_idx(it) < it->idx) { diff --git a/src/knot/conf/conf.h b/src/knot/conf/conf.h index 68463a10c6a1343fa7e7699706bd13643d078849..acefa7d665d69ee4b91431aa26c1549b201f6be7 100644 --- a/src/knot/conf/conf.h +++ b/src/knot/conf/conf.h @@ -344,7 +344,7 @@ conf_val_t conf_iter_id( * Deletes the section iterator. * * This function should be called when the iterating is early interrupted, - * otherwise this is done automaticaly at KNOT_EOF. + * otherwise this is done automatically at KNOT_EOF. * * \param[in] conf Configuration. * \param[in] iter Configuration iterator. @@ -753,7 +753,7 @@ static inline size_t conf_bg_threads( * Gets the required LMDB readers limit based on the current configuration. * * \note The resulting value is a common limit to journal, kasp, timers, - * and catalog databases. So it's over-estimated for simpicity reasons. + * and catalog databases. So it's over-estimated for simplicity reasons. * * \note This function cannot be used for the configuration database setting :-/ * diff --git a/src/knot/conf/confdb.c b/src/knot/conf/confdb.c index 75f92f9b88015c544edd62ea8069582a00f37eda..e1262c2499fc0251dccef28f156785d3b5a56f94 100644 --- a/src/knot/conf/confdb.c +++ b/src/knot/conf/confdb.c @@ -56,7 +56,7 @@ * # Template section items codes. * [03][00]master: [03] * [03][00]storage: [02] - * # Template identificators. + * # Template identifiers. * [03][01]tpl1\0 * [03][01]tpl2\0 * # Template items values. diff --git a/src/knot/conf/tools.c b/src/knot/conf/tools.c index c372138c90ab557aef4f27094128871ffaa3433f..410e7b629f9866e784e313c51c25f67fb8dcc63f 100644 --- a/src/knot/conf/tools.c +++ b/src/knot/conf/tools.c @@ -617,7 +617,7 @@ int check_policy( return KNOT_EINVAL; } -#ifndef HAVE_GLNUTLS_REPRODUCIBLE +#ifndef HAVE_GNUTLS_REPRODUCIBLE conf_val_t repro_sign = conf_rawid_get_txn(args->extra->conf, args->extra->txn, C_POLICY, C_REPRO_SIGNING, args->id, args->id_len); if (conf_bool(&repro_sign)) { diff --git a/src/knot/ctl/commands.c b/src/knot/ctl/commands.c index ce8d943b9ad4ebfcec32b0e8e47db1d6fc14a9c3..5edf9f03eeb0216ede32df0eadb932c19eef7a4c 100644 --- a/src/knot/ctl/commands.c +++ b/src/knot/ctl/commands.c @@ -753,7 +753,7 @@ static int init_send_ctx(send_ctx_t *ctx, const knot_dname_t *zone_name, // Set the dump style. ctx->style.show_ttl = true; ctx->style.original_ttl = true; - ctx->style.human_tmstamp = true; + ctx->style.human_timestamp = true; // Set the output data buffers. ctx->data[KNOT_CTL_IDX_ZONE] = ctx->zone; diff --git a/src/knot/dnssec/kasp/kasp_db.h b/src/knot/dnssec/kasp/kasp_db.h index fa0fc51e9ca47c720c7463a828d20f301c5445e8..6ed726c65bd90c10a178a018c76a10bedfe78217 100644 --- a/src/knot/dnssec/kasp/kasp_db.h +++ b/src/knot/dnssec/kasp/kasp_db.h @@ -81,7 +81,7 @@ int kasp_db_delete_all(knot_lmdb_db_t *db, const knot_dname_t *zone_name); /*! * \brief Selectively delete zones from the database. * - * \param db KASP dababase. + * \param db KASP database. * \param keep_zone Filtering callback. * \param cb_data Data passed to callback function. * diff --git a/src/knot/dnssec/key-events.h b/src/knot/dnssec/key-events.h index 19369a363fff039adc8a97ab543a490cc43a4042..339c6b92533fd7de2646694010b4fcdfea002d1b 100644 --- a/src/knot/dnssec/key-events.h +++ b/src/knot/dnssec/key-events.h @@ -50,7 +50,7 @@ int knot_dnssec_key_rollover(kdnssec_ctx_t *ctx, zone_sign_roll_flags_t flags, int knot_dnssec_ksk_sbm_confirm(kdnssec_ctx_t *ctx, uint32_t retire_delay); /*! - * \brief Is there a key in sumbmission phase? + * \brief Is there a key in submission phase? * * \param ctx zone signing context * diff --git a/src/knot/dnssec/key_records.c b/src/knot/dnssec/key_records.c index 26eb907a9b2bef25af743f3a7de52244536637cb..c001ed5463f529f83a90b0c695fef211cbfdcef9 100644 --- a/src/knot/dnssec/key_records.c +++ b/src/knot/dnssec/key_records.c @@ -94,7 +94,7 @@ int key_records_dump(char **buf, size_t *buf_size, const key_records_t *r, bool .show_ttl = true, .verbose = true, .original_ttl = true, - .human_tmstamp = true + .human_timestamp = true }; const knot_dump_style_t *style = verbose ? &verb_style : &KNOT_DUMP_STYLE_DEFAULT; diff --git a/src/knot/dnssec/zone-events.h b/src/knot/dnssec/zone-events.h index 6fe8c76de356d8177f916fcf3f7288745dc8698b..88e3d4457074cfaf0f969c5032f36b069e7b7545 100644 --- a/src/knot/dnssec/zone-events.h +++ b/src/knot/dnssec/zone-events.h @@ -105,7 +105,7 @@ int knot_dnssec_sign_update(zone_update_t *update, conf_t *conf, zone_sign_resch * * \param ctx zone signing context * \param salt_changed output if KNOT_EOK: when was the salt last changed? (either ctx->now or 0) - * \param when_resalt output: tmestamp when next resalt takes place + * \param when_resalt output: timestamp when next resalt takes place * * \return KNOT_E* */ diff --git a/src/knot/dnssec/zone-keys.h b/src/knot/dnssec/zone-keys.h index 80b200a6ab838d7cdebd8d1918b90f04d599f147..fa1ba57cecc1897c2f349d459c98afa2ac08d8f3 100644 --- a/src/knot/dnssec/zone-keys.h +++ b/src/knot/dnssec/zone-keys.h @@ -153,11 +153,11 @@ knot_time_t knot_get_next_zone_key_event(const zone_keyset_t *keyset); /*! * \brief Returns DS record rdata for given key. * - * This function caches the results, so caaling again with the same key returns immediately. + * This function caches the results, so calling again with the same key returns immediately. * * \param for_key The key to compute DS for. * \param digesttype DS digest algorithm. - * \param out_donotfree Output: the DS record rdata. Do not call dnssec_binry_free() on this ever. + * \param out_donotfree Output: the DS record rdata. Do not call dnssec_binary_free() on this ever. * * \return Error code, KNOT_EOK if successful. */ diff --git a/src/knot/dnssec/zone-sign.h b/src/knot/dnssec/zone-sign.h index a43a9f7466fb38895ddedac120bd80761d13ade6..2f75d7a33473bc62fde29adbcb65169767244daa 100644 --- a/src/knot/dnssec/zone-sign.h +++ b/src/knot/dnssec/zone-sign.h @@ -66,7 +66,7 @@ bool knot_zone_sign_use_key(const zone_key_t *key, const knot_rrset_t *covered); * \brief Return those keys for whose the CDNSKEY/CDS records shall be created. * * \param ctx DNSSEC context. - * \param zone_keys Zone keyset, includeing ZSKs. + * \param zone_keys Zone keyset, including ZSKs. * * \return Dynarray containing pointers on some KSKs in keyset. */ diff --git a/src/knot/events/events.h b/src/knot/events/events.h index 8376b8b88ebf89208b6ef786650d41eb35f5a062..b542233fb39476a5dd154115521f324f2eaf5fdd 100644 --- a/src/knot/events/events.h +++ b/src/knot/events/events.h @@ -115,7 +115,7 @@ void zone_events_enqueue(struct zone *zone, zone_event_type_t type); * * The function allows to set multiple events at once. * - * The function intreprets time values (t) as follows: + * The function interprets time values (t) as follows: * * t > 0: schedule timer for a given time * t = 0: cancel the timer diff --git a/src/knot/events/handlers/ds_push.c b/src/knot/events/handlers/ds_push.c index f8559af7e230deb4cff2684e0f278f3ed84da479..7521fe17b2744ff9970f53be097e7105394313fe 100644 --- a/src/knot/events/handlers/ds_push.c +++ b/src/knot/events/handlers/ds_push.c @@ -132,7 +132,7 @@ static int ds_push_consume(knot_layer_t *layer, knot_pkt_t *pkt) } if (data->parent_query[0] == '\0') { - // query for parent SOA systematicly fails + // query for parent SOA systematically fails DS_PUSH_LOG(LOG_WARNING, data->zone, data->remote, "unable to query parent SOA"); return KNOT_STATE_FAIL; diff --git a/src/knot/events/handlers/load.c b/src/knot/events/handlers/load.c index ace4595e34fea553ab3db5066e4f557b2eab53c6..522a4513166373daf59013daf3024e6daba79635 100644 --- a/src/knot/events/handlers/load.c +++ b/src/knot/events/handlers/load.c @@ -341,7 +341,7 @@ load_end: catalog_update_clear(zone->cat_members); } - // Schedule depedent events. + // Schedule dependent events. const knot_rdataset_t *soa = zone_soa(zone); zone->timers.soa_expire = knot_soa_expire(soa->rdata); diff --git a/src/knot/events/handlers/update.c b/src/knot/events/handlers/update.c index adad434beba1b80417c8cdf7d0edd9bbad56b359..f7907e6f90adf89ac968a830978a4e80454ad499 100644 --- a/src/knot/events/handlers/update.c +++ b/src/knot/events/handlers/update.c @@ -416,7 +416,7 @@ int event_update(conf_t *conf, zone_t *zone) return KNOT_EOK; } - /* Init updates respones. */ + /* Init updates responses. */ int ret = init_update_responses(&updates); if (ret != KNOT_EOK) { /* Send what responses we can. */ diff --git a/src/knot/include/module.h b/src/knot/include/module.h index 5f888997ce1e3ca4dc23abbe268287038b33ef9b..47ccb85e7575a4fd9f4b9b1f6b558d5b3c0bd34d 100644 --- a/src/knot/include/module.h +++ b/src/knot/include/module.h @@ -398,7 +398,7 @@ typedef enum { /*! Query processing data context parameters. */ typedef struct { - knotd_query_flag_t flags; /*!< Current query flgas. */ + knotd_query_flag_t flags; /*!< Current query flags. */ const struct sockaddr_storage *remote; /*!< Current remote address. */ int socket; /*!< Current network socket. */ unsigned thread_id; /*!< Current thread id. */ diff --git a/src/knot/journal/journal_write.c b/src/knot/journal/journal_write.c index 5151107b58cb0ab25cbcfe6a181170131c6232f2..af1e540981e0107d9942b0839d69f1694fdadb5c 100644 --- a/src/knot/journal/journal_write.c +++ b/src/knot/journal/journal_write.c @@ -30,7 +30,7 @@ static void journal_write_serialize(knot_lmdb_txn_t *txn, serialize_ctx_t *ser, serialize_prepare(ser, JOURNAL_CHUNK_THRESH - JOURNAL_HEADER_SIZE, JOURNAL_CHUNK_MAX - JOURNAL_HEADER_SIZE, &chunk.mv_size); if (chunk.mv_size == 0) { - break; // beware! If this is ommited, it creates empty chunk => EMALF when reading. + break; // beware! If this is omitted, it creates empty chunk => EMALF when reading. } chunk.mv_size += JOURNAL_HEADER_SIZE; chunk.mv_data = NULL; diff --git a/src/knot/journal/journal_write.h b/src/knot/journal/journal_write.h index d647bb539be7c4b166411d59dad4b9ecb2afc3b6..ad280e46db2a54fdf97452473971cf5305e45e2a 100644 --- a/src/knot/journal/journal_write.h +++ b/src/knot/journal/journal_write.h @@ -53,7 +53,7 @@ void journal_merge(zone_journal_t j, knot_lmdb_txn_t *txn, bool merge_zij, * \brief Delete some journal changesets in attempt to fulfill usage quotas. * * \param txn Journal DB transaction. - * \param from Serial-from of the first cangeset to be deleted. + * \param from Serial-from of the first changeset to be deleted. * \param zone Zone name. * \param tofree_size Amount of data (in bytes) to be at least deleted. * \param tofree_count Number of changesets to be at least deleted. @@ -73,7 +73,7 @@ bool journal_delete(knot_lmdb_txn_t *txn, uint32_t from, const knot_dname_t *zon * * \param j Zone journal. * \param txn Journal DB transaction. - * \param md Jounral metadata. + * \param md Journal metadata. * * \note It might set txn->ret to KNOT_EBUSY to fail out from this operation and let the zone flush itself. */ diff --git a/src/knot/journal/knot_lmdb.h b/src/knot/journal/knot_lmdb.h index db8244e39370c447532b43a3655127a1976c5260..6214a10fd644bf187a56d43cc07cf0a440eb4919 100644 --- a/src/knot/journal/knot_lmdb.h +++ b/src/knot/journal/knot_lmdb.h @@ -86,7 +86,7 @@ typedef bool (*knot_lmdb_copy_cb)(MDB_val *cur_key, MDB_val *cur_val); void knot_lmdb_init(knot_lmdb_db_t *db, const char *path, size_t mapsize, unsigned env_flags, const char *dbname); /*! - * \brief Check if the databse exists on the filesystem. + * \brief Check if the database exists on the filesystem. * * \param db The DB in question. * @@ -122,7 +122,7 @@ void knot_lmdb_close(knot_lmdb_db_t *db); /*! * \brief Re-initialise existing DB with modified parameters. * - * \note If the paramateres differ and DB is open, it will be refused. + * \note If the parameters differ and DB is open, it will be refused. * * \param db The DB to be modified. * \param path New path to the DB. @@ -152,7 +152,7 @@ int knot_lmdb_reconfigure(knot_lmdb_db_t *db, const char *path, size_t mapsize, /*! * \brief Close and de-initialise DB. * - * \param db DB to be deinitialised. + * \param db DB to be deinitialized. */ void knot_lmdb_deinit(knot_lmdb_db_t *db); @@ -182,7 +182,7 @@ void knot_lmdb_abort(knot_lmdb_txn_t *txn); /*! * \brief Commit a transaction, or abort it if id had failured. * - * \param txn Transaction to be commited. + * \param txn Transaction to be committed. * * \note If txn->ret equals KNOT_EOK afterwards, whole DB transaction was successful. */ @@ -330,7 +330,7 @@ int knot_lmdb_apply_threadsafe(knot_lmdb_txn_t *txn, const MDB_val *key, bool pr bool knot_lmdb_insert(knot_lmdb_txn_t *txn, MDB_val *key, MDB_val *val); /*! - * \brief Open a transaction, insert a record, commmit and free key's and val's mv_data. + * \brief Open a transaction, insert a record, commit and free key's and val's mv_data. * * \param db DB to be inserted into. * \param key Inserted key. @@ -424,7 +424,7 @@ bool knot_lmdb_make_key_part(void *key_data, size_t key_len, const char *format, * \param format Specifies the number and type of parameters. * \param ... For each character in 'format', pointer to where the values will be stored. * - * \note For B, H, I, L; provide simply pointers to variables of correspodning type. + * \note For B, H, I, L; provide simply pointers to variables of corresponding type. * \note For S, N; provide pointer to pointer - it will be set to pointing inside the buffer, so no allocation here. * \note For D, provide void* and size_t, the data will be copied. * diff --git a/src/knot/modules/dnsproxy/dnsproxy.rst b/src/knot/modules/dnsproxy/dnsproxy.rst index 2a291bed12d0e75180738c4f7db9b6a4bfdc7270..6eec90dbeb07ad453025b3d9c854e789979fc61d 100644 --- a/src/knot/modules/dnsproxy/dnsproxy.rst +++ b/src/knot/modules/dnsproxy/dnsproxy.rst @@ -5,7 +5,7 @@ The module forwards all queries, or all specific zone queries if configured per zone, to the indicated server for resolution. If configured in the fallback -mode, only localy unsatisfied queries are forwarded. I.e. a tiny DNS proxy. +mode, only locally unsatisfied queries are forwarded. I.e. a tiny DNS proxy. There are several uses of this feature: * A substitute public-facing server in front of the real one @@ -87,7 +87,7 @@ A remote response timeout in milliseconds. fallback ........ -If enabled, localy unsatisfied queries leading to REFUSED (no zone) are forwarded. +If enabled, locally unsatisfied queries leading to REFUSED (no zone) are forwarded. If disabled, all queries are directly forwarded without any local attempts to resolve them. @@ -107,7 +107,7 @@ If enabled, TCP Fast Open is used when forwarding TCP queries. catch-nxdomain .............. -If enabled, localy unsatisfied queries leading to NXDOMAIN are forwarded. +If enabled, locally unsatisfied queries leading to NXDOMAIN are forwarded. This option is only relevant in the fallback mode. *Default:* off diff --git a/src/knot/modules/geoip/geoip.rst b/src/knot/modules/geoip/geoip.rst index 9d6ab1dfd76d631030a36745fc94d8640abdec39..cb1ecae7eedef20aa188d0113ee42169c634f6e2 100644 --- a/src/knot/modules/geoip/geoip.rst +++ b/src/knot/modules/geoip/geoip.rst @@ -185,7 +185,7 @@ Using weighted records CNAME: prod2.foo.example.com. ... -Each response is generated through a random pick where each defined record has a likelyhood +Each response is generated through a random pick where each defined record has a likelihood of its weight over the sum of all weights for the requested name to. Records defined in the zone itself (if any) will never be served. diff --git a/src/knot/modules/onlinesign/onlinesign.c b/src/knot/modules/onlinesign/onlinesign.c index d5c83766d1cccd93131700ff4503af2f049ec30f..565a3b8aae8ed084002667e4aba401f907cb97a5 100644 --- a/src/knot/modules/onlinesign/onlinesign.c +++ b/src/knot/modules/onlinesign/onlinesign.c @@ -154,7 +154,7 @@ static void bitmap_add_forced(dnssec_nsec_bitmap_t *map, uint16_t qtype, * * - The bitmap will contain types synthesized by this module. * - The bitmap will contain types from zone and forced - * types which can be potentionally synthesized by other query modules. + * types which can be potentially synthesized by other query modules. */ static dnssec_nsec_bitmap_t *synth_bitmap(const knotd_qdata_t *qdata, const uint16_t *force_types) diff --git a/src/knot/modules/probe/probe.rst b/src/knot/modules/probe/probe.rst index a9513191b782f9f95f681b3d9fc1fe2c66b86558..4d0b1fb48eddf8c2e4399ba7bf7f20198e21e608 100644 --- a/src/knot/modules/probe/probe.rst +++ b/src/knot/modules/probe/probe.rst @@ -58,7 +58,7 @@ path A directory path the UNIX sockets are located. .. NOTE:: - It's recommended to use a directory with the execute permission resctricted + It's recommended to use a directory with the execute permission restricted to the intended probe consumer process owner only. *Default:* :ref:`rundir<server_rundir>` diff --git a/src/knot/modules/static_modules.h.in b/src/knot/modules/static_modules.h.in index 15c8966a8060342e82f1ff0c22107918f09c1249..1e1713e62d376cf64328490337c2773d65be2f30 100644 --- a/src/knot/modules/static_modules.h.in +++ b/src/knot/modules/static_modules.h.in @@ -21,5 +21,5 @@ // Forward declarations of static modules (generated by configure). @STATIC_MODULES_DECLARS@ -// STATIC_MODULES initializator (generated by configure). +// STATIC_MODULES initializer (generated by configure). #define STATIC_MODULES_INIT @STATIC_MODULES_INIT@ diff --git a/src/knot/modules/stats/stats.c b/src/knot/modules/stats/stats.c index cc9caf5f3094f921a9dbbf94357fe6d8e3965f35..cbfdd60f25c794f9ba07ea43b663ccd34bb93184 100644 --- a/src/knot/modules/stats/stats.c +++ b/src/knot/modules/stats/stats.c @@ -488,7 +488,7 @@ static knotd_state_t update_counters(knotd_state_t state, knot_pkt_t *pkt, return state; } - // Count the server opearation. + // Count the server operation. if (stats->operation) { knotd_mod_stats_incr(mod, tid, CTR_OPERATION, operation, 1); } diff --git a/src/knot/nameserver/axfr.c b/src/knot/nameserver/axfr.c index 39fb6ea48983cb3f8c066be2a8be57a8a6e7b494..c08619b234efd971a988c18dda5dab5e47ce3f16 100644 --- a/src/knot/nameserver/axfr.c +++ b/src/knot/nameserver/axfr.c @@ -77,7 +77,7 @@ static int axfr_process_node_tree(knot_pkt_t *pkt, const void *item, struct axfr_proc *axfr = (struct axfr_proc*)state; - int ret = zone_tree_it_begin((zone_tree_t *)item, &axfr->it); // does nothing if already itearating + int ret = zone_tree_it_begin((zone_tree_t *)item, &axfr->it); // does nothing if already iterating /* Put responses. */ while (ret == KNOT_EOK && !zone_tree_it_finished(&axfr->it)) { diff --git a/src/knot/nameserver/chaos.c b/src/knot/nameserver/chaos.c index b7afdf4911225ba5e4ceda09a6ea8fa00d12c79a..b83e2f502d7413ada64586a631665f64a5fe5870 100644 --- a/src/knot/nameserver/chaos.c +++ b/src/knot/nameserver/chaos.c @@ -25,7 +25,7 @@ #define HOPE "Knot DNS developers hope you " static const char *wishes[] = { - HOPE "have all your important life questions aswered without SERVFAIL.", + HOPE "have all your important life questions answered without SERVFAIL.", WISH "many wonderful people in your domain.", WISH "non-empty lymph nodes.", HOPE "resolve the . of your problems.", diff --git a/src/knot/nameserver/internet.c b/src/knot/nameserver/internet.c index c6b6f75763fc34d4f7c4ebf59fa19ef3e49b6812..90767efb89084779bcbf124fc1732388097010a4 100644 --- a/src/knot/nameserver/internet.c +++ b/src/knot/nameserver/internet.c @@ -55,7 +55,7 @@ static int wildcard_visit(knotd_qdata_t *qdata, const zone_node_t *node, return KNOT_EOK; } -/*! \brief Synthetizes a CNAME RR from a DNAME. */ +/*! \brief Synthesizes a CNAME RR from a DNAME. */ static int dname_cname_synth(const knot_rrset_t *dname_rr, const knot_dname_t *qname, knot_rrset_t *cname_rrset, diff --git a/src/knot/nameserver/ixfr.c b/src/knot/nameserver/ixfr.c index 8c1f554090fc3b98b8cd4067996ce73b075c89c8..ec28fac70629471c7a613e55ce74a7b759f0f090 100644 --- a/src/knot/nameserver/ixfr.c +++ b/src/knot/nameserver/ixfr.c @@ -124,7 +124,7 @@ static int ixfr_load_chsets(journal_read_t **journal_read, zone_t *zone, } // please note that the journal serial_to might differ from zone SOA serial - // it is beacuse RCU lock is made at different moment than LMDB txn begin + // it is because RCU lock is made at different moment than LMDB txn begin return journal_read_begin(zone_journal(zone), false, serial_from, journal_read); } diff --git a/src/knot/nameserver/ixfr.h b/src/knot/nameserver/ixfr.h index 3136376647ad796982534da83b0a0920b8ec211e..50b88e7d600f815d6a0d52d33ff8994cc64e4ed8 100644 --- a/src/knot/nameserver/ixfr.h +++ b/src/knot/nameserver/ixfr.h @@ -42,7 +42,7 @@ struct ixfr_proc { /* Changes to be sent. */ journal_read_t *journal_ctx; - /* Currenty processed RRSet. */ + /* Currently processed RRSet. */ knot_rrset_t cur_rr; /* Processing context. */ diff --git a/src/knot/nameserver/nsec_proofs.c b/src/knot/nameserver/nsec_proofs.c index 93e47ffc2121ebac87e7f4becb45895453f22652..71944b1250e7862e01714b7d1a467ee29b4055a0 100644 --- a/src/knot/nameserver/nsec_proofs.c +++ b/src/knot/nameserver/nsec_proofs.c @@ -486,7 +486,7 @@ static int put_nxdomain(const zone_contents_t *zone, * * \param match Node matching QNAME. * \param previous Previous node to QNAME in the zone. - * \param qdata Query procssing data. + * \param qdata Query processing data. * \param resp Response packet. * * \return KNOT_E* diff --git a/src/knot/query/requestor.c b/src/knot/query/requestor.c index ad79e49d4999402fe92eefbd55d489298b1f841a..59d7dcac91e68525a838ae76af81257e7279b158 100644 --- a/src/knot/query/requestor.c +++ b/src/knot/query/requestor.c @@ -301,7 +301,7 @@ int knot_requestor_exec(knot_requestor_t *requestor, knot_request_t *request, requestor->layer.tsig = &request->tsig; - /* Do I/O until the processing is satisifed or fails. */ + /* Do I/O until the processing is satisfied or fails. */ while (layer_active(requestor->layer.state)) { ret = request_io(requestor, request, timeout_ms); if (ret != KNOT_EOK) { diff --git a/src/knot/query/requestor.h b/src/knot/query/requestor.h index 4cdef7e89a23395f57bdf15e413d38390f2a9a25..2e5dab24a7f6ff1027a4dacccc1bae0df9a84da9 100644 --- a/src/knot/query/requestor.h +++ b/src/knot/query/requestor.h @@ -108,7 +108,7 @@ void knot_requestor_clear(knot_requestor_t *requestor); * * \param requestor Requestor instance. * \param request Request instance. - * \param timeout_ms Timeout of each operation in miliseconds (-1 for infinity). + * \param timeout_ms Timeout of each operation in milliseconds (-1 for infinity). * * \return KNOT_EOK or error */ diff --git a/src/knot/server/dthreads.h b/src/knot/server/dthreads.h index 3f2edac1daac69d4d492c89caf404ddb9dfb7fb1..0c243a1c325ebb8d60230064ada8de2727a5bc58 100644 --- a/src/knot/server/dthreads.h +++ b/src/knot/server/dthreads.h @@ -138,7 +138,7 @@ int dt_start(dt_unit_t *unit); * * \note This is useful to interrupt some blocking I/O as well, for example * with SIGALRM, which is handled by default. - * \note Signal handler may be overriden in runnable. + * \note Signal handler may be overridden in runnable. * * \param thread Target thread instance. * \param signum Signal code. @@ -201,7 +201,7 @@ int dt_setaffinity(dthread_t *thread, unsigned* cpu_id, size_t cpu_count); int dt_activate(dthread_t *thread); /*! - * \brief Put thread to idle state, cancells current runnable function. + * \brief Put thread to idle state, cancels current runnable function. * * Thread is flagged with Cancel flag and returns from runnable at the nearest * cancellation point, which requires complying runnable function. diff --git a/src/knot/server/server.c b/src/knot/server/server.c index 5f1f64056edc7dc7c4abfefaded1d35e7f07faf8..d88d241a1f7a188318fd64605e2dbabc256085f6 100644 --- a/src/knot/server/server.c +++ b/src/knot/server/server.c @@ -304,7 +304,7 @@ static iface_t *server_init_xdp_iface(struct sockaddr_storage *addr, bool route_ * \param tcp_reuseport Indication if reuseport on TCP is enabled. * \param socket_affinity Indication if CBPF should be attached. * - * \retval Pointer to a new initialized inteface. + * \retval Pointer to a new initialized interface. * \retval NULL if error. */ static iface_t *server_init_iface(struct sockaddr_storage *addr, @@ -1184,7 +1184,7 @@ int server_reconfigure(conf_t *conf, server_t *server) knot_strerror(ret)); } - /* Reconfiure Timer DB. */ + /* Reconfigure Timer DB. */ if ((ret = reconfigure_timer_db(conf, server)) != KNOT_EOK) { log_error("failed to reconfigure Timer DB (%s)", knot_strerror(ret)); diff --git a/src/knot/updates/changesets.h b/src/knot/updates/changesets.h index 1841bf544584541b71d5aa6af8b8cab2d1981120..a887ddd409790e408e9bbe7f5260f22357b01c97 100644 --- a/src/knot/updates/changesets.h +++ b/src/knot/updates/changesets.h @@ -42,7 +42,7 @@ typedef struct { /*! \brief Changeset iteration structure. */ typedef struct { list_t iters; /*!< List of pending zone iterators. */ - zone_tree_t *trees[4]; /*!< Poiters to zone trees to iterate over. */ + zone_tree_t *trees[4]; /*!< Pointers to zone trees to iterate over. */ size_t n_trees; /*!< Their count. */ zone_tree_it_t it; /*!< Zone tree iterator. */ const zone_node_t *node; /*!< Current zone node. */ @@ -135,7 +135,7 @@ int changeset_remove_removal(changeset_t *ch, const knot_rrset_t *rrset); * * \param ch1 Merge into this changeset. * \param ch2 Merge this changeset. - * \param flags Flags how to handle rendundancies. + * \param flags Flags how to handle redundancies. * * \return KNOT_E* */ diff --git a/src/knot/updates/ddns.c b/src/knot/updates/ddns.c index 467e4eab97373be07582a410e994e5f51d2b782f..6648ca851e3537e43bba86966e7a71a4ac2ca224 100644 --- a/src/knot/updates/ddns.c +++ b/src/knot/updates/ddns.c @@ -349,7 +349,7 @@ static bool singleton_replaced(changeset_t *changeset, } /*!< \brief Adds RR into add section of changeset if it is deemed worthy. */ -static int add_rr_to_chgset(const knot_rrset_t *rr, +static int add_rr_to_changeset(const knot_rrset_t *rr, zone_update_t *update) { if (singleton_replaced(&update->change, rr)) { @@ -380,13 +380,13 @@ static int process_add_cname(const zone_node_t *node, return ret; } - return add_rr_to_chgset(rr, update); + return add_rr_to_changeset(rr, update); } else if (!node_empty(node)) { // Other occupied node => ignore. return KNOT_EOK; } else { // Can add. - return add_rr_to_chgset(rr, update); + return add_rr_to_changeset(rr, update); } } @@ -405,7 +405,7 @@ static int process_add_nsec3param(const zone_node_t *node, } knot_rrset_t param = node_rrset(node, KNOT_RRTYPE_NSEC3PARAM); if (knot_rrset_empty(¶m)) { - return add_rr_to_chgset(rr, update); + return add_rr_to_changeset(rr, update); } char *owner = knot_dname_to_str_alloc(rr->owner); @@ -435,7 +435,7 @@ static int process_add_soa(const zone_node_t *node, return KNOT_EOK; } - return add_rr_to_chgset(rr, update); + return add_rr_to_changeset(rr, update); } /*!< \brief Adds normal RR, ignores when CNAME exists in node. */ @@ -453,7 +453,7 @@ static int process_add_normal(const zone_node_t *node, return KNOT_EOK; } - return add_rr_to_chgset(rr, update); + return add_rr_to_changeset(rr, update); } /*!< \brief Decides what to do with RR addition. */ diff --git a/src/knot/updates/zone-update.c b/src/knot/updates/zone-update.c index fe00fd647b674a0744a258a842db8f19e9c76560..44af6079306620dfb8d667bb5262ec62119046ec 100644 --- a/src/knot/updates/zone-update.c +++ b/src/knot/updates/zone-update.c @@ -31,7 +31,7 @@ #include <unistd.h> #include <urcu.h> -// Call mem_trim() whenever accumuled size of updated zones reaches this size. +// Call mem_trim() whenever accumulated size of updated zones reaches this size. #define UPDATE_MEMTRIM_AT (10 * 1024 * 1024) static int init_incremental(zone_update_t *update, zone_t *zone, zone_contents_t *old_contents) diff --git a/src/knot/updates/zone-update.h b/src/knot/updates/zone-update.h index 5edce40d66e2e9f64c6278315212b3e0b593554d..8a2d7803b5269920afb4d81ce63b36873fbf0a74 100644 --- a/src/knot/updates/zone-update.h +++ b/src/knot/updates/zone-update.h @@ -241,7 +241,7 @@ int zone_update_apply_changeset(zone_update_t *update, const changeset_t *change int zone_update_apply_changeset_reverse(zone_update_t *update, const changeset_t *changes); /*! - * \brief Increment SOA serial (according to cofigured policy) in the update. + * \brief Increment SOA serial (according to configured policy) in the update. * * \param update Update to be modified. * \param conf Configuration. diff --git a/src/knot/zone/adds_tree.h b/src/knot/zone/adds_tree.h index 7a16880e0e2a362a05c3e5e868dc392f286c5da8..386d43b5852681dbcc8c6c78e8c059589e1faad0 100644 --- a/src/knot/zone/adds_tree.h +++ b/src/knot/zone/adds_tree.h @@ -78,7 +78,7 @@ int additionals_tree_update_nsec3(additionals_tree_t *a_t, const zone_contents_t int additionals_tree_from_zone(additionals_tree_t **a_t, const zone_contents_t *zone); /*! - * \brief Update attionals tree according to changed RRsets in all nodes in a zone tree. + * \brief Update additionals tree according to changed RRsets in all nodes in a zone tree. * * \param a_t Additionals tree to be updated. * \param tree Zone tree containing updated nodes as bi-nodes. diff --git a/src/knot/zone/adjust.h b/src/knot/zone/adjust.h index 30b5a83f0171d77784572766fba6ba44c5c30c57..5828e5a48ede73ebe0a590678cf3fc7b3e189b87 100644 --- a/src/knot/zone/adjust.h +++ b/src/knot/zone/adjust.h @@ -28,7 +28,7 @@ typedef struct { typedef int (*adjust_cb_t)(zone_node_t *, adjust_ctx_t *); /* - * \brief Varoius callbacks for adjusting zone node's params and pointers. + * \brief Various callbacks for adjusting zone node's params and pointers. * * \param node Node to be adjusted. Must be already inside the zone contents! * \param zone Zone being adjusted. @@ -88,7 +88,7 @@ int zone_adjust_contents(zone_contents_t *zone, adjust_cb_t nodes_cb, adjust_cb_ * * \note Fixing PREV pointers and zone measurement does not make sense since we are not * iterating over whole zone. The same applies for callback that reference other - * (unchanged, but indirecty affected) zone nodes. + * (unchanged, but indirectly affected) zone nodes. * * \param update Zone update being finalized. * \param nodes_cb Callback for NORMAL nodes. diff --git a/src/knot/zone/digest.h b/src/knot/zone/digest.h index 4522001daeab6031ee41c2f875c91697a80670ec..81d1617cedb26a3fef1925ff0e9ed0e01988cd4c 100644 --- a/src/knot/zone/digest.h +++ b/src/knot/zone/digest.h @@ -49,7 +49,7 @@ bool zone_contents_digest_exists(const zone_contents_t *contents, int alg, bool * * \retval KNOT_EEMPTYZONE The zone is empty. * \retval KNOT_ENOENT There is no ZONEMD in contents' apex. - * \retval KNOT_ENOTSUP None of present ZONEMD is supported (scheme+algrithm+SOAserial). + * \retval KNOT_ENOTSUP None of present ZONEMD is supported (scheme+algorithm+SOAserial). * \retval KNOT_ESEMCHECK Duplicate ZONEMD with identical scheme+algorithm pair. * \retval KNOT_EFEWDATA Error in hash length. * \retval KNOT_EMALF The computed hash differs from ZONEMD. diff --git a/src/knot/zone/timers.c b/src/knot/zone/timers.c index e14d248cbb1cdcfe19ac8059b2b366e25137f186..3c46d78f30078cc0880f1a9c16218d228546be97 100644 --- a/src/knot/zone/timers.c +++ b/src/knot/zone/timers.c @@ -22,7 +22,7 @@ /* * # Timer database * - * Timer database stores timestaps of events which need to be retained + * Timer database stores timestamps of events which need to be retained * across server restarts. The key in the database is the zone name in * wire format. The value contains serialized timers. * diff --git a/src/knot/zone/timers.h b/src/knot/zone/timers.h index 780ece5eaac1968404d736c30626ad9418caa99a..0fb619fcb265e8bccbdd83f3bf63cbe3b4fb8ac3 100644 --- a/src/knot/zone/timers.h +++ b/src/knot/zone/timers.h @@ -74,7 +74,7 @@ int zone_timers_write(knot_lmdb_db_t *db, const knot_dname_t *zone, /*! * \brief Write timers for all zones. * - * \param db Timer databse. + * \param db Timer database. * \param zonedb Zones database. * * \return KNOT_E* @@ -84,7 +84,7 @@ int zone_timers_write_all(knot_lmdb_db_t *db, knot_zonedb_t *zonedb); /*! * \brief Selectively delete zones from the database. * - * \param db Timer dababase. + * \param db Timer database. * \param keep_zone Filtering callback. * \param cb_data Data passed to callback function. * diff --git a/src/knot/zone/zone-diff.c b/src/knot/zone/zone-diff.c index 59d86f1276e272e6b88d809da0eb2f46fd6ef4d8..ca43f919a0d3a235b3319061aac2f2df4a376447 100644 --- a/src/knot/zone/zone-diff.c +++ b/src/knot/zone/zone-diff.c @@ -312,7 +312,7 @@ static int add_new_nodes(zone_node_t *node, void *data) /* * If a node is not present in the second zone, it is a new node - * and has to be added to changeset. Differencies on the RRSet level are + * and has to be added to changeset. Differences on the RRSet level are * already handled. */ zone_node_t *new_node = zone_tree_get(param->nodes, node->owner); diff --git a/src/knot/zone/zone-tree.h b/src/knot/zone/zone-tree.h index 75a04200041bebc45e60159578ed5a311c2b6005..bf8a6600d48dffef7bd99d20f8d2a491018a5695 100644 --- a/src/knot/zone/zone-tree.h +++ b/src/knot/zone/zone-tree.h @@ -199,7 +199,7 @@ int zone_tree_add_node(zone_tree_t *tree, zone_node_t *apex, const knot_dname_t zone_tree_new_node_cb_t new_cb, void *new_cb_ctx, zone_node_t **new_node); /*! - * \brief Remove a node in zone tree, removin also empty parents. + * \brief Remove a node in zone tree, removing also empty parents. * * \param tree Zone tree to remove from. * \param node Node to be removed. diff --git a/src/knot/zone/zone.c b/src/knot/zone/zone.c index 7b99f31a7b40b56a28af378fe26cce85074a15e6..e9610ea813382c59cf7d37e31e175459ff854d2d 100644 --- a/src/knot/zone/zone.c +++ b/src/knot/zone/zone.c @@ -59,7 +59,7 @@ static void free_ddns_queue(zone_t *zone) */ static int flush_journal(conf_t *conf, zone_t *zone, bool allow_empty_zone, bool verbose) { - /*! @note Function expects nobody will change zone contents meanwile. */ + /*! @note Function expects nobody will change zone contents meanwhile. */ assert(zone); diff --git a/src/knot/zone/zone.h b/src/knot/zone/zone.h index b8a3af1c8e1d88b3c24ce13f7aaf6320540c0b90..7a8c2ac0a567eb67b190b08373c2311855c991cd 100644 --- a/src/knot/zone/zone.h +++ b/src/knot/zone/zone.h @@ -103,7 +103,7 @@ typedef struct zone } zone_t; /*! - * \brief Creates new zone with emtpy zone content. + * \brief Creates new zone with empty zone content. * * \param name Zone name. * diff --git a/src/libdnssec/key.h b/src/libdnssec/key.h index e113028c138c67458e044d6d58dac584e452b3c6..65b5c4340ccca521820cd07638e190798a276b5b 100644 --- a/src/libdnssec/key.h +++ b/src/libdnssec/key.h @@ -276,7 +276,7 @@ typedef enum dnssec_key_digest { bool dnssec_algorithm_digest_support(dnssec_key_digest_t algorithm); /*! - * Create DS (Delgation Signer) RDATA from DNSSEC key. + * Create DS (Delegation Signer) RDATA from DNSSEC key. * * \param[in] key DNSSEC key. * \param[in] digest Digest algorithm to be used. diff --git a/src/libdnssec/key/algorithm.c b/src/libdnssec/key/algorithm.c index 7f32fd4b76955b29e78747ac897058b41f7c118b..a9bc3eee47b8d091afa371d2cd0402c7bece2aff 100644 --- a/src/libdnssec/key/algorithm.c +++ b/src/libdnssec/key/algorithm.c @@ -119,7 +119,7 @@ bool dnssec_algorithm_reproducible(dnssec_key_algorithm_t algorithm, bool enable return true; // those are always reproducible case DNSSEC_KEY_ALGORITHM_ECDSA_P256_SHA256: case DNSSEC_KEY_ALGORITHM_ECDSA_P384_SHA384: -#ifdef HAVE_GLNUTLS_REPRODUCIBLE +#ifdef HAVE_GNUTLS_REPRODUCIBLE return enabled; // Reproducible only if GnuTLS supports && enabled #else return false; diff --git a/src/libdnssec/p11/p11.h b/src/libdnssec/p11/p11.h index dfe978cd5167b7ef4b3675f8fd6592554bb8478e..5642a55bedafddfb455e7b8695117581f0c85fb1 100644 --- a/src/libdnssec/p11/p11.h +++ b/src/libdnssec/p11/p11.h @@ -34,7 +34,7 @@ int p11_reinit(void); int p11_load_module(const char *name); /*! - * Clenaup PKCS11 global context. + * Cleanup PKCS11 global context. * * Should be called when the library is deinitialized to prevent memory leaks. */ diff --git a/src/libdnssec/random.h b/src/libdnssec/random.h index 3a575333b3b401e2e22989988f552cf32acc320e..8d4784f51621738414d94b68806c13de4f0c306b 100644 --- a/src/libdnssec/random.h +++ b/src/libdnssec/random.h @@ -37,7 +37,7 @@ * \param data Pointer to the output buffer. * \param size Size of the output buffer. * - * \return Error code, DNSEC_EOK if successful. + * \return Error code, DNSSEC_EOK if successful. */ int dnssec_random_buffer(uint8_t *data, size_t size); @@ -46,7 +46,7 @@ int dnssec_random_buffer(uint8_t *data, size_t size); * * \param data Preallocated binary structure to be filled. * - * \return Error code, DNSEC_EOK if successful. + * \return Error code, DNSSEC_EOK if successful. */ int dnssec_random_binary(dnssec_binary_t *data); diff --git a/src/libdnssec/sign/sign.c b/src/libdnssec/sign/sign.c index ffb1f9d63eae0e9818cefb3d4c0ccd6e8f68381d..3a7bcba2a7f7e633b0b1fcd1508b079fe9ac12f2 100644 --- a/src/libdnssec/sign/sign.c +++ b/src/libdnssec/sign/sign.c @@ -356,7 +356,7 @@ int dnssec_sign_write(dnssec_sign_ctx_t *ctx, dnssec_sign_flags_t flags, dnssec_ }; unsigned gnutls_flags = 0; -#ifdef HAVE_GLNUTLS_REPRODUCIBLE +#ifdef HAVE_GNUTLS_REPRODUCIBLE if (flags & DNSSEC_SIGN_REPRODUCIBLE) { gnutls_flags |= GNUTLS_PRIVKEY_FLAG_REPRODUCIBLE; } diff --git a/src/libdnssec/tsig.c b/src/libdnssec/tsig.c index 7e131875253c15db29a5a2b8c044202d360306e4..b7bd9802b8c875dafd8ae83866770d93045d542c 100644 --- a/src/libdnssec/tsig.c +++ b/src/libdnssec/tsig.c @@ -33,7 +33,7 @@ struct dnssec_tsig_ctx { }; /*! - * TSIG algorithm indentifiers. + * TSIG algorithm identifiers. */ typedef struct { dnssec_tsig_algorithm_t id; diff --git a/src/libknot/control/control.h b/src/libknot/control/control.h index 47294f419daea4c981443ab73d5beda630e8d6a0..2dbc02ade29201cc0d8d54bac0bca9f865cdcb3d 100644 --- a/src/libknot/control/control.h +++ b/src/libknot/control/control.h @@ -32,7 +32,7 @@ typedef enum { KNOT_CTL_IDX_ERROR, /*!< Error message. */ KNOT_CTL_IDX_SECTION, /*!< Configuration section name. */ KNOT_CTL_IDX_ITEM, /*!< Configuration item name. */ - KNOT_CTL_IDX_ID, /*!< Congiguration item identifier. */ + KNOT_CTL_IDX_ID, /*!< Configuration item identifier. */ KNOT_CTL_IDX_ZONE, /*!< Zone name. */ KNOT_CTL_IDX_OWNER, /*!< Zone record owner */ KNOT_CTL_IDX_TTL, /*!< Zone record TTL. */ diff --git a/src/libknot/descriptor.h b/src/libknot/descriptor.h index c1561061d6800d3d0b5f217e5d2e23fd5a45c743..14cd3b3ce3bb9838721c179df4b515136d6e2ae3 100644 --- a/src/libknot/descriptor.h +++ b/src/libknot/descriptor.h @@ -282,7 +282,7 @@ int knot_rrtype_additional_needed(const uint16_t type); * \brief Checks whether the RDATA domain names should be lowercased in * canonical format of RRSet of the given type. * - * Types that should be lowercased are accorrding to RFC 4034, Section 6.2, + * Types that should be lowercased are according to RFC 4034, Section 6.2, * except for NSEC (updated by RFC 6840, Section 5.1) and A6 (not supported). * * \param type RRSet type to check. diff --git a/src/libknot/dname.c b/src/libknot/dname.c index e9d4c8745e15072bf2b7ef31bbf9a71d10dc7568..04638fcc74482060e99ebebca6436b662ab3a56f 100644 --- a/src/libknot/dname.c +++ b/src/libknot/dname.c @@ -117,7 +117,7 @@ int knot_dname_wire_check(const uint8_t *name, const uint8_t *endp, if (name_len + lblen > KNOT_DNAME_MAXLEN) { return KNOT_EMALF; } - /* Update wire size only for noncompressed part. */ + /* Update wire size only for uncompressed part. */ name_len += lblen; if (!is_compressed) { wire_len += lblen; diff --git a/src/libknot/error.c b/src/libknot/error.c index 1b05fbb2432d55b5d3e1412026d79ffd78faf788..fedf26a873479955c43d2974161792f9b2e76c8e 100644 --- a/src/libknot/error.c +++ b/src/libknot/error.c @@ -78,7 +78,7 @@ static const struct error errors[] = { { KNOT_ENORECORD, "no such record in zone found" }, { KNOT_EISRECORD, "such record already exists in zone" }, { KNOT_ENOMASTER, "no usable master" }, - { KNOT_EPREREQ, "UPDATE prerequisity not met" }, + { KNOT_EPREREQ, "UPDATE prerequisite not met" }, { KNOT_ETTL, "TTL mismatch" }, { KNOT_ENOXFR, "transfer was not sent" }, { KNOT_EDENIED, "not allowed" }, diff --git a/src/libknot/packet/pkt.h b/src/libknot/packet/pkt.h index fa8ae5fbb734955fef6d6bb1735f95e276fe2c18..9419d0819f7675c7512ecebc9552c5cff4bea0da 100644 --- a/src/libknot/packet/pkt.h +++ b/src/libknot/packet/pkt.h @@ -391,7 +391,7 @@ static inline int knot_pkt_default_padding_size(const knot_pkt_t *pkt, KNOT_EDNS_ALIGNMENT_RESPONSE_DEFAULT); } else { return knot_edns_alignment_size(pkt->size, knot_rrset_size(opt_rr), - KNOT_EDNS_ALIGNMENT_QUERY_DEFALT); + KNOT_EDNS_ALIGNMENT_QUERY_DEFAULT); } } diff --git a/src/libknot/rrset-dump.c b/src/libknot/rrset-dump.c index 83eecd24b31cac2fd651e5242ac3ba5d8bcc6a90..ade38ba4bbb38e9f45384df28b455ba4cf74601f 100644 --- a/src/libknot/rrset-dump.c +++ b/src/libknot/rrset-dump.c @@ -82,7 +82,7 @@ const knot_dump_style_t KNOT_DUMP_STYLE_DEFAULT = { .original_ttl = true, .empty_ttl = false, .human_ttl = false, - .human_tmstamp = true, + .human_timestamp = true, .hide_crypto = false, .ascii_to_idn = NULL, .color = NULL, @@ -685,7 +685,7 @@ static void wire_timestamp_to_str(rrset_dump_params_t *p) time_t timestamp = ntohl(data); - if (p->style->human_tmstamp) { + if (p->style->human_timestamp) { struct tm result; // Write timestamp in YYYYMMDDhhmmss format. ret = strftime(p->out, p->out_max, "%Y%m%d%H%M%S", @@ -1034,7 +1034,7 @@ static void wire_loc_to_str(rrset_dump_params_t *p) // Altitude calculation. double alt = 0.01 * alt_w - 100000.0; - // Compute mantisa and exponent for each size. + // Compute mantissa and exponent for each size. uint8_t size_m = size_w >> 4; uint8_t size_e = size_w & 0xF; uint8_t hpre_m = hpre_w >> 4; diff --git a/src/libknot/rrset-dump.h b/src/libknot/rrset-dump.h index c4785542b6440c8d9380110669c4c173cd6d97eb..da7dc2c745a92a6acbba0cbbd6cd62c57651377f 100644 --- a/src/libknot/rrset-dump.h +++ b/src/libknot/rrset-dump.h @@ -46,7 +46,7 @@ typedef struct { /*!< Format TTL as DHMS. */ bool human_ttl; /*!< Format timestamp as YYYYMMDDHHmmSS. */ - bool human_tmstamp; + bool human_timestamp; /*!< Force generic data representation. */ bool generic; /*!< Hide binary parts of RRSIGs and DNSKEYs. */ diff --git a/src/libknot/rrtype/opt.h b/src/libknot/rrtype/opt.h index cc991f4b8d9c0edaeb6369e8b4ca06879154e250..2a7d762f6cccea035d8caa3f993c0fe7a9cab326 100644 --- a/src/libknot/rrtype/opt.h +++ b/src/libknot/rrtype/opt.h @@ -58,7 +58,7 @@ enum { KNOT_EDNS_CLIENT_SUBNET_ADDRESS_MAXLEN = 16, /*! \brief Default EDNS alignment size for a query. */ - KNOT_EDNS_ALIGNMENT_QUERY_DEFALT = 128, + KNOT_EDNS_ALIGNMENT_QUERY_DEFAULT = 128, /*! \brief Default EDNS alignment size for a response. */ KNOT_EDNS_ALIGNMENT_RESPONSE_DEFAULT = 468, diff --git a/src/libknot/rrtype/tsig.h b/src/libknot/rrtype/tsig.h index 36c1f702aea2772a3499899eb67333afeb4b6ede..083a063c3dce7b9125eb7815f17c5472e14fe544 100644 --- a/src/libknot/rrtype/tsig.h +++ b/src/libknot/rrtype/tsig.h @@ -41,7 +41,7 @@ enum tsig_consts { + sizeof(uint16_t) // fudge + sizeof(uint16_t) // error + sizeof(uint16_t),// other data length - KNOT_TSIG_TIMERS_LENGTH = sizeof(uint16_t) //fugde + KNOT_TSIG_TIMERS_LENGTH = sizeof(uint16_t) //fudge + 6 // time signed }; diff --git a/src/libknot/rrtype/zonemd.h b/src/libknot/rrtype/zonemd.h index ba1c8387784774929d6a5f957d7077b629513447..a4d734bdc73fdada5030d9084ce9dcbf4eb911f9 100644 --- a/src/libknot/rrtype/zonemd.h +++ b/src/libknot/rrtype/zonemd.h @@ -27,8 +27,8 @@ #include "libknot/wire.h" #define KNOT_ZONEMD_SCHEME_SIMPLE 1 -#define KNOT_ZONEMD_ALORITHM_SHA384 1 -#define KNOT_ZONEMD_ALORITHM_SHA512 2 +#define KNOT_ZONEMD_ALGORITHM_SHA384 1 +#define KNOT_ZONEMD_ALGORITHM_SHA512 2 static inline uint32_t knot_zonemd_soa_serial(const knot_rdata_t *rdata) @@ -55,8 +55,8 @@ static inline size_t knot_zonemd_digest_size(const knot_rdata_t *rdata) { switch (knot_zonemd_algorithm(rdata)) { - case KNOT_ZONEMD_ALORITHM_SHA384: return 48; - case KNOT_ZONEMD_ALORITHM_SHA512: return 64; + case KNOT_ZONEMD_ALGORITHM_SHA384: return 48; + case KNOT_ZONEMD_ALGORITHM_SHA512: return 64; default: return 0; } } diff --git a/src/libknot/tsig-op.c b/src/libknot/tsig-op.c index b035a4a26fc931697fa1a34b3c84c7d348125f2e..7913859c2422efef8cff81c4316a62ebdcb46a67 100644 --- a/src/libknot/tsig-op.c +++ b/src/libknot/tsig-op.c @@ -232,7 +232,7 @@ static int create_sign_wire(const uint8_t *msg, size_t msg_len, /* * Create tmp wire, it should contain message - * plus request mac plus tsig varibles. + * plus request mac plus tsig variables. */ size_t wire_len = msg_len + request_mac_len + (request_mac_len > 0 ? 2 : 0) + knot_tsig_rdata_tsig_variables_length(tmp_tsig); @@ -290,7 +290,7 @@ static int create_sign_wire_next(const uint8_t *msg, size_t msg_len, /* * Create tmp wire, it should contain message - * plus request mac plus tsig varibles. + * plus request mac plus tsig variables. */ size_t wire_len = msg_len + prev_mac_len + knot_tsig_rdata_tsig_timers_length() + 2; uint8_t *wire = malloc(wire_len); diff --git a/src/libknot/xdp/eth.h b/src/libknot/xdp/eth.h index d6fd319db4f9011527c4c74f20536dafb6b60780..246240db7c8cf27c4e3b40e28638ea0b62c26ac9 100644 --- a/src/libknot/xdp/eth.h +++ b/src/libknot/xdp/eth.h @@ -53,7 +53,7 @@ int knot_eth_mtu(const char *devname); /*! * \brief Get the corresponding network interface name for the address. * - * \param addr Address of the inteface. + * \param addr Address of the interface. * \param out Output buffer for the interface name. * \param out_len Size of the output buffer. * @@ -69,7 +69,7 @@ typedef enum { } knot_xdp_mode_t; /*! - * \brief Return the current XDP mode of a network inteface. + * \brief Return the current XDP mode of a network interface. * * \param if_index Index of the interface, output from if_nametoindex(). * diff --git a/src/libknot/xdp/protocols.h b/src/libknot/xdp/protocols.h index f74c5f71adfb219d9a9d0935f0183fc9bf05a52f..7b9829e1df8bb67832794bff9f95b90fe034af12 100644 --- a/src/libknot/xdp/protocols.h +++ b/src/libknot/xdp/protocols.h @@ -203,7 +203,7 @@ inline static size_t prot_write_hdrs_len(const knot_xdp_msg_t *msg) * The basis for checksum is addition on big-endian 16-bit words, with bit 16 carrying * over to bit 0. That can be viewed as first byte carrying to the second and the * second one carrying back to the first one, i.e. a symmetrical situation. - * Therefore the result is the same even when arithmetics is done on litte-endian (!) + * Therefore the result is the same even when arithmetics is done on little-endian (!) */ inline static void checksum(uint32_t *result, const void *_data, uint32_t _data_len) diff --git a/src/libknot/xdp/tcp.c b/src/libknot/xdp/tcp.c index 425dc14d50e441e16ecf8443bbc1bdcbd673afe9..5824d6a0eb207902ca6b5d527fedfd06a49367fd 100644 --- a/src/libknot/xdp/tcp.c +++ b/src/libknot/xdp/tcp.c @@ -251,7 +251,7 @@ int knot_tcp_relay(knot_xdp_socket_t *socket, knot_xdp_msg_t msgs[], uint32_t ms knot_tcp_relay_t relay = { .msg = msg, .conn = *conn }; - // process incomming data + // process incoming data if (seq_ack_match && (msg->flags & KNOT_XDP_MSG_ACK) && msg->payload.iov_len > 0) { resp_ack(msg, KNOT_XDP_MSG_ACK); relay.action = XDP_TCP_DATA; @@ -325,7 +325,7 @@ int knot_tcp_relay(knot_xdp_socket_t *socket, knot_xdp_msg_t msgs[], uint32_t ms } } // unmatching ACK is ignored, this includes: - // - incomming out-of-order data + // - incoming out-of-order data // - ACK of some previous part of outgoing data } else { switch ((*conn)->state) { diff --git a/src/libknot/xdp/tcp.h b/src/libknot/xdp/tcp.h index a711ecef0f4afb62b3ddc95ae9326536598b95d0..7b9a69191df40a9f24d071c27bb9cc7fab70f791 100644 --- a/src/libknot/xdp/tcp.h +++ b/src/libknot/xdp/tcp.h @@ -176,8 +176,8 @@ int knot_tcp_send(knot_xdp_socket_t *socket, knot_tcp_relay_t relays[], uint32_t * \param max_at_once Don't close more connections at once. * \param close_timeout Gracefully close connections older than this (usecs). * \param reset_timeout Reset connections older than this (usecs). - * \param reset_at_least Reset at least this number of oldest conecctions, even - * when not yet timeouted. + * \param reset_at_least Reset at least this number of oldest connections, even + * when not yet timed out. * \param reset_buf_size Reset oldest connection with buffered partial DNS messages * to free up this amount of space. * \param close_count Optional: Out: incremented with number of closed connections. diff --git a/src/libknot/xdp/tcp_iobuf.h b/src/libknot/xdp/tcp_iobuf.h index a6ccf24222696f07b3a527116d5df93623fd7c1f..56e90a5563eccdabad7701731191ff7d959e8eef 100644 --- a/src/libknot/xdp/tcp_iobuf.h +++ b/src/libknot/xdp/tcp_iobuf.h @@ -46,7 +46,7 @@ inline static size_t tcp_payload_len(const struct iovec *payload) * \brief Handle DNS-over-TCP payloads in buffer and message. * * \param buffer In/out: persistent buffer to store incomplete DNS payloads between receiving packets. - * \param data In/out: momental DNS payloads in incomming packet. + * \param data In/out: momental DNS payloads in incoming packet. * \param data_tofree Out: once more DNS payload defragmented from multiple packets. * \param buffers_total In/Out: total size of buffers (will be increased or decreased). * diff --git a/src/libknot/xdp/xdp.h b/src/libknot/xdp/xdp.h index 019c451d0308763ffba79d97d245365f2e15c937..149c7535db1a0d0cb958fca991a69289a72844ce 100644 --- a/src/libknot/xdp/xdp.h +++ b/src/libknot/xdp/xdp.h @@ -73,7 +73,7 @@ int knot_xdp_init(knot_xdp_socket_t **socket, const char *if_name, int if_queue, void knot_xdp_deinit(knot_xdp_socket_t *socket); /*! - * \brief Return a file descriptor to be polled on for incomming packets. + * \brief Return a file descriptor to be polled on for incoming packets. * * \param socket XDP socket. * @@ -154,7 +154,7 @@ int knot_xdp_send_finish(knot_xdp_socket_t *socket); * \brief Receive multiple packets thru XDP. * * \param socket XDP socket. - * \param msgs Out: buffers to be filled in with incomming packets. + * \param msgs Out: buffers to be filled in with incoming packets. * \param max_count Limit for number of packets received at once. * \param count Out: real number of received packets. * \param wire_size Out: (optional) total wire size of received packets. diff --git a/src/libknot/yparser/ypschema.h b/src/libknot/yparser/ypschema.h index 35ee2ec0cba253502ca0dfa283088cf0923ac767..bb3e425af0aa90e2ae8925c3d1abdd18428bd225 100644 --- a/src/libknot/yparser/ypschema.h +++ b/src/libknot/yparser/ypschema.h @@ -131,7 +131,7 @@ typedef union { /*! Possible unit type. */ yp_style_t unit; } i; - /*! Boolen variables. */ + /*! Boolean variables. */ struct { /*! Default value. */ bool dflt; @@ -163,7 +163,7 @@ typedef union { uint8_t const *dflt; /*! Text to binary transformation function. */ int (*to_bin)(YP_TXT_BIN_PARAMS); - /*! Binary to text transformatio function. */ + /*! Binary to text transformation function. */ int (*to_txt)(YP_BIN_TXT_PARAMS); } d; /*! Reference variables. */ diff --git a/src/libzscanner/functions.h b/src/libzscanner/functions.h index 01ebaf5d2fd3369d0fb414ae56638fe2bb80e630..5f996fc464e9101c9efb578b442bc0ba8bb6e305 100644 --- a/src/libzscanner/functions.h +++ b/src/libzscanner/functions.h @@ -89,7 +89,7 @@ int date_to_timestamp(uint8_t *buff, uint32_t *timestamp); /*! * \brief Converts wire-format dname to text dname. * - * \param data Buffer containg wire-format dname. + * \param data Buffer containing wire-format dname. * \param data_len Length of the buffer. * \param text Text output. */ @@ -98,9 +98,9 @@ void wire_dname_to_str(const uint8_t *data, char *text); /*! - * \brief Converts unsigned integer to mantisa*10^(exponent). + * \brief Converts unsigned integer to mantissa*10^(exponent). * - * Given number is encoded as two 4-bit numbers. First part is mantisa [0-9], + * Given number is encoded as two 4-bit numbers. First part is mantissa [0-9], * second part is decimal exponent [0-15]. Result is concatenation of these * two blocks. * diff --git a/src/libzscanner/scanner.c.t0 b/src/libzscanner/scanner.c.t0 index b316b5d55ebea0a90a9d9fd473d62269ab81b0bd..97c8a890ed847665defcbd4517dcf5203a5f7410 100644 --- a/src/libzscanner/scanner.c.t0 +++ b/src/libzscanner/scanner.c.t0 @@ -6568,7 +6568,7 @@ int zs_set_input_file( ERR(ZS_FILE_INVALID); input_deinit(s, false); return -1; - } else if (file_stat.st_size > 0) { // Mmap non-emtpy file. + } else if (file_stat.st_size > 0) { // Mmap non-empty file. start = mmap(0, file_stat.st_size, PROT_READ, MAP_SHARED, s->file.descriptor, 0); if (start == MAP_FAILED) { diff --git a/src/libzscanner/scanner.rl b/src/libzscanner/scanner.rl index 25e5bf522e48184d11fe8489a3ceec29c5e9e3cf..6083d526f7269ab14d2822b4c1a7f4f076077c47 100644 --- a/src/libzscanner/scanner.rl +++ b/src/libzscanner/scanner.rl @@ -314,7 +314,7 @@ int zs_set_input_file( ERR(ZS_FILE_INVALID); input_deinit(s, false); return -1; - } else if (file_stat.st_size > 0) { // Mmap non-emtpy file. + } else if (file_stat.st_size > 0) { // Mmap non-empty file. start = mmap(0, file_stat.st_size, PROT_READ, MAP_SHARED, s->file.descriptor, 0); if (start == MAP_FAILED) { diff --git a/src/libzscanner/scanner_body.rl b/src/libzscanner/scanner_body.rl index 0dbcf3af5365a4ebe6b2833c8ff08fe9f6a998eb..34d51cdc00f212eace883025025dc05dd80ce1b8 100644 --- a/src/libzscanner/scanner_body.rl +++ b/src/libzscanner/scanner_body.rl @@ -1865,7 +1865,7 @@ svcb_params = all_wchar ${ fhold; fcall svcb_params_; }; # END - # BEGIN - Mnemomic names processing + # BEGIN - Mnemonic names processing action _dns_alg_error { WARN(ZS_BAD_ALGORITHM); fhold; fgoto err_line; diff --git a/src/utils/common/exec.h b/src/utils/common/exec.h index 2940be485ca329baa598d9a763025a0ffa0db545..f96b1b04a0105ad89a30c0bb24cf95d4fb8f928a 100644 --- a/src/utils/common/exec.h +++ b/src/utils/common/exec.h @@ -57,7 +57,7 @@ void print_data_xfr(const knot_pkt_t *packet, const style_t *style); * \param net Connection information. * \param elapsed Total elapsed time. * \param exec_time Time of the packet creation. - * \param style Style of the otput. + * \param style Style of the output. */ void print_footer_xfr(const size_t total_len, const size_t msg_count, @@ -76,7 +76,7 @@ void print_footer_xfr(const size_t total_len, * \param elapsed Total elapsed time. * \param exec_time Time of the packet creation. * \param incoming Indicates if the packet is input. - * \param style Style of the otput. + * \param style Style of the output. */ void print_packet(const knot_pkt_t *packet, const net_t *net, diff --git a/src/utils/common/lookup.h b/src/utils/common/lookup.h index 3f43ab6262ba69231988553ca1d45f0d202097ca..fc416f0912e580e900c4386192c34571e05cec11 100644 --- a/src/utils/common/lookup.h +++ b/src/utils/common/lookup.h @@ -38,7 +38,7 @@ typedef struct { /*! Iteration context. */ struct { - /*! Total number of possibilies. */ + /*! Total number of possibilities. */ size_t count; /*! The first possibility. */ char *first_key; diff --git a/src/utils/common/util_conf.h b/src/utils/common/util_conf.h index 68767692618a8a690010b2399b80d6fc4ae15491..a71d88694638d65a8fcfcde0a2d21deae78d204f 100644 --- a/src/utils/common/util_conf.h +++ b/src/utils/common/util_conf.h @@ -81,6 +81,6 @@ int util_conf_init_default(bool allow_db); void util_update_privileges(void); /*! - * \brief Deinitialize utlity conf() from util_conf_init_*(). + * \brief Deinitialize utility conf() from util_conf_init_*(). */ void util_conf_deinit(void); diff --git a/src/utils/kdig/kdig_params.c b/src/utils/kdig/kdig_params.c index f6c4bcb727e84ac8959558d25c028624f607b763..623ed88d4c0b470edcec304e27c32bd820b57b66 100644 --- a/src/utils/kdig/kdig_params.c +++ b/src/utils/kdig/kdig_params.c @@ -67,7 +67,7 @@ static const style_t DEFAULT_STYLE_DIG = { .original_ttl = false, .empty_ttl = false, .human_ttl = false, - .human_tmstamp = true, + .human_timestamp = true, .generic = false, .ascii_to_idn = name_to_idn }, diff --git a/src/utils/keymgr/functions.c b/src/utils/keymgr/functions.c index 409999e51bde363217ce1f2bcd4377bfbae0e924..a12f6cfed212e474fb57fdb1c96017e3c57bf933 100644 --- a/src/utils/keymgr/functions.c +++ b/src/utils/keymgr/functions.c @@ -200,8 +200,8 @@ static int check_timers(const knot_kasp_key_timing_t *t) // modifies ctx->policy options, so don't do anything afterwards ! int keymgr_generate_key(kdnssec_ctx_t *ctx, int argc, char *argv[]) { - knot_time_t now = knot_time(), infty = 0; - knot_kasp_key_timing_t gen_timing = { now, infty, now, infty, now, infty, infty, infty, infty }; + knot_time_t now = knot_time(), infinity = 0; + knot_kasp_key_timing_t gen_timing = { now, infinity, now, infinity, now, infinity, infinity, infinity, infinity }; kdnssec_generate_flags_t flags = 0; uint16_t keysize = 0; const char *addtopolicy = NULL; @@ -215,7 +215,7 @@ int keymgr_generate_key(kdnssec_ctx_t *ctx, int argc, char *argv[]) return ret; } - if ((flags & DNSKEY_GENERATE_KSK) && gen_timing.ready == infty) { + if ((flags & DNSKEY_GENERATE_KSK) && gen_timing.ready == infinity) { gen_timing.ready = gen_timing.active; } @@ -507,7 +507,7 @@ static int import_key(kdnssec_ctx_t *ctx, unsigned backend, const char *param, goto fail; } - // put pem to kesytore + // put pem to keystore ret = dnssec_keystore_import(ctx->keystore, &pem, &keyid); dnssec_binary_free(&pem); if (ret != DNSSEC_EOK) { diff --git a/src/utils/keymgr/offline_ksk.c b/src/utils/keymgr/offline_ksk.c index 22c3c02c612e8e70939d8aec5d85b511ecad0188..ae865134b6d42d436864f7576d441fc5f98fdc73 100644 --- a/src/utils/keymgr/offline_ksk.c +++ b/src/utils/keymgr/offline_ksk.c @@ -128,7 +128,7 @@ static int dump_rrset_to_buf(const knot_rrset_t *rrset, char **buf, size_t *buf_ .show_ttl = true, .verbose = true, .original_ttl = true, - .human_tmstamp = true + .human_timestamp = true }; return knot_rrset_txt_dump(rrset, buf, buf_size, &style); } diff --git a/src/utils/khost/khost_params.c b/src/utils/khost/khost_params.c index d2e6795c9cd02cc300041a718f73a5610bbefe90..03ebc09af622a323a70e9a0d456f462e175a3e97 100644 --- a/src/utils/khost/khost_params.c +++ b/src/utils/khost/khost_params.c @@ -44,7 +44,7 @@ static const style_t DEFAULT_STYLE_HOST = { .original_ttl = false, .empty_ttl = false, .human_ttl = false, - .human_tmstamp = true, + .human_timestamp = true, .generic = false, .ascii_to_idn = name_to_idn }, diff --git a/src/utils/knotc/process.h b/src/utils/knotc/process.h index 2a23a4e02dde7ca2e0b478833783770d48c6bc8e..b29e70f4ae53ca4cd023911be08f08563e3abb93 100644 --- a/src/utils/knotc/process.h +++ b/src/utils/knotc/process.h @@ -43,7 +43,7 @@ typedef struct { int set_config(const cmd_desc_t *desc, params_t *params); /*! - * Estabilishes a control interface if necessary. + * Establishes a control interface if necessary. * * \param[in] ctl Control context. * \param[in] socket Control socket path. diff --git a/src/utils/knsupdate/knsupdate_params.c b/src/utils/knsupdate/knsupdate_params.c index 0789bf26674dfd3e5ac947da157e750a38848986..23f1916f170e74c0eacc4ce913271936bce78537 100644 --- a/src/utils/knsupdate/knsupdate_params.c +++ b/src/utils/knsupdate/knsupdate_params.c @@ -45,7 +45,7 @@ static const style_t DEFAULT_STYLE_NSUPDATE = { .original_ttl = false, .empty_ttl = false, .human_ttl = false, - .human_tmstamp = true, + .human_timestamp = true, .generic = false, .ascii_to_idn = NULL }, diff --git a/src/utils/kzonesign/main.c b/src/utils/kzonesign/main.c index 8921379c9ec0916d96efc0b774d16da488bf7d6a..9c3666a4007ea48786a267478d097383023f34c2 100644 --- a/src/utils/kzonesign/main.c +++ b/src/utils/kzonesign/main.c @@ -143,7 +143,7 @@ static int zonesign(sign_params_t *params) printf("Next NSEC3 re-salt: %"KNOT_TIME_PRINTF"\n", next_sign.next_nsec3resalt); } if (next_sign.plan_ds_check) { - printf("KSK submittion to parent zone needed\n"); + printf("KSK submission to parent zone needed\n"); } } diff --git a/tests-extra/tests/axfr/failover/test.py b/tests-extra/tests/axfr/failover/test.py index 6ad006dfbdeefdd0eff9400ed5923caf26de98bc..347128b8d418d5f7d95ea6b570fce0001d682a59 100644 --- a/tests-extra/tests/axfr/failover/test.py +++ b/tests-extra/tests/axfr/failover/test.py @@ -37,7 +37,7 @@ slave.zones[zone.name].journal_content = "all" t.start() -# zone boostrap +# zone bootstrap for server in [master1, master2, slave]: server.zone_wait(zone) diff --git a/tests-extra/tests/axfr/persistence/test.py b/tests-extra/tests/axfr/persistence/test.py index 871925a6cc46449944144c374cb469722bac9601..307aa166b64e6836a22a48c023bfba8b5f3fb753 100644 --- a/tests-extra/tests/axfr/persistence/test.py +++ b/tests-extra/tests/axfr/persistence/test.py @@ -19,7 +19,7 @@ t.link([zone], master, slave) t.start() -# verify zone boostrap +# verify zone bootstrap for server in [master, slave]: server.zone_wait(zone) @@ -33,7 +33,7 @@ for server in [master, slave]: master.stop() slave.stop() -# verify zone persistence after boostrap +# verify zone persistence after bootstrap slave.start() slave.zone_wait(zone, serial=10, equal=True, greater=False) diff --git a/tests-extra/tests/basic/delegation_tc/test.py b/tests-extra/tests/basic/delegation_tc/test.py index 4b4e7dc23e8fbce230822d0b1b43d7dd93b00a1e..1a50842544067371de89f9848010bc18bd3044c5 100644 --- a/tests-extra/tests/basic/delegation_tc/test.py +++ b/tests-extra/tests/basic/delegation_tc/test.py @@ -36,7 +36,7 @@ class DelegationTest: def __enter__(self): return self - def __exit__(self, exc_type, exc_vaue, traceback): + def __exit__(self, exc_type, exc_value, traceback): return False # Authoritative answer with glue of foreign name server diff --git a/tests-extra/tests/catalog/basic/test.py b/tests-extra/tests/catalog/basic/test.py index 74f1760ffd5227ef10c6d7db8c070c26adb5c1ac..49e43254d1e65520c249e4f57bd335a9727f4f0b 100644 --- a/tests-extra/tests/catalog/basic/test.py +++ b/tests-extra/tests/catalog/basic/test.py @@ -58,7 +58,7 @@ resp.check(rcode="REFUSED") resp = master.dig("not-cataloged3.", "SOA") resp.check(rcode="REFUSED") -# Udating a cataloged zone +# Updating a cataloged zone subprocess.run(["sed", "-i", "s/10001/10002/;$s/$/\\nxyz A 1.2.3.4/", master.dir + "/master/cataloged1.zone"]) master.ctl("zone-reload cataloged1.") t.sleep(4) @@ -80,7 +80,7 @@ resp.check(rcode="NOERROR") resp.check_count(2, "DNSKEY") resp.check_count(1, "RRSIG") -# Check that addition didn't delete prvious +# Check that addition didn't delete previous resp = master.dig("cataloged1.", "SOA") resp.check(rcode="NOERROR") resp = slave.dig("cataloged1.", "SOA", dnssec=True) diff --git a/tests-extra/tests/catalog/generate/test.py b/tests-extra/tests/catalog/generate/test.py index 6668579f6973cf147c16867bb74868efb050a598..093cb2ab30fc0dbac17af0777188c63cf5b4fe5d 100644 --- a/tests-extra/tests/catalog/generate/test.py +++ b/tests-extra/tests/catalog/generate/test.py @@ -41,7 +41,7 @@ slave.dnssec(catz[0]).single_type_signing = True t.start() -# testcatse 1: initial catalog zone with 1 member +# testcase 1: initial catalog zone with 1 member slave.zones_wait(zone) # testcase 2: adding member zones online/offline diff --git a/tests-extra/tests/ddns/prereq/test.py b/tests-extra/tests/ddns/prereq/test.py index 42ef79f1ecb39f622d56a75692918f383c099c93..43c47811549569724cc1b81734bb40315ee81683 100644 --- a/tests-extra/tests/ddns/prereq/test.py +++ b/tests-extra/tests/ddns/prereq/test.py @@ -33,7 +33,7 @@ resp.check("text") # NAME not in zone update = srv.update(zone) -update.prereq_yx("notexisting.ddns.") +update.prereq_yx("nonexistent.ddns.") update.add("3.ddns.", 1, "TXT", "text") update.send("NXDOMAIN") resp = srv.dig("3.ddns.", "TXT") @@ -41,7 +41,7 @@ resp.check(rcode="NXDOMAIN") # NAME out of zone update = srv.update(zone) -update.prereq_yx("notexisting.") +update.prereq_yx("nonexistent.") update.add("4.ddns.", 1, "TXT", "text") update.send("NOTZONE") resp = srv.dig("4.ddns.", "TXT") @@ -51,7 +51,7 @@ resp.check(rcode="NXDOMAIN") # =============== # OK update = srv.update(zone) -update.prereq_nx("notexisting.ddns.") +update.prereq_nx("nonexistent.ddns.") update.add("4.ddns.", 1, "TXT", "text") update.send("NOERROR") resp = srv.dig("4.ddns.", "TXT") @@ -67,7 +67,7 @@ resp.check(rcode="NXDOMAIN") # NAME out of zone update = srv.update(zone) -update.prereq_nx("notexisting.") +update.prereq_nx("nonexistent.") update.add("6.ddns.", 1, "TXT", "text") update.send("NOTZONE") resp = srv.dig("6.ddns.", "TXT") @@ -77,7 +77,7 @@ resp.check(rcode="NXDOMAIN") # ============== # OK - neither NAME nor TYPE in zone update = srv.update(zone) -update.prereq_nx("notexisting.ddns.", "TYPE65535") +update.prereq_nx("nonexistent.ddns.", "TYPE65535") update.add("7.ddns.", 1, "TXT", "text") update.send("NOERROR") resp = srv.dig("7.ddns.", "TXT") @@ -101,7 +101,7 @@ resp.check(rcode="NXDOMAIN") # NAME out of zone update = srv.update(zone) -update.prereq_nx("notexisting.", "TYPE65535") +update.prereq_nx("nonexistent.", "TYPE65535") update.add("10.ddns.", 1, "TXT", "text") update.send("NOTZONE") resp = srv.dig("10.ddns.", "TXT") @@ -135,7 +135,7 @@ resp.check(rcode="NXDOMAIN") # ============== # Neither NAME nor TYPE in zone update = srv.update(zone) -update.prereq_yx("notexisting.ddns.", "TYPE65535") +update.prereq_yx("nonexistent.ddns.", "TYPE65535") update.add("13.ddns.", 1, "TXT", "text") update.send("NXRRSET") resp = srv.dig("13.ddns.", "TXT") @@ -175,7 +175,7 @@ resp.check(rcode="NXDOMAIN") # NAME out of zone update = srv.update(zone) -update.prereq_yx("notexisting.", "TYPE65535") +update.prereq_yx("nonexistent.", "TYPE65535") update.add("18.ddns.", 1, "TXT", "text") update.send("NOTZONE") resp = srv.dig("18.ddns.", "TXT") diff --git a/tests-extra/tests/dnssec/dnskey_timestamps/test.py b/tests-extra/tests/dnssec/dnskey_timestamps/test.py index 132acef20ad110d6473a439db92f14f0d538cad2..173e25bae37821105c177d2ea663ce6ab7640791 100644 --- a/tests-extra/tests/dnssec/dnskey_timestamps/test.py +++ b/tests-extra/tests/dnssec/dnskey_timestamps/test.py @@ -1,7 +1,7 @@ #!/usr/bin/env python3 """ -Check if DNSKEY lifetime timestamps are proccessed correctly by Knot. +Check if DNSKEY lifetime timestamps are processed correctly by Knot. """ import collections diff --git a/tests-extra/tests/dnssec/ds_push/test.py b/tests-extra/tests/dnssec/ds_push/test.py index f09c686ef86a17ac914784e851141959a9e630d4..b68d74fbc9621679ad6c91e340b24f71c1b3bcf0 100644 --- a/tests-extra/tests/dnssec/ds_push/test.py +++ b/tests-extra/tests/dnssec/ds_push/test.py @@ -22,7 +22,7 @@ def pregenerate_key(server, zone, alg): def __init__(self, name): self.name = name - server.gen_key(a_class_with_name("notexisting.zone."), ksk=True, alg=alg, + server.gen_key(a_class_with_name("nonexistent.zone."), ksk=True, alg=alg, addtopolicy=zone[0].name) # check zone if keys are present and used for signing diff --git a/tests-extra/tests/dnssec/key_rollovers/test.py b/tests-extra/tests/dnssec/key_rollovers/test.py index 12f891f042e53b9120e34a89a4aa17cf0652f558..ad0555c07484b48893191bc4c024c1d5e2abc897 100644 --- a/tests-extra/tests/dnssec/key_rollovers/test.py +++ b/tests-extra/tests/dnssec/key_rollovers/test.py @@ -47,7 +47,7 @@ def pregenerate_key(server, zone, alg): def __init__(self, name): self.name = name - server.gen_key(a_class_with_name("notexisting.zone."), ksk=True, alg=alg, + server.gen_key(a_class_with_name("nonexistent.zone."), ksk=True, alg=alg, addtopolicy=zone[0].name) # check zone if keys are present and used for signing @@ -224,7 +224,7 @@ def watch_ksk_rollover(t, server, zone, slave, before_keys, after_keys, total_ke expect_zone_rrsigs = (2 if before_keys == 1 and after_keys > 1 else 1) # there is an exception for CSK->KZSK rollover that we have double signatures for the zone. Sorry, we don't care... check_zone(server, zone, slave, total_keys, 2, cdnskeys, expect_zone_rrsigs, msg) - t.sleep(server.dnssec(zone).propagation_delay + 1) # check that Knot does wait for the submittion to succeed + t.sleep(server.dnssec(zone).propagation_delay + 1) # check that Knot does wait for the submission to succeed submission_cb() msg = desc + ": both still active" wait_after_submission(t, server) diff --git a/tests-extra/tests/dnssec/ksk_rollover/test.py b/tests-extra/tests/dnssec/ksk_rollover/test.py index 984ec4fb8b5448df9dcedcc010d1b661b6e0a7a4..73a71246171aeacc8dc6170f27672e4aea5fbc9d 100644 --- a/tests-extra/tests/dnssec/ksk_rollover/test.py +++ b/tests-extra/tests/dnssec/ksk_rollover/test.py @@ -3,7 +3,7 @@ """ More precise check of simple KSK rollover. -The key_rollvoers test is too over-complicated already, unable to add test cases. +The key_rollovers test is too over-complicated already, unable to add test cases. """ import collections diff --git a/tests-extra/tests/dnssec/nsec3_revert/test.py b/tests-extra/tests/dnssec/nsec3_revert/test.py index ab30ae39b37a6baa3ebc429c45e5711da7639c0c..02d702ebb7ccb19c9278b0060245c2a681c1c1d6 100644 --- a/tests-extra/tests/dnssec/nsec3_revert/test.py +++ b/tests-extra/tests/dnssec/nsec3_revert/test.py @@ -1,6 +1,6 @@ #!/usr/bin/env python3 -'''Test for unsiccessful creation of NSEC3 tree''' +'''Test for unsuccessful creation of NSEC3 tree''' from dnstest.test import Test diff --git a/tests-extra/tests/dnssec/verify_incoming/test.py b/tests-extra/tests/dnssec/verify_incoming/test.py index 0ac771adda826fc81de15aa2edca0948c083d067..579a1b7c454df7521f244afdfc473aecbbafb5d6 100644 --- a/tests-extra/tests/dnssec/verify_incoming/test.py +++ b/tests-extra/tests/dnssec/verify_incoming/test.py @@ -1,6 +1,6 @@ #!/usr/bin/env python3 -'''Check that Knot validates RRSIGs incomming thru IXFR''' +'''Check that Knot validates RRSIGs incoming through IXFR''' from dnstest.utils import * from dnstest.test import Test diff --git a/tests-extra/tests/dnssec/zsk_rollover/test.py b/tests-extra/tests/dnssec/zsk_rollover/test.py index 93191a73bc1ef8b5756808e3d23955ca0e2ab4fc..a15480a08ed9ef340ba96bddf19103e23db2bff4 100644 --- a/tests-extra/tests/dnssec/zsk_rollover/test.py +++ b/tests-extra/tests/dnssec/zsk_rollover/test.py @@ -1,7 +1,7 @@ #!/usr/bin/env python3 """ -Check of automatic ZSK rollvoer with changing zone TTLs. +Check of automatic ZSK rollover with changing zone TTLs. """ from dnstest.utils import * diff --git a/tests-extra/tests/edns/ede/test.py b/tests-extra/tests/edns/ede/test.py index 559edef37a7d9a0dfa11eb41bbc3e5130c9f59ea..c8b560093e14a4e2722943c6ec2b796cecd25cfc 100644 --- a/tests-extra/tests/edns/ede/test.py +++ b/tests-extra/tests/edns/ede/test.py @@ -10,7 +10,7 @@ import dns.edns KNOT_EDNS_OPTION_EDE = 15 -# this will work with future dnsython... +# this will work with future dnspython... #class EdeOption(dns.edns.Option): # def __init__(self, rcode): # super().__init__(KNOT_EDNS_OPTION_EDE) diff --git a/tests-extra/tests/edns/payload_server/test.py b/tests-extra/tests/edns/payload_server/test.py index 3fdcca83f959aa297c5f61d1840c45ccbecc68cc..72d45b2f75218b32d676f576dd24fc68d2266135 100644 --- a/tests-extra/tests/edns/payload_server/test.py +++ b/tests-extra/tests/edns/payload_server/test.py @@ -34,12 +34,12 @@ resp.check(flags="TC") # Set IP family specific limit. server4.udp_max_payload_ipv4 = 1220 -server4.udp_max_payload_ipv6 = 1221 # Shoud not affect IPv4 -server4.udp_max_payload = 1221 # Shoud not override IPv4 specific +server4.udp_max_payload_ipv6 = 1221 # Should not affect IPv4 +server4.udp_max_payload = 1221 # Should not override IPv4 specific server6.udp_max_payload_ipv6 = 1220 -server6.udp_max_payload_ipv4 = 1221 # Shoul not affect IPv6 -server6.udp_max_payload = 1221 # Shoud not override IPv6 specific +server6.udp_max_payload_ipv4 = 1221 # Should not affect IPv6 +server6.udp_max_payload = 1221 # Should not override IPv6 specific server4.gen_confile() server4.reload() diff --git a/tests-extra/tests/ixfr/from_differences/test.py b/tests-extra/tests/ixfr/from_differences/test.py index 41b4a64a6a924a149f1069283d7a3d6dddbe3793..f0a47f3c4a26e67ab283f19dc627ad49f9f2de73 100644 --- a/tests-extra/tests/ixfr/from_differences/test.py +++ b/tests-extra/tests/ixfr/from_differences/test.py @@ -98,12 +98,12 @@ class IxfrTopology(): check_log("====================================") -patern = re.compile("^([0-9][0-9]_)") +pattern = re.compile("^([0-9][0-9]_)") t = dnstest.test.Test() for dirname in sorted(os.listdir(Context().test_dir)): - if patern.match(dirname): + if pattern.match(dirname): mod_name = Context().module_name + "_" + dirname mod_path = os.path.join(Context().module_path, dirname, "step.py") spec = importlib.util.spec_from_file_location(mod_name, mod_path) diff --git a/tests-extra/tests/modules/onlinesign_rollovers/test.py b/tests-extra/tests/modules/onlinesign_rollovers/test.py index b675aef8ba75e24a329e1602848b52b1af4bd9b9..4af66586631cd920d72570f0cfc8681becf2c5d6 100644 --- a/tests-extra/tests/modules/onlinesign_rollovers/test.py +++ b/tests-extra/tests/modules/onlinesign_rollovers/test.py @@ -23,7 +23,7 @@ def pregenerate_key(server, zone, alg): def __init__(self, name): self.name = name - server.gen_key(a_class_with_name("notexisting.zone."), ksk=True, alg=alg, + server.gen_key(a_class_with_name("nonexistent.zone."), ksk=True, alg=alg, addtopolicy="blahblah") # check zone if keys are present and used for signing diff --git a/tests-extra/tests/notify/ctl/test.py b/tests-extra/tests/notify/ctl/test.py index d81ef2229ca73e8a4651a89fc0e52db6a522e6a8..d995d9525cbeafe2f32fe52516da72d426c8f009 100644 --- a/tests-extra/tests/notify/ctl/test.py +++ b/tests-extra/tests/notify/ctl/test.py @@ -25,7 +25,7 @@ master.reload() master.zone_wait(zone) -slave.start() # slave starts with older version of zone and doesn't attempt refersh since it's in timers +slave.start() # slave starts with older version of zone and doesn't attempt refresh since it's in timers slave.zone_wait(zone) diff --git a/tests-extra/tests/zone/difse2all/test.py b/tests-extra/tests/zone/difse2all/test.py index 39366780054f800086785fe70a5ed637c876ed3c..5d3bc8fe9eba622ad93a5d2ee2b725461ee445bf 100644 --- a/tests-extra/tests/zone/difse2all/test.py +++ b/tests-extra/tests/zone/difse2all/test.py @@ -10,7 +10,7 @@ import random t = Test() -# radnomized different test scenarios +# randomized different test scenarios purge_beforehand = random.choice([True, False]) cold_reload = random.choice([True, False]) zone_reload_afterwards = random.choice([True, False]) diff --git a/tests-extra/tests/zone/notexists/test.py b/tests-extra/tests/zone/notexists/test.py index c6da75b4f344746afeb8ca326628e835a1296e1d..1434a3ab6004a3201bbc1dde5d407b42846b41de 100644 --- a/tests-extra/tests/zone/notexists/test.py +++ b/tests-extra/tests/zone/notexists/test.py @@ -8,14 +8,14 @@ t = Test() master = t.server("knot") -zones = t.zone("notexist.", exists=False) + t.zone("example.com.") +zones = t.zone("nonexistent.", exists=False) + t.zone("example.com.") t.link(zones, master) t.start() # Check if the server is answering and zone _isn't_ loaded -resp = master.dig("notexist.", "SOA", udp=True) +resp = master.dig("nonexistent.", "SOA", udp=True) resp.check(rcode="SERVFAIL") # Unloadable zone, but in the zone database # Check if the server is answering and zone is unknown diff --git a/tests-extra/tests/zone/timers/test.py b/tests-extra/tests/zone/timers/test.py index c5c712342675af1bacebf2902e3537e8b85d3779..8b312e80c525343b857d7b9cb1200146c6ef612f 100644 --- a/tests-extra/tests/zone/timers/test.py +++ b/tests-extra/tests/zone/timers/test.py @@ -39,11 +39,11 @@ def expire_tests(t, zone, master, slave): t.sleep(EXPIRE_SLEEP) test_expired(zone, slave) - # Reload shoudn't affect. + # Reload shouldn't affect. slave.reload() test_expired(zone, slave) - # Restart shoudn't affect. + # Restart shouldn't affect. restart_server(slave) test_expired(zone, slave) @@ -65,11 +65,11 @@ def expire_tests(t, zone, master, slave): slave.start() test_expired(zone, slave) - # Reload shoudn't affect. + # Reload shouldn't affect. slave.reload() test_expired(zone, slave) - # Restart shoudn't affect. + # Restart shouldn't affect. restart_server(slave) test_expired(zone, slave) @@ -87,7 +87,7 @@ def refresh_tests(t, zone, master, slave): master.zones[zone.name].zfile.update_soa(serial=3, refresh=1, retry=1, expire=15) master.reload() - # Restart and reload shoudn't cause refresh + # Restart and reload shouldn't cause refresh restart_server(slave) slave.reload() slave.ctl("zone-reload %s" % zone.name) diff --git a/tests-extra/tools/dnstest/server.py b/tests-extra/tools/dnstest/server.py index 102f26364ca9ba0c5579179ec09a54d2f8967231..90c0dda2edea6fa4311dfa934fb160436622ff56 100644 --- a/tests-extra/tools/dnstest/server.py +++ b/tests-extra/tools/dnstest/server.py @@ -280,7 +280,7 @@ class Server(object): self.inquirer.start(self) def start(self, clean=False): - '''Start the server with all bindings successfull''' + '''Start the server with all bindings successful''' errors = 0 if clean else self.binding_errors for attempt in range(Server.START_MAX_ATTEMPTS): @@ -565,7 +565,7 @@ class Server(object): query.want_dnssec() dig_flags += " +dnssec +bufsize=%i" % query.payload - # Store function arguments for possible comparation. + # Store function arguments for possible comparison. args = dict() params = inspect.getargvalues(inspect.currentframe()) for param in params.args: diff --git a/tests-extra/tools/dnstest/zonefile.py b/tests-extra/tools/dnstest/zonefile.py index dc660ab1ff65184c1d2579224473937bca8d8186..76586ce1e8034b5d9cc58530e3bc79aef8ee6986 100644 --- a/tests-extra/tools/dnstest/zonefile.py +++ b/tests-extra/tools/dnstest/zonefile.py @@ -54,7 +54,7 @@ class ZoneFile(object): '''Make a copy of an existing zone file. If no file name is specified, the file name is constructed from the zone name (zname.zone). If version is specified, file_name.version is used. - The storage is a directory containg the zone file.''' + The storage is a directory containing the zone file.''' if not file_name: file_name = self.name + "zone" diff --git a/tests/contrib/test_time.c b/tests/contrib/test_time.c index dd019cae39dbba45a3bc601de3435b425dab99c6..84518f2db34ce73b24b20bbe975125a9b3fbb25b 100644 --- a/tests/contrib/test_time.c +++ b/tests/contrib/test_time.c @@ -84,10 +84,10 @@ static void test_knot_time(void) ok(ret == 0, "compare two infinities"); ret = knot_time_cmp(a, inf); - ok(ret == -1, "compare time and infty"); + ok(ret == -1, "compare time and infinity"); ret = knot_time_cmp(inf, a); - ok(ret == 1, "compare infty and time"); + ok(ret == 1, "compare infinity and time"); c = knot_time_min(a, a); ok(c == a, "take same time"); @@ -99,7 +99,7 @@ static void test_knot_time(void) ok(c == a, "take second smaller"); c = knot_time_min(inf, inf); - ok(c == inf, "take same infty"); + ok(c == inf, "take same infinity"); c = knot_time_min(a, inf); ok(c == a, "take first finite"); @@ -114,13 +114,13 @@ static void test_knot_time(void) ok(d == -1, "negative diff"); d = knot_time_diff(inf, inf); - ok(d == KNOT_TIMEDIFF_MAX, "positive double infty diff"); + ok(d == KNOT_TIMEDIFF_MAX, "positive double infinity diff"); d = knot_time_diff(inf, a); - ok(d == KNOT_TIMEDIFF_MAX, "positive infty diff"); + ok(d == KNOT_TIMEDIFF_MAX, "positive infinity diff"); d = knot_time_diff(a, inf); - ok(d == KNOT_TIMEDIFF_MIN, "negative infty diff"); + ok(d == KNOT_TIMEDIFF_MIN, "negative infinity diff"); } static void test_time_parse_expect(int ret, knot_time_t res, diff --git a/tests/knot/semantic_check_data/no_error_delegaton_bitmap.signed b/tests/knot/semantic_check_data/no_error_delegation_bitmap.signed similarity index 100% rename from tests/knot/semantic_check_data/no_error_delegaton_bitmap.signed rename to tests/knot/semantic_check_data/no_error_delegation_bitmap.signed diff --git a/tests/knot/test_changeset.c b/tests/knot/test_changeset.c index 9ada412e394efe38779ca0e1290d7ec56577048e..6775b76bd415562b1ac40f166e2b5d10fca63231 100644 --- a/tests/knot/test_changeset.c +++ b/tests/knot/test_changeset.c @@ -41,7 +41,7 @@ int main(int argc, char *argv[]) } ok(changeset_empty(ch), "changeset: empty"); ch->soa_to = (knot_rrset_t *)0xdeadbeef; - ok(!changeset_empty(ch), "changseset: empty SOA"); + ok(!changeset_empty(ch), "changeset: empty SOA"); ch->soa_to = NULL; ok(changeset_size(ch) == 0, "changeset: empty size"); @@ -110,7 +110,7 @@ int main(int argc, char *argv[]) // Test all traversal - just count. ret = changeset_iter_all(&it, ch); - is_int(KNOT_EOK, ret, "changest: create iter all"); + is_int(KNOT_EOK, ret, "changeset: create iter all"); size_t size = 0; iter = changeset_iter_next(&it); while (!knot_rrset_empty(&iter)) { diff --git a/tests/knot/test_confdb.c b/tests/knot/test_confdb.c index 2c63b88330b3f5409ab5bc3c485237db3e07fa74..e149f8da9dc9af71c26542da77ea35e6aaf0ac8c 100644 --- a/tests/knot/test_confdb.c +++ b/tests/knot/test_confdb.c @@ -420,7 +420,7 @@ static void test_conf_db_iter(conf_t *conf, knot_db_txn_t *txn) while (ret == KNOT_EOK) { const uint8_t *id; size_t id_len; - id = NULL, id_len = 0; // prevents Wuinitialized + id = NULL, id_len = 0; // prevents Wuninitialized ret = conf_db_iter_id(conf, &iter, &id, &id_len); is_int(KNOT_EOK, ret, "Get iteration id"); ok(id_len == strlen(names[count]), "Compare iteration id length"); diff --git a/tests/knot/test_confio.c b/tests/knot/test_confio.c index eb459bcc530843d2d86fb2dcb12476ed1a32724b..73d15d46fbc0d696a6f720600641c5be052cd3fd 100644 --- a/tests/knot/test_confio.c +++ b/tests/knot/test_confio.c @@ -362,7 +362,7 @@ static void test_conf_io_set(void) KNOT_EINVAL, "set NULL key0"); ok(conf_io_set("", NULL, NULL, NULL) == KNOT_YP_EINVAL_ITEM, "set empty key0"); - ok(conf_io_set("uknown", NULL, NULL, NULL) == + ok(conf_io_set("unknown", NULL, NULL, NULL) == KNOT_YP_EINVAL_ITEM, "set unknown key0"); ok(conf_io_set("server", "unknown", NULL, NULL) == KNOT_YP_EINVAL_ITEM, "set unknown key1"); @@ -470,7 +470,7 @@ static void test_conf_io_unset(void) // ERR. ok(conf_io_unset("", NULL, NULL, NULL) == KNOT_YP_EINVAL_ITEM, "unset unknown key0"); - ok(conf_io_unset("uknown", NULL, NULL, NULL) == + ok(conf_io_unset("unknown", NULL, NULL, NULL) == KNOT_YP_EINVAL_ITEM, "unset unknown key0"); ok(conf_io_unset("server", "unknown", NULL, NULL) == KNOT_YP_EINVAL_ITEM, "unset unknown key1"); @@ -668,7 +668,7 @@ static void test_conf_io_get(void) // ERR. ok(conf_io_get("", NULL, NULL, true, &io) == KNOT_YP_EINVAL_ITEM, "get empty key0"); - ok(conf_io_get("uknown", NULL, NULL, true, &io) == + ok(conf_io_get("unknown", NULL, NULL, true, &io) == KNOT_YP_EINVAL_ITEM, "get unknown key0"); ok(conf_io_get("server", "unknown", NULL, true, &io) == KNOT_YP_EINVAL_ITEM, "get unknown key1"); @@ -789,7 +789,7 @@ static void test_conf_io_diff(void) // ERR. ok(conf_io_diff("", NULL, NULL, &io) == KNOT_YP_EINVAL_ITEM, "diff empty key0"); - ok(conf_io_diff("uknown", NULL, NULL, &io) == + ok(conf_io_diff("unknown", NULL, NULL, &io) == KNOT_YP_EINVAL_ITEM, "diff unknown key0"); ok(conf_io_diff("server", "unknown", NULL, &io) == KNOT_YP_EINVAL_ITEM, "diff unknown key1"); @@ -880,7 +880,7 @@ static void test_conf_io_list(void) // ERR. ok(conf_io_list("", &io) == KNOT_YP_EINVAL_ITEM, "list empty key0"); - ok(conf_io_list("uknown", &io) == + ok(conf_io_list("unknown", &io) == KNOT_YP_EINVAL_ITEM, "list unknown key0"); ok(conf_io_list("include", &io) == KNOT_ENOTSUP, "list non-group item"); diff --git a/tests/knot/test_journal.c b/tests/knot/test_journal.c index ca79b0a794f92657b59b7c08cb17033029382f45..afc824422aa4e0f868cef6e215e7b980f63175a8 100644 --- a/tests/knot/test_journal.c +++ b/tests/knot/test_journal.c @@ -385,7 +385,7 @@ static void test_store_load(const knot_dname_t *apex) ret = load_j_list(&jj, false, serial, &read, &l); is_int(KNOT_EOK, ret, "journal: load after store after flush after overfill (%s)", knot_strerror(ret)); is_int(1, list_size(&l), "journal: single changeset in list"); - ok(changesets_eq(&ch, HEAD(l)), "journal: changeset unmalformed after overfill"); + ok(changesets_eq(&ch, HEAD(l)), "journal: changeset not malformed after overfill"); changesets_free(&l); journal_read_end(read); @@ -399,7 +399,7 @@ static void test_store_load(const knot_dname_t *apex) is_int(KNOT_EOK, ret, "journal check (%s)", knot_strerror(ret)); ret = load_j_list(&jj, false, 2, &read, &l); is_int(KNOT_EOK, ret, "journal: read after discontinuity (%s)", knot_strerror(ret)); - is_int(1, list_size(&l), "journal: dicontinuity caused journal to drop"); + is_int(1, list_size(&l), "journal: discontinuity caused journal to drop"); changesets_free(&l); journal_read_end(read); @@ -430,7 +430,7 @@ static void test_store_load(const knot_dname_t *apex) ret = load_j_list(&jj, false, 4294967294, &read, &l); is_int(KNOT_EOK, ret, "journal: read after cycle (%s)", knot_strerror(ret)); ok(3 >= list_size(&l), "journal: cycle caused journal to partly drop"); - ok(changesets_eq(&ch, HEAD(l)), "journal: changeset unmalformed after cycle"); + ok(changesets_eq(&ch, HEAD(l)), "journal: changeset not malformed after cycle"); changesets_free(&l); journal_read_end(read); changeset_clear(&ch); @@ -450,8 +450,8 @@ static void test_store_load(const knot_dname_t *apex) ret = load_j_list(&jj, true, 0, &read, &l); is_int(KNOT_EOK, ret, "journal: load zone-in-journal (%s)", knot_strerror(ret)); is_int(2, list_size(&l), "journal: read two changesets from zone-in-journal"); - ok(changesets_eq(&e_ch, HEAD(l)), "journal: zone-in-journal unmalformed"); - ok(changesets_eq(&r_ch, TAIL(l)), "journal: after zone-in-journal unmalformed"); + ok(changesets_eq(&e_ch, HEAD(l)), "journal: zone-in-journal not malformed"); + ok(changesets_eq(&r_ch, TAIL(l)), "journal: after zone-in-journal not malformed"); changesets_free(&l); journal_read_end(read); changeset_clear(&e_ch); @@ -804,7 +804,7 @@ static void test_stress_base(const knot_dname_t *apex, uint32_t serial = 0; int ret = knot_lmdb_reconfigure(&jdb, test_dir_name, file_size, journal_env_flags(JOURNAL_MODE_ASYNC, false)); - is_int(KNOT_EOK, ret, "journal: recofigure to mapsize %zu (%s)", file_size, knot_strerror(ret)); + is_int(KNOT_EOK, ret, "journal: reconfigure to mapsize %zu (%s)", file_size, knot_strerror(ret)); set_conf(1000, file_size / 2, apex); diff --git a/tests/knot/test_semantic_check.in b/tests/knot/test_semantic_check.in index 8635acbd1ad4d998132fc72d727bbce4d29b51c4..3cc054238dbe185dfd34f5b4dfe736e951794c47 100644 --- a/tests/knot/test_semantic_check.in +++ b/tests/knot/test_semantic_check.in @@ -135,7 +135,7 @@ expect_error "cdnskey.delete.invalid.cds" 0 1 "$CDNSKEY_DELETE" expect_error "cdnskey.delete.invalid.cdnskey" 0 1 "$CDNSKEY_DELETE" test_correct "rrsig_ttl.signed" -test_correct "no_error_delegaton_bitmap.signed" +test_correct "no_error_delegation_bitmap.signed" test_correct "no_error_nsec3_delegation.signed" test_correct "no_error_nsec3_optout.signed" test_correct "glue_wildcard.valid" diff --git a/tests/libknot/test_cookies.c b/tests/libknot/test_cookies.c index 53e4106d815de46c8b687258a8646b2c6e8157b8..82ba50228ea81ac09ace9a49c9033f8450d7e061 100644 --- a/tests/libknot/test_cookies.c +++ b/tests/libknot/test_cookies.c @@ -140,8 +140,8 @@ int main(int argc, char *argv[]) cc = client_generate(&s4_sa, c_secret2, "IPv4", KNOT_EOK, "\xFC\x93\xFC\x62\x80\x7D\xDB\x86"); - char *sc_reserverd = "\x01\xAB\xCD\xEF\x5C\xF7\x8F\x71\xA3\x14\x22\x7B\x66\x79\xEB\xF5"; - memcpy(sc.data, sc_reserverd, strlen(sc_reserverd)); + char *sc_reserved = "\x01\xAB\xCD\xEF\x5C\xF7\x8F\x71\xA3\x14\x22\x7B\x66\x79\xEB\xF5"; + memcpy(sc.data, sc_reserved, strlen(sc_reserved)); server_check(&c4_sa2, s_secret1, &sc, &cc, 1559727985, "IPv4", KNOT_EOK); // Version check diff --git a/tests/libknot/test_probe.c b/tests/libknot/test_probe.c index b8afaf52ffc8c610d11d7c1cbcee1f54801a5c86..37437f43644de1dc2fa1cec04ce5b14dd8faf3af 100644 --- a/tests/libknot/test_probe.c +++ b/tests/libknot/test_probe.c @@ -81,7 +81,7 @@ int main(int argc, char *argv[]) ok(ret == 1, "probe: consume datagram"); ret = memcmp(&data_in, &data_out, offsetof(knot_probe_data_t, query.qname)); - ok(ret == 0, "probe: data comparsion"); + ok(ret == 0, "probe: data comparison"); ret = knot_dname_cmp(data_in.query.qname, data_out.query.qname); ok(ret == 0, "probe: qname comparison"); diff --git a/tests/libknot/test_xdp_tcp.c b/tests/libknot/test_xdp_tcp.c index e066132c948601a51c52b1818f1d72c4e9b9aa48..7590726b67d35c73237c9ce54e59ad2606fba273 100644 --- a/tests/libknot/test_xdp_tcp.c +++ b/tests/libknot/test_xdp_tcp.c @@ -71,7 +71,7 @@ static void tcp_cleanup(knot_tcp_table_t *tcp_table, uint32_t timeout, } /*! - * \brief Find connection related to incomming message. + * \brief Find connection related to incoming message. */ static knot_tcp_conn_t *tcp_table_find(knot_tcp_table_t *table, knot_xdp_msg_t *msg_recv) { diff --git a/tests/libzscanner/processing.c b/tests/libzscanner/processing.c index b30b82fa95a1db8dfd683462932c2609d303391b..23737c8380df61bc6afa96e334bb0573688f5a47 100644 --- a/tests/libzscanner/processing.c +++ b/tests/libzscanner/processing.c @@ -153,10 +153,10 @@ int test_date_to_timestamp(void) gmtime_r(&ref_timestamp, &result)); // Get testing timestamp. - test_timestamp = 0U; // prevents Wunitialized + test_timestamp = 0U; // prevents Wuninitialized date_to_timestamp(buffer, &test_timestamp); - // Some continuous loging. + // Some continuous logging. if (ref_timestamp % 10000000 == 0) { val1 = ref_timestamp; printf("%s = %"PRIu64"\n", buffer, val1);