From 990b7c8303ea7df8a0028716bda70cd440da485e Mon Sep 17 00:00:00 2001
From: Jan Vcelak <jan.vcelak@nic.cz>
Date: Wed, 16 Oct 2013 16:22:57 +0200
Subject: [PATCH] TODO reply
---
src/libknot/dnssec/zone-sign.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/libknot/dnssec/zone-sign.c b/src/libknot/dnssec/zone-sign.c
index b7dae0c280..bfb86d75a4 100644
--- a/src/libknot/dnssec/zone-sign.c
+++ b/src/libknot/dnssec/zone-sign.c
@@ -385,6 +385,8 @@ static int resign_rrset(const knot_rrset_t *covered,
// TODO this function creates some signatures twice (for checking)
// maybe merge the two functions into one
+ // jvcelak: Not really, maybe for RSA. The digest is computed twice,
+ // but the verification process can differ from signature computation.
int result = remove_expired_rrsigs(covered, covered->rrsigs, zone_keys,
policy, changeset, expires_at);
if (result != KNOT_EOK) {
@@ -1217,4 +1219,3 @@ bool knot_zone_sign_rr_should_be_signed(const knot_node_t *node,
return true;
}
-
--
GitLab