Updated references to further work.

src/knot/server/notify.c

@@ -59,7 +59,7 @@ static int notify_request(const knot_rrset_t *rrset,
 		return KNOT_ERROR;
 	}
 
-	/* Write back size, #10 crappy API. */
+	/* Write back size, #189 crappy API. */
 	*size = pkt->size;
 
 	knot_pkt_free(&pkt);

src/libknot/nameserver/name-server.c

@@ -579,5 +579,3 @@ int ns_proc_out(uint8_t *wire, uint16_t *wire_len, ns_proc_context_t *ctx)
 	dbg_ns("%s -> %s\n", __func__, NS_STATE_STR(ctx->state));
 	return ctx->state;
 }
-
-/* #10 >>> Next-gen API. */

src/libknot/nameserver/nsec_proofs.c

@@ -9,6 +9,13 @@
 
 #define DNSSEC_ENABLED 1
 
+/*! \note #191 There is a lot of duplicate and legacy code here. I have just
+ *             divided the API into 3 + 1 basic proofs used and separated the
+ *             code to its own file. Still, it should be cleaned up and
+ *             each proof should be very briefly documented (what proves what)
+ *             with hints to the RFC, as it's not so complicated as it looks here.
+ */
+
 
 /*----------------------------------------------------------------------------*/
 /*!

src/libknot/packet/pkt.c

@@ -822,7 +822,7 @@ int knot_pkt_parse_payload(knot_pkt_t *pkt, unsigned flags)
 	return KNOT_EOK;
 }
 
-/*** <<< #10 DEPRECATED */
+/*** <<< #8 DEPRECATED */
 /*----------------------------------------------------------------------------*/
 
 int knot_pkt_add_opt(knot_pkt_t *resp,
@@ -878,5 +878,5 @@ int knot_pkt_add_opt(knot_pkt_t *resp,
 	return KNOT_EOK;
 }
 
-/*** >>> #10 DEPRECATED */
+/*** >>> #8 DEPRECATED */
 /*----------------------------------------------------------------------------*/

src/libknot/packet/pkt.h

@@ -86,12 +86,12 @@ typedef struct knot_pkt {
 	knot_opt_rr_t opt_rr;   /*!< OPT RR included in the packet. */
 	knot_rrset_t *tsig_rr;  /*!< TSIG RR stored in the packet. */
 
-	/* #10 <<< SHOULD BE IN ANSWERING CONTEXT */
+	/* #189 <<< SHOULD BE IN ANSWERING CONTEXT */
 	/*! \todo Could be removed after NSEC proof port to packet processing,
 	 *        and request processing module. */
 	const knot_tsig_key_t *tsig_key;
 	const struct knot_pkt *query; /*!< Associated query. */
-	/* #10 >>> SHOULD BE IN ANSWERING CONTEXT */
+	/* #189 >>> SHOULD BE IN ANSWERING CONTEXT */
 
 	/* Packet sections. */
 	knot_section_t current;
@@ -298,7 +298,7 @@ static inline bool knot_pkt_have_nsid(const knot_pkt_t *pkt)
 	       && knot_edns_has_option(&pkt->opt_rr, EDNS_OPTION_NSID);
 }
 
-/*** <<< #10 DEPRECATED */
+/*** <<< #190 DEPRECATED */
 /*----------------------------------------------------------------------------*/
 /*!
  * \brief Sets the OPT RR of the response.
@@ -326,7 +326,7 @@ int knot_pkt_add_opt(knot_pkt_t *resp,
                           int add_nsid);
 
 /*----------------------------------------------------------------------------*/
-/*** >>> #10 DEPRECATED */
+/*** >>> #190 DEPRECATED */
 
 
 #endif /* _KNOT_PACKET_H_ */

tests/ns.c

@@ -194,9 +194,9 @@ int main(int argc, char *argv[])
 	exec_query(&query_ctx, "IN/ixfr", query->wire, query->size, KNOT_RCODE_NOTAUTH);
 	
 	/* \note Tests below are not possible without proper zone and zone data. */
-	/* #10 Process UPDATE query. */
-	/* #10 Process AXFR client. */
-	/* #10 Process IXFR client. */
+	/* #189 Process UPDATE query. */
+	/* #189 Process AXFR client. */
+	/* #189 Process IXFR client. */
 	
 	/* Query processor (smaller than DNS header, ignore). */
 	state = ns_proc_reset(&query_ctx);

tests/pkt.c

@@ -144,7 +144,7 @@ int main(int argc, char *argv[])
 	ok(knot_dname_is_equal(knot_pkt_qname(out),
 	                       knot_pkt_qname(in)), "pkt: equal qname");
 
-	/* #10 check counts */
+	/* Check counts */
 	is_int(knot_wire_get_qdcount(out->wire),
 	       knot_wire_get_qdcount(in->wire), "pkt: QD match");
 	is_int(knot_wire_get_ancount(out->wire),
@@ -154,7 +154,7 @@ int main(int argc, char *argv[])
 	is_int(knot_wire_get_arcount(out->wire),
 	       knot_wire_get_arcount(in->wire), "pkt: AR match");
 
-	/* #10 check RRs */
+	/* Check RRs */
 	int rr_matched = 0;
 	for (unsigned i = 0; i < NAMECOUNT; ++i) {
 		if (knot_rrset_equal(out->rr[i], in->rr[i], KNOT_RRSET_COMPARE_WHOLE) > 0) {
@@ -163,8 +163,6 @@ int main(int argc, char *argv[])
 	}
 	is_int(NAMECOUNT, rr_matched, "pkt: RR content match");
 
-	/* #10 check signature */
-
 	/* Free packets. */
 	knot_pkt_free(&out);
 	knot_pkt_free(&in);