From 8cc6847890831420816f114dd43b74881f4c07c4 Mon Sep 17 00:00:00 2001
From: Tomas Krizek <tomas.krizek@nic.cz>
Date: Fri, 29 Oct 2021 12:45:27 +0200
Subject: [PATCH] lib/resolve: clarify why debug level is checked
---
lib/resolve.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/resolve.c b/lib/resolve.c
index cf2ba0329..7a01d4b93 100644
--- a/lib/resolve.c
+++ b/lib/resolve.c
@@ -457,7 +457,7 @@ static int answer_padding(struct kr_request *request)
static void answer_fail(struct kr_request *request)
{
/* Note: OPT in SERVFAIL response is still useful for cookies/additional info. */
- if (kr_log_is_debug(RESOLVER, request))
+ if (kr_log_is_debug(RESOLVER, request)) /* logging optimization */
kr_log_req(request, 0, 0, RESOLVER,
"request failed, answering with empty SERVFAIL\n");
knot_pkt_t *answer = request->answer;
@@ -831,7 +831,7 @@ int kr_resolve_consume(struct kr_request *request, struct kr_transport **transpo
if (!qry->flags.CACHED) {
if (request->state & KR_STATE_FAIL) {
if (++request->count_fail_row > KR_CONSUME_FAIL_ROW_LIMIT) {
- if (kr_log_is_debug(RESOLVER, request)) {
+ if (kr_log_is_debug(RESOLVER, request)) { /* logging optimization */
kr_log_req(request, 0, 2, RESOLVER,
"=> too many failures in a row, "
"bail out (mitigation for NXNSAttack "
--
GitLab