GitLab

lint:clang-scan-build reported:
> warning: The code calls sizeof() on a pointer type.
> This can produce an unexpected result
but in our case it's intentional.
(Yes, using pointers as keys in trie isn't very pretty.)

Only count incoming requests into this,
as before "some simplifications" commit.

daemon/worker: avoid usage of qr_tasklist in struct request_ctx as it is redundant; use direct pointer to task instead

There are some (other) tests in knot-dns repo,
but having some more shouldn't hurt, especially as
we've added some new functions now.

It's focused on FIFO queue usage.

FIXME: unit tests

This prompted a slight reorganization inside trie.c

They don't seem to be useful individually, so why not clean up.

- Some (potentially) unused vars were left behind.
- The two on_* functions are identical except for the uv types passed,
  and those are surely the same in the part we use, but it's not worth
  to deduplicate when these functions are only two and so simple.
- lint:c was complaining about the uv_tcp_t malloc().

Also don't allocate much memory for cookies if we compile them out.

The support hasn't landed in libuv over all the years,
and we've been still reserving memory for it in advance.
Also comment on the singleton buffer usage.

I did NOT remove this one, as in a quick profile that would be
increase in roughly 0.5% time in malloc, so that's possibly justifiable.
(And this one is much less obstructing to splitting the worker code.)

See the message in parent commit.

A quick profiling showed no change in performance,
and in particular no change in time spent in malloc/free.
Some of the types in the union differed in size by a multiple.

If their performance won't be satisfying, replacements should be
considered first (e.g. jemalloc) before rolling our own stuff.

daemon: logic around struct session was relocated to separate module; input data buffering scheme was changed (libuv); attempt was made to simplify processing of the stream

I believe that's what most users want; practical motivation:
https://forum.turris.cz/t/kresd-responds-to-hints-with-nxdomain-for-aaaa-requests/8353

(vcunat modified the wording slightly)

I see no use to handle write() return codes in *this* function.

Closes #255.