filter.c 18 KB
Newer Older
1
2
3
4
5
6
/*
 *	Filters: utility functions
 *
 *	Copyright 1998 Pavel Machek <pavel@ucw.cz>
 *
 *	Can be freely distributed and used under the terms of the GNU GPL.
7
 *
8
 * 	Notice that pair is stored as integer: first << 16 | second
Pavel Machek's avatar
Pavel Machek committed
9
 *
10
11
 */

12
#define LOCAL_DEBUG
13

14
15
16
17
#include "nest/bird.h"
#include "lib/lists.h"
#include "lib/resource.h"
#include "lib/socket.h"
18
#include "lib/string.h"
19
#include "lib/unaligned.h"
20
21
22
23
24
25
#include "nest/route.h"
#include "nest/protocol.h"
#include "nest/iface.h"
#include "conf/conf.h"
#include "filter/filter.h"

26
27
#define P(a,b) ((a<<8) | b)

28
29
struct f_inst *startup_func = NULL;

30
31
32
33
34
35
#define CMP_ERROR 999

/* Compare two values, returns -1, 0, 1 compared, ERROR 999 */
int
val_compare(struct f_val v1, struct f_val v2)
{
Pavel Machek's avatar
Pavel Machek committed
36
37
38
39
40
41
42
  if ((v1.type == T_VOID) && (v2.type == T_VOID))
    return 0;
  if (v1.type == T_VOID)	/* Hack for else */
    return -1;
  if (v2.type == T_VOID)
    return 1;

43
44
  if (v1.type != v2.type)
    return CMP_ERROR;
45
  switch (v1.type) {
46
  case T_ENUM:
47
  case T_INT: 
48
  case T_PAIR:
49
50
51
    if (v1.val.i == v2.val.i) return 0;
    if (v1.val.i < v2.val.i) return -1;
    return 1;
52
  case T_IP:
53
54
  case T_PREFIX:
    return ipa_compare(v1.val.px.ip, v2.val.px.ip);
55
56
  default:
    return CMP_ERROR;
57
58
59
  }
}

60
61
62
63
64
65
66
67
68
69
70
71
72
int 
val_simple_in_range(struct f_val v1, struct f_val v2)
{
  if ((v1.type == T_IP) && (v2.type == T_PREFIX))
    return !(ipa_compare(ipa_and(v2.val.px.ip, ipa_mkmask(v2.val.px.len)), ipa_and(v1.val.px.ip, ipa_mkmask(v2.val.px.len))));

  if ((v1.type == T_PREFIX) && (v2.type == T_PREFIX)) {
    ip_addr mask;
    if (v1.val.px.len & (LEN_PLUS | LEN_MINUS | LEN_RANGE))
      return CMP_ERROR;
    mask = ipa_mkmask( v2.val.px.len & LEN_MASK );
    if (ipa_compare(ipa_and(v2.val.px.ip, mask), ipa_and(v1.val.px.ip, mask)))
      return 0;
73

74
75
76
77
78
79
80
81
82
83
84
85
    if ((v2.val.px.len & LEN_MINUS) && (v1.val.px.len <= (v2.val.px.len & LEN_MASK)))
      return 0;
    if ((v2.val.px.len & LEN_PLUS) && (v1.val.px.len < (v2.val.px.len & LEN_MASK)))
      return 0;
    if ((v2.val.px.len & LEN_RANGE) && ((v1.val.px.len < (0xff & (v2.val.px.len >> 16)))
					|| (v1.val.px.len > (0xff & (v2.val.px.len >> 8)))))
      return 0;
    return 1;    
  }
  return CMP_ERROR;
}

86
87
88
int
val_in_range(struct f_val v1, struct f_val v2)
{
89
90
91
92
93
94
95
  int res;

  res = val_simple_in_range(v1, v2);

  if (res != CMP_ERROR)
    return res;

Pavel Machek's avatar
Pavel Machek committed
96
  if (((v1.type == T_INT) || ((v1.type == T_IP) || (v1.type == T_PREFIX)) && (v2.type == T_SET))) {
97
98
99
100
101
102
    struct f_tree *n;
    n = find_tree(v2.val.t, v1);
    if (!n)
      return 0;
    return !! (val_simple_in_range(v1, n->from));	/* We turn CMP_ERROR into compared ok, and that's fine */
  }
103
104
105
  return CMP_ERROR;
}

106
107
108
109
static void
tree_print(struct f_tree *t)
{
  if (!t) {
110
    debug( "() " );
111
112
    return;
  }
113
  debug( "[ " );
114
  tree_print( t->left );
115
  debug( ", " ); val_print( t->from ); debug( ".." ); val_print( t->to ); debug( ", " );
116
  tree_print( t->right );
117
  debug( "] " );
118
119
120
121
122
123
124
125
126
127
128
129
130
}

void
val_print(struct f_val v)
{
  char buf[2048];
#define PRINTF(a...) bsnprintf( buf, 2040, a )
  buf[0] = 0;
  switch (v.type) {
  case T_VOID: PRINTF( "(void)" ); break;
  case T_BOOL: PRINTF( v.val.i ? "TRUE" : "FALSE" ); break;
  case T_INT: PRINTF( "%d ", v.val.i ); break;
  case T_STRING: PRINTF( "%s", v.val.s ); break;
131
  case T_IP: PRINTF( "%I", v.val.px.ip ); break;
132
133
  case T_PREFIX: PRINTF( "%I/%d", v.val.px.ip, v.val.px.len ); break;
  case T_PAIR: PRINTF( "(%d,%d)", v.val.i >> 16, v.val.i & 0xffff ); break;
134
  case T_SET: tree_print( v.val.t ); PRINTF( "\n" ); break;
Pavel Machek's avatar
Pavel Machek committed
135
  case T_ENUM: PRINTF( "(enum %x)%d", v.type, v.val.i ); break;
136
  case T_PATH: debug( "(path " ); { struct f_path *p = v.val.s; while (p) { debug("%d ", p->val); p=p->next; } debug(")" ); } break;
137
  default: PRINTF( "[unknown type %x]", v.type );
138
#undef PRINTF
139
  }
140
  debug( buf );
141
142
}

143
static struct rte **f_rte, *f_rte_old;
144
static struct linpool *f_pool;
Pavel Machek's avatar
Pavel Machek committed
145
static struct ea_list **f_tmp_attrs;
146
static int f_flags;
147

148
149
150
151
152
153
154
155
156
#define runtime(x) do { \
    log( L_ERR x ); \
    res.type = T_RETURN; \
    res.val.i = F_ERROR; \
    return res; \
  } while(0)

#define ARG(x,y) \
	x = interpret(what->y); \
157
	if (x.type & T_RETURN) \
158
159
160
161
162
163
164
165
		return x;

#define ONEARG ARG(v1, a1.p)
#define TWOARGS ARG(v1, a1.p) \
		ARG(v2, a2.p)
#define TWOARGS_C TWOARGS \
                  if (v1.type != v2.type) \
		    runtime( "Can not operate with values of incompatible types" );
166

167
168
169
170
171
static struct f_val
interpret(struct f_inst *what)
{
  struct symbol *sym;
  struct f_val v1, v2, res;
172
  int i,j,k;
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204

  res.type = T_VOID;
  if (!what)
    return res;

  switch(what->code) {
  case ',':
    TWOARGS;
    break;

/* Binary operators */
  case '+':
    TWOARGS_C;
    switch (res.type = v1.type) {
    case T_VOID: runtime( "Can not operate with values of type void" );
    case T_INT: res.val.i = v1.val.i + v2.val.i; break;
    default: runtime( "Usage of unknown type" );
    }
    break;
  case '/':
    TWOARGS_C;
    switch (res.type = v1.type) {
    case T_VOID: runtime( "Can not operate with values of type void" );
    case T_INT: res.val.i = v1.val.i / v2.val.i; break;
    case T_IP: if (v2.type != T_INT)
                 runtime( "Operator / is <ip>/<int>" );
               break;
    default: runtime( "Usage of unknown type" );
    }
    break;

/* Relational operators */
205
206
207
208
209
210
211
212

#define COMPARE(x) \
    TWOARGS_C; \
    res.type = T_BOOL; \
    i = val_compare(v1, v2); \
    if (i==CMP_ERROR) \
      runtime( "Error in comparation" ); \
    res.val.i = (x); \
213
    break;
214

215
216
  case P('!','='): COMPARE(i!=0);
  case P('=','='): COMPARE(i==0);
217
  case '<': COMPARE(i==-1);
218
  case P('<','='): COMPARE(i!=1);
219

Pavel Machek's avatar
Pavel Machek committed
220
221
222
223
224
225
226
227
  case '!':
    ONEARG;
    if (v1.type != T_BOOL)
      runtime( "not applied to non-boolean" );
    res = v1;
    res.val.i = !res.val.i;
    break;

228
229
  case '~':
    TWOARGS;
230
    res.type = T_BOOL;
231
232
233
    res.val.i = val_in_range(v1, v2);
    if (res.val.i == CMP_ERROR)
      runtime( "~ applied on unknown type pair" );
234
    break;
235
  case P('d','e'):
236
237
238
239
    ONEARG;
    res.type = T_BOOL;
    res.val.i = (v1.type != T_VOID);
    break;
240

241
  /* Set to indirect value, a1 = variable, a2 = value */
242
  case 's':
Pavel Machek's avatar
Pavel Machek committed
243
244
    ARG(v2, a2.p);
    sym = what->a1.p;
245
246
    switch (res.type = v2.type) {
    case T_VOID: runtime( "Can not assign void values" );
247
    case T_ENUM:
248
    case T_INT: 
249
250
251
    case T_IP: 
    case T_PREFIX: 
    case T_PAIR: 
252
    case T_PATH:
253
      if (sym->class != (SYM_VARIABLE | v2.type))
254
	runtime( "Variable of bad type" );
255
      * (struct f_val *) sym->aux2 = v2; 
256
      break;
257
    default:
258
      bug( "Set to invalid type" );
259
260
261
    }
    break;

262
  case 'c':	/* integer (or simple type) constant */
263
    res.type = what->aux;
264
    res.val.i = what->a2.i;
265
    break;
266
267
268
  case 'C':
    res = * ((struct f_val *) what->a1.p);
    break;
269
270
  case 'p':
    ONEARG;
271
    val_print(v1);
272
273
274
275
276
277
    break;
  case '?':	/* ? has really strange error value, so we can implement if ... else nicely :-) */
    ONEARG;
    if (v1.type != T_BOOL)
      runtime( "If requires bool expression" );
    if (v1.val.i) {
Pavel Machek's avatar
Pavel Machek committed
278
      ARG(res,a2.p);
279
280
281
282
283
      res.val.i = 0;
    } else res.val.i = 1;
    res.type = T_BOOL;
    break;
  case '0':
284
    debug( "No operation\n" );
285
    break;
286
  case P('p',','):
287
    ONEARG;
288
    if (what->a2.i == F_NOP || (what->a2.i != F_NONL && what->a1.p))
289
      debug( "\n" );
290

Pavel Machek's avatar
Pavel Machek committed
291
    switch (what->a2.i) {
292
293
294
295
296
    case F_QUITBIRD:
      die( "Filter asked me to die" );
    case F_ACCEPT:
      /* Should take care about turning ACCEPT into MODIFY */
    case F_ERROR:
297
    case F_REJECT:	/* FIXME (noncritical) Should print complete route along with reason to reject route */
298
      res.type = T_RETURN;
299
      res.val.i = what->a2.i;
300
      return res;	/* We have to return now, no more processing. */
301
    case F_NONL:
302
303
304
305
306
307
    case F_NOP:
      break;
    default:
      bug( "unknown return type: can not happen");
    }
    break;
308
309
310
  case 'a':	/* rta access */
    {
      struct rta *rta = (*f_rte)->attrs;
311
      res.type = what->aux;
312
313
      switch(res.type) {
      case T_IP:
314
	res.val.px.ip = * (ip_addr *) ((char *) rta + what->a2.i);
315
	break;
316
317
318
      case T_ENUM:
	res.val.i = * ((char *) rta + what->a2.i);
	break;
319
320
321
322
323
324
325
      case T_PREFIX:	/* Warning: this works only for prefix of network */
	{
	  res.val.px.ip = (*f_rte)->net->n.prefix;
	  res.val.px.len = (*f_rte)->net->n.pxlen;
	  break;
	}
      default:
326
	bug( "Invalid type for rta access (%x)", res.type );
327
328
329
      }
    }
    break;
330
  case P('e','a'):	/* Access to extended attributes */
331
    {
332
      eattr *e = NULL;
333
      if (!(f_flags & FF_FORCE_TMPATTR))
334
	e = ea_find( (*f_rte)->attrs->eattrs, what->a2.i );
Pavel Machek's avatar
Pavel Machek committed
335
336
      if (!e) 
	e = ea_find( (*f_tmp_attrs), what->a2.i );
337
      if ((!e) && (f_flags & FF_FORCE_TMPATTR))
338
339
	e = ea_find( (*f_rte)->attrs->eattrs, what->a2.i );
      
340
341
342
343
      if (!e) {
	res.type = T_VOID;
	break;
      }
344
      res.type = what->aux;
345
346
347
348
349
350
      switch (what->a1.i) {
      case T_INT:
	res.val.i = e->u.data;
	break;
      }
    }
351
    break;
352
  case P('e','S'):
353
354
    ONEARG;
    if (v1.type != what->aux)
355
      runtime("Wrong type when setting dynamic attribute");
356
357
358
359
360
361
362
363
364

    {
      struct ea_list *l = lp_alloc(f_pool, sizeof(struct ea_list) + sizeof(eattr));

      l->next = NULL;
      l->flags = EALF_SORTED;
      l->count = 1;
      l->attrs[0].id = what->a2.i;
      l->attrs[0].flags = 0;
Pavel Machek's avatar
Pavel Machek committed
365
366
367
368
369
      l->attrs[0].type = what->aux;
      switch (what->aux & EAF_TYPE_MASK) {
      case EAF_TYPE_INT:
	if (v1.type != T_INT)
	  runtime( "Setting int attribute to non-int value" );
370
371
	l->attrs[0].u.data = v1.val.i;
	break;
Pavel Machek's avatar
Pavel Machek committed
372
373
374
      case EAF_TYPE_UNDEF:
	if (v1.type != T_VOID)
	  runtime( "Setting void attribute to non-void value" );
375
376
	l->attrs[0].u.data = 0;
	break;
377
      }
Pavel Machek's avatar
Pavel Machek committed
378

379
380
      if (!(what->aux & EAF_TEMP) && (!(f_flags & FF_FORCE_TMPATTR))) {
	*f_rte = rte_cow(*f_rte);
Pavel Machek's avatar
Pavel Machek committed
381
382
383
384
385
386
	l->next = (*f_rte)->attrs->eattrs;
	(*f_rte)->attrs->eattrs = l;
      } else {
	l->next = (*f_tmp_attrs);
	(*f_tmp_attrs) = l;
      }
387
388
    }
    break;
389

390
  case P('c','p'):	/* Convert prefix to ... */
391
392
393
    ONEARG;
    if (v1.type != T_PREFIX)
      runtime( "Can not convert non-prefix this way" );
394
    res.type = what->aux;
395
396
    switch(res.type) {
    case T_INT:	res.val.i = v1.val.px.len; break;
397
    case T_IP: res.val.px.ip = v1.val.px.ip; break;
398
    default: bug( "Unknown prefix to conversion" );
399
400
    }
    break;
401
402
403
404
405
406
  case 'r':
    ONEARG;
    res = v1;
    res.type |= T_RETURN;
    break;
  case P('c','a'): /* CALL: this is special: if T_RETURN and returning some value, mask it out  */
407
408
    ONEARG;
    res = interpret(what->a2.p);
409
410
411
    if (res.type == T_RETURN)
      return res;
    res.type &= ~T_RETURN;    
412
    break;
413
  case P('S','W'):
414
    ONEARG;
Pavel Machek's avatar
Pavel Machek committed
415
416
417
418
419
420
    {
      struct f_tree *t = find_tree(what->a2.p, v1);
      if (!t) {
	v1.type = T_VOID;
	t = find_tree(what->a2.p, v1);
	if (!t) {
421
	  debug( "No else statement?\n ");
Pavel Machek's avatar
Pavel Machek committed
422
423
424
425
	  break;
	}
      }	
      if (!t->data)
426
	bug( "Impossible: no code associated!" );
Pavel Machek's avatar
Pavel Machek committed
427
428
      return interpret(t->data);
    }
429
    break;
430
  case P('i','M'): /* IP.MASK(val) */
431
432
433
434
435
436
437
438
439
440
    TWOARGS;
    if (v2.type != T_INT)
      runtime( "Can not use this type for mask.");
    if (v1.type != T_IP)
      runtime( "You can mask only IP addresses." );
    {
      ip_addr mask = ipa_mkmask(v2.val.i);
      res.type = T_IP;
      res.val.px.ip = ipa_and(mask, v1.val.px.ip);
    }
441
    break;
442
443
444
445
446
447
448
449
  default:
    bug( "Unknown instruction %d (%c)", what->code, what->code & 0xff);
  }
  if (what->next)
    return interpret(what->next);
  return res;
}

450
#undef ARG
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
#define ARG(x,y) \
	if (!i_same(f1->y, f2->y)) \
		return 0;

#define ONEARG ARG(v1, a1.p)
#define TWOARGS ARG(v1, a1.p) \
		ARG(v2, a2.p)

#define A2_SAME if (f1->a2.i != f2->a2.i) return 0;

int
i_same(struct f_inst *f1, struct f_inst *f2)
{
  if ((!!f1) != (!!f2))
    return 0;
466
467
  if (!f1)
    return 1;
468
469
470
471
  if (f1->aux != f2->aux)
    return 0;
  if (f1->code != f2->code)
    return 0;
472
473
  if (f1 == f2)		/* It looks strange, but it is possible with call rewriting trickery */
    return 1;
474
475
476
477
478

  switch(f1->code) {
  case ',': /* fall through */
  case '+':
  case '/':
479
480
  case P('!','='):
  case P('=','='):
481
  case '<':
482
  case P('<','='): TWOARGS; break;
483

Pavel Machek's avatar
Pavel Machek committed
484
  case '!': ONEARG; break;
485
  case '~': TWOARGS; break;
486
  case P('d','e'): ONEARG; break;
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508

  case 's':
    ARG(v2, a2.p);
    {
      struct symbol *s1, *s2;
      s1 = f1->a1.p;
      s2 = f2->a1.p;
      if (strcmp(s1->name, s2->name))
	return 0;
      if (s1->class != s2->class)
	return 0;
    }
    break;

  case 'c': A2_SAME; break;
  case 'C': 
    if (val_compare(* (struct f_val *) f1->a1.p, * (struct f_val *) f2->a2.p))
      return 0;
    break;
  case 'p': ONEARG; break;
  case '?': TWOARGS; break;
  case '0': break;
509
  case P('p',','): ONEARG; A2_SAME; break;
510
  case 'a': A2_SAME; break;
511
512
  case P('e','a'): A2_SAME; break;
  case P('e','S'): ONEARG; A2_SAME; break;
513

514
515
  case 'r': ONEARG; break;
  case P('c','p'): ONEARG; break;
516
517
518
519
520
521
  case P('c','a'): /* Call rewriting trickery to avoid exponential behaviour */
             ONEARG; 
	     if (!i_same(f1->a2.p, f2->a2.p))
	       return 0; 
	     f2->a2.p = f1->a2.p;
	     break;
522
523
  case P('S','W'): ONEARG; if (!same_tree(f1->a2.p, f2->a2.p)) return 0; break;
  case P('i','M'): TWOARGS; break;
524
525
526
527
528
529
  default:
    bug( "Unknown instruction %d in same (%c)", f1->code, f1->code & 0xff);
  }
  return i_same(f1->next, f2->next);
}

530
int
531
f_run(struct filter *filter, struct rte **rte, struct ea_list **tmp_attrs, struct linpool *tmp_pool, int flags)
532
533
534
{
  struct f_inst *inst;
  struct f_val res;
535
  DBG( "Running filter `%s'...", filter->name );
536

537
  f_flags = flags;
Pavel Machek's avatar
Pavel Machek committed
538
  f_tmp_attrs = tmp_attrs;
539
  f_rte = rte;
540
  f_rte_old = *rte;
541
  f_pool = tmp_pool;
542
543
544
545
  inst = filter->root;
  res = interpret(inst);
  if (res.type != T_RETURN)
    return F_ERROR;
546
  DBG( "done (%d)\n", res.val.i );
547
548
549
550
551
552
553
  return res.val.i;
}

void
filters_postconfig(void)
{
  struct f_val res;
554
  if (startup_func) {
555
    debug( "Launching startup function...\n" );
556
    res = interpret(startup_func);
Pavel Machek's avatar
Pavel Machek committed
557
    if (res.type == F_ERROR)
558
      die( "Startup function resulted in error." );
559
    debug( "done\n" );
560
  }
561
  self_test();
562
} 
563
564
565
566

int
filter_same(struct filter *new, struct filter *old)
{
567
568
569
570
571
  if (old == new)	/* Handle FILTER_ACCEPT and FILTER_REJECT */
    return 1;
  if (old == FILTER_ACCEPT || old == FILTER_REJECT ||
      new == FILTER_ACCEPT || new == FILTER_REJECT)
    return 0;
572
  return i_same(new->root, old->root);
573
}
574

Pavel Machek's avatar
Pavel Machek committed
575
576
577
578
579
/* This should end up far away from here!
 *
 * FIXME: It should take struct adata *, not u8 * + length; but that makes it a little more difficult to test.
 * Or maybe both versions are usefull?
 */
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596

int
path_getlen(u8 *p, int len)
{
  int res = 0;
  u8 *q = p+len;
  while (p<q) {
    switch (*p++) {
    case 1: len = *p++; res++;    p += 2*len; break;
    case 2: len = *p++; res+=len; p += 2*len; break;
    default: bug("This should not be in path");
    }
  }
  return res;
}


597
#define PRINTF(a...) { int l; bsnprintf( s, bigbuf+4090-s, a ); s += strlen(s); }
598
599
600
601
602
#define COMMA if (first) first = 0; else PRINTF( ", " );
char *
path_format(u8 *p, int len)
{
  char bigbuf[4096];	/* Keep it smaller than buf */
603
  char *s = bigbuf;
604
605
606
607
608
609
610
611
  int first = 1;
  int i;
  u8 *q = p+len;
  while (p<q) {
    switch (*p++) {
    case 1:	/* This is a set */
      len = *p++;
      COMMA;
612
      PRINTF( "{" );
613
614
615
616
617
618
619
620
      {
	int first = 1;
	for (i=0; i<len; i++) {
	  COMMA;
	  PRINTF( "%d", get_u16(p));
	  p+=2;
	}
      }
621
      PRINTF( "}" );
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
      break;

    case 2:	/* This is a sequence */
      len = *p++;
      for (i=0; i<len; i++) {
	int l;
	COMMA;
	PRINTF( "%d", get_u16(p));
	p+=2;
      }
      break;

    default:
      bug("This should not be in path");
    }
  }
638
  return strdup(bigbuf);
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
}
#undef PRINTF
#undef COMMA

#define PM_END -1
#define PM_ASTERIX -2

#define MASK_PLUS do { if (*++mask == PM_END) return next == q; \
		       asterix = (*mask == PM_ASTERIX); \
		       printf( "Asterix now %d\n", asterix ); \
                       if (asterix) { if (*++mask == PM_END) { printf( "Quick exit\n" ); return 1; } } \
		       } while(0)
int
path_match(u8 *p, int len, s32 *mask)
{
  int i;
  int asterix = 0;
  u8 *q = p+len;
  u8 *next;

  while (p<q) {
    switch (*p++) {
    case 1:	/* This is a set */
      len = *p++;
      {
	u8 *p_save = p;
	next = p_save + 2*len;
      retry:
	p = p_save;
	for (i=0; i<len; i++) {
	  if (asterix && (get_u16(p) == *mask)) {
	    MASK_PLUS;
	    goto retry;
	  }
	  if (!asterix && (get_u16(p) == *mask)) {
	    p = next;
	    MASK_PLUS;
	    goto okay;
	  }
	  p+=2;
	}
	if (!asterix)
	  return 0;
      okay:
      }
      break;

    case 2:	/* This is a sequence */
      len = *p++;
      for (i=0; i<len; i++) {
	next = p+2;
	if (asterix && (get_u16(p) == *mask))
	  MASK_PLUS;
	else if (!asterix) {
	  if (get_u16(p) != *mask)
	    return 0;
	  MASK_PLUS;
	}
	p+=2;
      }
      break;

    default:
      bug("This should not be in path");
    }
  }
  return 0;
}

struct adata *
comlist_add(struct linpool *pool, struct adata *list, u32 val)
{
  struct adata *res = lp_alloc(pool, list->length + sizeof(struct adata) + 4);
  res->length = list->length+4;
  * (u32 *) res->data = val;
  memcpy((char *) res->data + 4, list->data, list->length);
  return res;
}

struct adata *
comlist_contains(struct adata *list, u32 val)
{
  u32 *l = &(list->data);
  int i;
  for (i=0; i<list->length/4; i++)
    if (*l++ == val)
      return 1;
  return 0;
}

struct adata *
comlist_del(struct linpool *pool, struct adata *list, u32 val)
{
  struct adata *res;
  u32 *l, *k;
  int i;

  if (!comlist_contains(list, val))
    return list;

  res = lp_alloc(pool, list->length + sizeof(struct adata) - 4);
  res->length = list->length-4;

  l = &(list->data);
  k = &(res->data);
  for (i=0; i<list->length/4; i++)
    if (l[i] != val)
      *k++ = l[i];

  return res;
}

struct adata *
comlist_empty(struct linpool *pool)
{
  struct adata *res = lp_alloc(pool, sizeof(struct adata));
  res->length = 0;
  return res;
}

void
self_test(void)
{
  char path1[] = { 2, 5, 0, 5, 0, 4, 0, 3, 0, 2, 0, 1 };
  char path2[] = { 2, 5, 0, 5, 0, 4, 0, 3, 0, 2, 0, 1, 1, 5, 0, 5, 0, 4, 0, 3, 0, 2, 0, 1 };
  s32 match[] = { 5, PM_ASTERIX, 2, PM_ASTERIX, 1, 3, PM_END };

  DBG( "Filters self-testing:\n" );
  DBG( "%s\n", path_format(path1, sizeof(path1)) );
  DBG( "%s\n", path_format(path2, sizeof(path2)) );
  DBG( "5, 6 = %d, %d\n", path_getlen(path1, sizeof(path1)), path_getlen(path2, sizeof(path2)) );
  DBG( "%d\n", path_match(path1, sizeof(path1), match));
  DBG( "%d\n", path_match(path2, sizeof(path2), match));
//  die( "okay" );
}