1. 03 Oct, 2022 5 commits
  2. 27 Sep, 2022 1 commit
    • Alexander Zubkov's avatar
      KRT: Fix setting default preference · 0f2be469
      Alexander Zubkov authored
      Changes in commit eb937358 broke setting of channel preference for alien
      routes learned during scan. The preference was set only for async routes.
      Move common attribute processing part of functions krt_learn_async() and
      krt_learn_async() to a separate function to have only one place for such
      changes.
      0f2be469
  3. 16 Sep, 2022 1 commit
  4. 06 Sep, 2022 1 commit
    • Maria Matejka's avatar
      Better profylaction recursive route loops · 71b3456e
      Maria Matejka authored
      In some specific configurations, it was possible to send BIRD into an
      infinite loop of recursive next hop resolution. This was caused by route
      priority inversion.
      
      To prevent priority inversions affecting other next hops, we simply
      refuse to resolve any next hop if the best route for the matching prefix
      is recursive or any other route with the same preference is recursive.
      
      Next hop resolution doesn't change route priority, therefore it is
      perfectly OK to resolve BGP next hops e.g. by an OSPF route, yet if the
      same (or covering) prefix is also announced by iBGP, by retraction of
      the OSPF route we would get a possible priority inversion.
      71b3456e
  5. 18 Aug, 2022 3 commits
  6. 03 Aug, 2022 2 commits
  7. 27 Jul, 2022 1 commit
  8. 26 Jul, 2022 1 commit
    • Ondřej Zajíček's avatar
      Netlink: Restrict route replace for IPv6 · ddb1bdf2
      Ondřej Zajíček authored
      Seems like the previous patch was too optimistic, as route replace is
      still broken even in Linux 4.19 LTS (but fixed in Linux 5.10 LTS) for:
      
        ip route add 2001:db8::/32 via fe80::1 dev eth0
        ip route replace 2001:db8::/32 dev eth0
      
      It ends with two routes instead of just the second.
      
      The issue is limited to direct and special type (e.g. unreachable)
      routes, the patch restricts route replace for cases when the new route
      is a regular route (with a next hop address).
      ddb1bdf2
  9. 25 Jul, 2022 1 commit
    • Ondřej Zajíček's avatar
      Netlink: Simplify handling of IPv6 ECMP routes · 722daa95
      Ondřej Zajíček authored
      When IPv6 ECMP support first appeared in Linux kernel, it used different
      API than IPv4 ECMP. Individual next hops were updated and announced
      separately, instead of using RTA_MULTIPATH as in IPv4. This has several
      drawbacks and requires complex code to merge received notifications to
      one multipath route.
      
      When Linux came with IPv6 RTA_MULTIPATH support, the initial versions
      were somewhat buggy, so we kept using the old API for updates (splitting
      multipath routes to sequences of route updates), while accepting both
      old-style routes and RTA_MULTIPATH routes in scans / notifications.
      
      As IPv6 RTA_MULTIPATH support is here for a long time, this patch fully
      switches Netlink to the IPv6 RTA_MULTIPATH API and removes old complex
      code for handling individual next hop announces.
      
      The required Linux version is at least 4.11 for reliable operation.
      
      Thanks to Daniel Gröber for the original patch.
      722daa95
  10. 24 Jul, 2022 2 commits
    • Ondřej Zajíček's avatar
      Merge branch 'master' into backport · 2e484f8d
      Ondřej Zajíček authored
      2e484f8d
    • Ondřej Zajíček's avatar
      KRT: Scan routing tables separetely on linux to avoid congestion · 534d0a4b
      Ondřej Zajíček authored
      Remove compile-time sysdep option CONFIG_ALL_TABLES_AT_ONCE, replace it
      with runtime ability to run either separate table scans or shared scan.
      
      On Linux, use separate table scans by default when the netlink socket
      option NETLINK_GET_STRICT_CHK is available, but retreat to shared scan
      when it fails.
      
      Running separate table scans has advantages where some routing tables are
      managed independently, e.g. when multiple routing daemons are running on
      the same machine, as kernel routing table modification performance is
      significantly reduced when the table is modified while it is being
      scanned.
      
      Thanks Daniel Gröber for the original patch and Toke Høiland-Jørgensen
      for suggestions.
      534d0a4b
  11. 22 Jul, 2022 2 commits
  12. 12 Jul, 2022 1 commit
  13. 11 Jul, 2022 4 commits
  14. 10 Jul, 2022 1 commit
  15. 27 Jun, 2022 14 commits