GitLab

Add support for ping & traceroute on Linux (local & ssh)

The whois code allowed to pass HTML from whois output to the resulting webpage
which would allow XSS on the page.

Remove Markup() call from the whois result display routine in order to allow
genshi to escape the whois output.

Add modified ulgcisco.py clone for IOS-XR.
Contributed by Rene Haas, Kurt Bauer.

Fix error in parsing/formatting output of whois command due
to UTF-8 errors.

Add support for ACL that could be associated with a router to restrict
users that are eligible to run commands on the router.

Just add acl=['username1','username2',...] to the configuration
into the parameters of the router.

Fixes exceptions like this:
ERROR: Exception occured while running a command:Traceback (most recent
call last):
  File "/var/www/html/ulg.py", line 498, in commandThreadBody
    session.getRouter().runAsyncCommand(session.getCommand(),session.getParameters(),FakeSessionFile(session))
  File "/var/www/html/ulgmodel.py", line 463, in runAsyncCommand
    return self.runRawCommand(c,outfile)
  File "/var/www/html/ulgbird.py", line 544, in runRawCommand
    l = sf.readline()
  File "/usr/lib/python2.7/socket.py", line 447, in readline
    data = self._sock.recv(self._rbufsize)
timeout: timed out
Signed-off-by: Tomas Hlavacek <tmshlvck@gmail.com>

Fixes exeptions like this (in case whois returns non utf-8 output):
ERROR in CGI: Traceback (most recent call last):
    File "/var/www/html/ulg.py", line 775, in <module>
    handler.whois(**params)
    File "/var/www/html/ulg.py", line 738, in whois
    print self.runULGWhois(key,objtype)
    File "/var/www/html/ulg.py", line 710, in runULGWhois
    res = whois.lookup(key)
    File "/var/www/html/whois.py", line 43, in lookup
    res=res+l.decode('utf-8')
    File "/usr/lib/python2.7/encodings/utf_8.py", line 16, in decode
    return codecs.utf_8_decode(input, errors, True)
UnicodeDecodeError: 'utf8' codec can't decode byte 0xf3 in position 24:
invalid continuation byte
Signed-off-by: Tomas Hlavacek <tmshlvck@gmail.com>

Fixes exceptions like this:
ERROR in CGI: Traceback (most recent call last):
  File "/var/www/html/ulg.py", line 785, in <module>
    handler.index(**params)
  File "/var/www/html/ulg.py", line 722, in index
    print self.renderULGIndex()
UnicodeEncodeError: 'ascii' codec can't encode character u'\xa0' in
position 6254: ordinal not in range(128)
Signed-off-by: Tomas Hlavacek <tmshlvck@gmail.com>

Line break in Cisco parser for show bgp ipv4 unicast summary caused
exception. This happens when the IP address is longer and newline
is inserted to allign columns. And this happens especially when
somebody uses IPv6 peer to transport IPv4 routes.

Fix line breaks using code for IPv6 also in IPv4 handling
code.

Add support for running ulg.py form console. (Do not blindly expect
CGI environment to be always set.)

Fix Cisco parsing of show bgp ipv4/6 unicast sum when the opposite address
family peer is used. I.e. this:

sfc-c7200-gate.ai3.net#show bgp ipv4 unicast summary
<cut>
BGP activity 2403473/2329339 prefixes, 9040108/8863755 paths, scan interval 60 secs

Neighbor      V AS MsgRcvd MsgSent TblVer InQ OutQ Up/Down State/PfxRcd
2001:D30:101:1::11
              4 4717 0     0       0      0   0    never   Active
202.249.24.4  4 4717 0     0       0      0   0    never   Active
202.249.24.36 4 4717 0     0       0      0   0    never   Active

Fixing issue https://github.com/tmshlvck/ulg/issues/10 .

There was a bug in BirdRouterRemote __init__ function in
self.bin_ssh init procedure. The self.bin_ssh was set to None when
bin_birdc parameter was passed. Careless copy-paste artefact perhaps.
Bug has been discovered by Batbileg Sugar batbileg@gemnet.mn .

Tests do not reflect changes in ulgmodel/routers that implemented
sync/async commands.

Fix BirdShowProtocolsCommand and parseBirdShowProtocols not to duplicate
partitioning of the result (for the display as a table). Before this patch
it didn't worked because parseBirdShowProtocols reduced results to i.e.
[100..200] and later decorateResult in BirdShowProtocols reduced the
previously reduced result of length 100 to [100..200] which is empty.

Sort both control tables that ULG obtains automatically form BIRD daemon
on start to construct drop-down select boxes on main page at the first place.
The sorting occures when the tables are read and saved in the internal (persistent) structure.

Graph did failed to display when locally originated prefix was
queried. Now it shows linear graph with an originating AS.

Fix a problem with a false assumption previously made on length of
the first field in output of a command show bgp ipv4/6 unicast neighbor
<IP> received-routes. On newer IOSes it is 5-chars long (because of RPKI flags)
but on older ones it is only 4 chars.

Example:

marge>sh bgp ipv4 uni neigh 91.210.16.3 received-r
BGP table version is 55601421, local router ID is 217.31.48.123
Status codes: s suppressed, d damped, h history, * valid, > best, i - internal,
              r RIB-failure, S Stale, m multipath, b backup-path, f RT-Filter,
              x best-external, a additional-path, c RIB-compressed,
Origin codes: i - IGP, e - EGP, ? - incomplete
RPKI validation codes: V valid, I invalid, N Not found

     Network          Next Hop            Metric LocPrf Weight Path
 *   192.88.99.0      91.210.16.3                            0 25192 i
 *   193.17.47.0      91.210.16.3                            0 25192 20701 i
^^^^^

Thanks to julianeble@yahoo.com.br for pointing it out.

Convert Juniper router handlers and commands to use CommonSelectionParameter
instead of SelectionParameter.

Fix minor typos introduced by previous commit. The bug slightly affected
effectivness of the ULG CGI startup.

Convert BIRD router handlers and commands to use CommonSelectionParameter
instead of SelectionParameter.

Convert Cisco routers and commands to use CommonSelectionParameter
instead of SelectionParameter.

There are problems with page size and page loading speed when there
are more routers with several peers and several BGP related commands
because selection commands multiplicate the peer tables in the resulting
javascript placed into the resulting page. This is not effective enough and
therefore sligh rewrite is needed.

Introduce new type of SelectionParameter - CommonSelectionParameter that
has its ID and it is placed to a JS variable in the beginning of the page
or function that uses the values inside only once. Then construction of the
select boxes uses this variables to feed needed values according to the
ID of the content.

Implement support for multiprotocol ping and traceroute with DNS resolution
for IP addresses. IPv6 has priority in this case, just like in Linux resolver.

Fix typo/wrong statement introduced by the previous patch.

Split commands to groups ALL and BGP. Default are now BGP.
ALL commands can be enabled in Cisco router class in method
_getDefaultCommands().

Add BIRD show route export command decorator to output a table.
Remove default commands show memory and show status from BIRD.

110% font size was too much even for wide screens.

Add busy image to the index page when loading result from the router

Disable debug logging from pexpect (contains passwords!).

Fix active route selection - only best route can be red in the grap.
Other routes (esp. received&used) are nothing special anymore.