HBL: kernel 5.15: LEDs on Turris Omnia not supported

After upgrade of the kernel from version 5.4.203-1-da0ddeb89bb0e25d2a575f62263f6300 to version 5.15.50-1-bbde583666f0d21706f8da40fd4a8532, LEDs stopped working on Omnia. It seems that the driver is missing:

# ls /sys/class/leds/
ath10k-phy0  ath9k-phy1   mmc0::
# rainbow all enable 
Failed to open file: No such file or directory

Reverting to previous kernel fixes the issue.

changed milestone to %Turris OS 6.0

added Omnia label

added To Do label

Thanks for reporting. I will try to take a look at it next week. Driver for LED(s) was reworked and we will be using upstreamed variant.

changed title from HBL: LEDs on Omnia not supported in kernel 5.15.50 to HBL: kernel 5.15: LEDs on Turris Omnia not supported

removed To Do label

assigned to @jschlehofer

added Doing label

Submitted to pending pull request in OpenWrt master to add testing kernel 5.15 in mvebu: https://github.com/rsalvaterra/openwrt/pull/1

In the meantime, backported it to eb8713de

Let's see what it does. :)

Ok, LEDs are there. But since this was enabled in kernel, it requires to bump it for existing installations.

root@turris:/# ls /sys/class/leds/
ath10k-phy0      rgb:indicator-2  rgb:lan-3        rgb:wlan-1
ath9k-phy1       rgb:lan-0        rgb:lan-4        rgb:wlan-2
mmc0::           rgb:lan-1        rgb:power        rgb:wlan-3
rgb:indicator-1  rgb:lan-2        rgb:wan

But rainbow does not support it, yet. Well, when I spoke with Karel some time ago, he told me that rainbow has support for Turris MOX, where it is similar or same, but I haven't look at it.

Hey, thanks! I can confirm that LEDs now do work. I worked around missing rainbow by a small shell script like this:

#!/bin/sh
cd /sys/class/leds/
for n in rgb\:*/multi_intensity;
do
        # default color
        echo 0 255 187 > "$n"
done

echo 255 255 255 > rgb\:wan/multi_intensity
echo 255 255 255 > rgb\:indicator-1/multi_intensity
echo 255 17 0 > rgb\:power/multi_intensity
echo 255 100 0 > rgb\:wlan-1/multi_intensity
echo 100 255 0 > rgb\:wlan-2/multi_intensity
echo 255 0 34 > rgb\:wlan-3/multi_intensity

But it seems that in order to actually change the color, one has to overwrite trigger. So I set up software based triggers for all LEDs in /etc/config/system like this:

config led 'led_lan4'
        option name 'lan4'
        option sysfs 'rgb:lan-4'
        option trigger 'netdev'
        option mode 'link tx rx'
        option dev 'lan4'

removed Doing label

From my side, this could be closed as LEDs were exposed to userspace.

OpenWrt master

• kernel 5.10: https://github.com/openwrt/openwrt/pull/10438
• kernel 5.15: https://github.com/openwrt/openwrt/commit/c2a396fab97867e43518b7e5afb0fba000e20f09 + https://github.com/openwrt/openwrt/commit/163e680e059e67eca542b4b6597910b90fef564c (it was part of https://github.com/openwrt/openwrt/pull/9582 , which adds testing kernel 5.15 )

OpenWrt 22.03

• kernel 5.10: https://github.com/openwrt/openwrt/pull/10433 and https://github.com/openwrt/openwrt/pull/10447

What remains is to solve as pointed out by Ondrej support in the rainbow. That's going to be addressed in packages!846 (closed)

closed