Improve certgen hooks directory manipulation
Follow-up from turris/diagnostics!6 (comment 147685)
- Certgen itself is installed on base system due to
- hooks dir is created and used by
- Hooks dir is possibly optional (you can issue a certificate without a proxy) and Certgen does not have a default value hardcoded
This approach was introduced in turris/turris-os-packages!86
I think that is is just too complicated. That hook dir is not essential and default should be hardcodded.
The point of hook directory is that program itself runs those hooks but won't fail if there is no such directory and or if hook fails. Both users and programs should be sure that when program is run that hook dir is used not just in case hooks are specified. This is at least how I see hooks.
This means that:
- hooks dir can be created by
certgenpackage by putting file
.keepin it or it doesn't have to be but then it should not fail if it is missing
- hooks should always be called from expected location unless option is used to not call hooks (reverse implicit rule against current state)
I know that I was reviewing that code but now when I see it used I see that it is flawed in this case. Hooks should be reliable in some sense and not some adhock thing. I feel like this implementation now has almost no difference over
certgen && for f in /hook/*; $f; donein sense that user chooses what is executed and if he knows little then it breaks a lot potentially.