Data Collection Plugin issueshttps://gitlab.nic.cz/turris/reforis/reforis-data-collection/-/issues2021-11-25T10:58:55+01:00https://gitlab.nic.cz/turris/reforis/reforis-data-collection/-/issues/13Unify sentinel navigation2021-11-25T10:58:55+01:00Martin PrudekUnify sentinel navigationThis is a pure UX issue.
In the [user documentation](https://docs.turris.cz/basics/sentinel/intro/) and other public channels we try to emphasize two main parts of Sentinel: [**threat detection**](https://docs.turris.cz/basics/sentinel/...This is a pure UX issue.
In the [user documentation](https://docs.turris.cz/basics/sentinel/intro/) and other public channels we try to emphasize two main parts of Sentinel: [**threat detection**](https://docs.turris.cz/basics/sentinel/threat-detection/) and the [**dynamic firewall**](https://docs.turris.cz/basics/sentinel/dynfw/). We should reflect this more obviously in reForis.
IMHO there should be three sub-navigation items in Sentinel reForis plugin:
- `Overview`: with the current state, no setting, maybe some statistics & link to sview
- `Threat Detection`: EULA, minipots, haas etc. - mainly settings
- `Dynamic Firewall` - mainly settings + maybe some live changeshttps://gitlab.nic.cz/turris/reforis/reforis-data-collection/-/issues/12Rename to `Sentinel Plugin`2022-01-20T11:44:22+01:00Martin PrudekRename to `Sentinel Plugin`Since we try to get rid of `data-collection` term both in public channels and private documentation it would be nice to rename this plugin to `Sentinel plugin`. It would be more consistent and easier to search for.Since we try to get rid of `data-collection` term both in public channels and private documentation it would be nice to rename this plugin to `Sentinel plugin`. It would be more consistent and easier to search for.https://gitlab.nic.cz/turris/reforis/reforis-data-collection/-/issues/11Add tests for get_eula endpoint2022-01-20T12:42:17+01:00Martin MatějekAdd tests for get_eula endpointTest for `/eula` endpoint is missing for some reason and it would be good to have code coverage for all endpoints.Test for `/eula` endpoint is missing for some reason and it would be good to have code coverage for all endpoints.Data Collection Plugin 0.3.0https://gitlab.nic.cz/turris/reforis/reforis-data-collection/-/issues/8Add warning that EULA is not approved2021-08-12T12:26:08+02:00Karel KociAdd warning that EULA is not approvedIt is not clear directly that user has to approve EULA. I think that adding big warning at the beginning of the data collection page when EULA is not approved would be ideal.
The idea is that user sees red cross on front page of reForis...It is not clear directly that user has to approve EULA. I think that adding big warning at the beginning of the data collection page when EULA is not approved would be ideal.
The idea is that user sees red cross on front page of reForis and investigates what is wrong. He goes to data collection configuration page and there would be info that he has to approve EULA and a button to do so. I think that it is an ideal solution that is not too intrusive in whole reForis but still makes it pretty clear to user that without approving EULA this the data collection is just not going to work.Data Collection Plugin 0.3.0