Diagnostics Plugin issueshttps://gitlab.nic.cz/turris/reforis/reforis-diagnostics/-/issues2019-11-22T14:48:01+01:00https://gitlab.nic.cz/turris/reforis/reforis-diagnostics/-/issues/1Create packaging.2019-11-22T14:48:01+01:00Bogdan BodnarCreate packaging.Bogdan BodnarBogdan Bodnarhttps://gitlab.nic.cz/turris/reforis/reforis-diagnostics/-/issues/2Rewrite to react2019-09-25T14:00:40+02:00Bogdan BodnarRewrite to reacthttps://gitlab.nic.cz/turris/reforis/reforis-diagnostics/-/issues/3Use global alert context2019-11-01T16:39:00+01:00Maciej Lenartowiczmaciej.lenartowicz@nic.czUse global alert contextMaciej Lenartowiczmaciej.lenartowicz@nic.czMaciej Lenartowiczmaciej.lenartowicz@nic.czhttps://gitlab.nic.cz/turris/reforis/reforis-diagnostics/-/issues/4Adjustments after API hooks changes in library2019-11-06T11:53:40+01:00Maciej Lenartowiczmaciej.lenartowicz@nic.czAdjustments after API hooks changes in libraryMaciej Lenartowiczmaciej.lenartowicz@nic.czMaciej Lenartowiczmaciej.lenartowicz@nic.czhttps://gitlab.nic.cz/turris/reforis/reforis-diagnostics/-/issues/5Combine buttons.2020-02-18T10:01:34+01:00Bogdan BodnarCombine buttons.Combine buttons in the reports table in the same way as in custom DNS forwarders.
![image](/uploads/8215f817ddbe0c50b6f79499a90c49d9/image.png)
Combine buttons in the reports table in the same way as in custom DNS forwarders.
![image](/uploads/8215f817ddbe0c50b6f79499a90c49d9/image.png)
https://gitlab.nic.cz/turris/reforis/reforis-diagnostics/-/issues/6Diagnostics now contains number prefix with _2020-06-29T15:37:40+02:00Josef SchlehoferDiagnostics now contains number prefix with _reForis works if the diagnostics modules dont have prefix with number, e.g. "30_uptime.module"
![image](/uploads/d06d44156388ba67862c60c4ddedc826/image.png)
![image](/uploads/27e23261d0652dff99c91a691c8bd0a7/image.png)
But recently dia...reForis works if the diagnostics modules dont have prefix with number, e.g. "30_uptime.module"
![image](/uploads/d06d44156388ba67862c60c4ddedc826/image.png)
![image](/uploads/27e23261d0652dff99c91a691c8bd0a7/image.png)
But recently diagnostics were updated and each module was renamed with number to run them in order. reForis does not count with it.
# How it looks now:
```
root@turris:~# ll /usr/share/diagnostics/modules/
drwxr-xr-x 1 root root 820 May 3 13:36 ./
drwxr-xr-x 1 root root 42 May 3 13:36 ../
-rwxr-xr-x 1 root root 147 Mar 18 17:59 05_serial-number.module*
-rwxr-xr-x 1 root root 1011 Mar 18 17:59 08_os-release.module*
-rwxr-xr-x 1 root root 109 Mar 18 17:59 10_uname.module*
-rwxr-xr-x 1 root root 114 Mar 18 17:59 13_uptime.module*
-rwxr-xr-x 1 root root 472 Mar 18 17:59 15_date.module*
-rwxr-xr-x 1 root root 108 Mar 18 17:59 18_uboot.module*
-rwxr-xr-x 1 root root 260 Mar 18 17:59 20_lshw.module*
-rwxr-xr-x 1 root root 179 Mar 18 17:59 25_filesystems.module*
-rwxr-xr-x 1 root root 183 Mar 18 17:59 27_disk-full.module*
-rwxr-xr-x 1 root root 293 Mar 18 17:59 30_services.module*
-rwxr-xr-x 1 root root 153 Mar 18 17:59 35_processes.module*
-rwxr-xr-x 1 root root 381 Mar 18 17:59 40_network.module*
-rwxr-xr-x 1 root root 1347 Mar 18 17:59 45_dns.module*
-rwxr-xr-x 1 root root 438 Mar 18 17:59 50_firewall.module*
-rwxr-xr-x 1 root root 725 Mar 18 17:59 55_cron.module*
-rwxr-xr-x 1 root root 115 Mar 18 17:59 60_installed.module*
-rwxr-xr-x 1 root root 561 Mar 18 17:59 65_updater.module*
-rwxr-xr-x 1 root root 306 Mar 18 17:59 70_turris-webs.module*
-rwxr-xr-x 1 root root 315 Mar 18 17:59 75_notification.module*
-rwxr-xr-x 1 root root 676 Mar 18 17:59 80_certgen.module*
-rwxr-xr-x 1 root root 154 Mar 18 17:59 85_nikola.module*
-rwxr-xr-x 1 root root 250 Mar 18 17:59 95_messages.module*
-rwxr-xr-x 1 root root 101 Mar 18 17:59 97_dmesg.module*
-rwxr-xr-x 1 root root 602 Mar 18 17:59 module.sh*
```
![image](/uploads/de0423a0e12e9ae5a0da83eacb077225/image.png)
Output:
```
TypeError: "o.data.modules is undefined"
ut http://192.168.1.1/reforis/static/reforis_diagnostics/js/app.min.js:6
dh http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
Jh http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
mj http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
jj http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
Z http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
$i http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
yf http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
unstable_runWithPriority http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
vf http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
yf http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
O http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
eg http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
sh http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
a http://192.168.1.1/reforis/static/reforis_diagnostics/js/app.min.js:6
d http://192.168.1.1/reforis/static/reforis_diagnostics/js/app.min.js:6
_invoke http://192.168.1.1/reforis/static/reforis_diagnostics/js/app.min.js:6
t http://192.168.1.1/reforis/static/reforis_diagnostics/js/app.min.js:6
n http://192.168.1.1/reforis/static/reforis_diagnostics/js/app.min.js:6
d http://192.168.1.1/reforis/static/reforis_diagnostics/js/app.min.js:6
app.min.js:2:2789740
An error ocurred in reForis: "TypeError: o.data.modules is undefined", see details below.
in ut
in component
in Portal
in Route
in RouteWithTitle
in RouteWithSubRoutes
in Switch
in RouteWithSubRoutes
in Switch
in ErrorBoundary
in AlertContextProvider
in Router
in BrowserRouter
in ErrorBoundary
in Main app.min.js:2:4361797
value http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
callback http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
Zf http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
Yf http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
nj http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
unstable_runWithPriority http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
vf http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
ij http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
$i http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
yf http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
unstable_runWithPriority http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
vf http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
yf http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
O http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
eg http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
sh http://192.168.1.1/reforis/static/reforis/js/app.min.js:2
a http://192.168.1.1/reforis/static/reforis_diagnostics/js/app.min.js:6
d http://192.168.1.1/reforis/static/reforis_diagnostics/js/app.min.js:6
_invoke http://192.168.1.1/reforis/static/reforis_diagnostics/js/app.min.js:6
t http://192.168.1.1/reforis/static/reforis_diagnostics/js/app.min.js:6
n http://192.168.1.1/reforis/static/reforis_diagnostics/js/app.min.js:6
d http://192.168.1.1/reforis/static/reforis_diagnostics/js/app.min.js:6
```Turris OS 5.1Aleksandr GumroianAleksandr Gumroianhttps://gitlab.nic.cz/turris/reforis/reforis-diagnostics/-/issues/7Nicer listing of diagnostics module2020-10-16T22:45:43+02:00Martin MatějekNicer listing of diagnostics moduleFollow-up of #6.
With changes in diagnostics modules names (numerical prefix, e.g. 55_cron.module), modules listing now looks like this
![2020-06-29_15.23.33_192.168.1.1_dfd6997abaea](/uploads/889a2b18839b37743f55ec43076d3e88/2020-06-2...Follow-up of #6.
With changes in diagnostics modules names (numerical prefix, e.g. 55_cron.module), modules listing now looks like this
![2020-06-29_15.23.33_192.168.1.1_dfd6997abaea](/uploads/889a2b18839b37743f55ec43076d3e88/2020-06-29_15.23.33_192.168.1.1_dfd6997abaea.png)
But internal ordering of modules is not relevant to users and it could be nice to show it like it was before.
![foo](https://gitlab.labs.nic.cz/turris/reforis/reforis-diagnostics/uploads/27e23261d0652dff99c91a691c8bd0a7/image.png)
It could be resolved:
* in reForis by stripping the prefix only in frontend
* wait for refactoring of diagnostics scripts https://gitlab.labs.nic.cz/turris/diagnostics/-/merge_requests/11
For additional details see this thread https://gitlab.labs.nic.cz/turris/reforis/reforis-diagnostics/issues/6https://gitlab.nic.cz/turris/reforis/reforis-diagnostics/-/issues/8Does it make sense to display diagnostic names?2020-11-27T10:33:53+01:00Karel KociDoes it make sense to display diagnostic names?Looking in to it.. does it makes sense to display diagnostics names? In most cases I think it is more like internal identifier. I think that rephrasing the description to be more precise for that module and using that instead of just nam...Looking in to it.. does it makes sense to display diagnostics names? In most cases I think it is more like internal identifier. I think that rephrasing the description to be more precise for that module and using that instead of just name might make more sense.
If we need unique identifier for support (to tell them list of diagnostics they need) we might prepend nice name of it in description.https://gitlab.nic.cz/turris/reforis/reforis-diagnostics/-/issues/9Add a warning discouraging users from publicly sharing the diagnostics output2023-01-17T18:10:37+01:00Simon BorekAdd a warning discouraging users from publicly sharing the diagnostics outputAs stated in [our documentation](https://docs.turris.cz/basics/support/): "If you have logs, include them. But be aware that __those might contain sensitive data__."
Warning users directly while generating diagnostics output might be be...As stated in [our documentation](https://docs.turris.cz/basics/support/): "If you have logs, include them. But be aware that __those might contain sensitive data__."
Warning users directly while generating diagnostics output might be beneficial - it would probably lead to a much higher chance of a user being aware of the risks at the time of diagnostics file creation.
Related: https://gitlab.nic.cz/turris/user-docs/-/issues/191