GitLab

There was already a cleanup function before that does something
different, so renaming the trap cleanup to avoid overriding it.

Old option still works, it's just obsolete and undocumented.

Make sure we cleanup after ourselves always, even if we can't mount
root.

Try to load generic config file before starting to process argument,
especially -d which specifies different root. This way -d overrides
whatever is in config.

It allows to specify absolute path both with and without colon before it.

It contains uci config and just plain schnapps is confusing naming.

This reverts commit 7ad0ba83.

Certificate backup restore is handled by hook run by schnapps so this
code duplicates that functionality. It should not be there.

It is also wrong as some of the files are hidden (starting with dot)
and this copy omits them. At the same time it prints error if there is
no file in store (this is "fixed" by hiding errors but nooo).

It appears that the script was attempting to allow URLs with a colon
present to pass through unmodified, so someone could specify a custom
directory to found, such as `ssh://host.example.com:/path/on/remote`.
However, the regex check for  URLs was testing for the character
literals :" (colon, double quote) within a protocol-stripped URL (which
it has been at this point int he code, being
`host.example.com:/path/on/remote`). Given how the later `sshfs` line
operates (wraps $FINAL_REMOTE_URL in double quotes), if one was to
specify a URL with `:"`, then it'll never end up working when passed to
sshfs.

This change simplifies the regex match for stripped URLs to just a `.*:`
(colon character somewhere) such that if schapps detects a URL that's
been passed to it like the first example above, it will mount
`/path/on/remote` from `host.example.com`.

Prior to this patch, there was no way of setting `remote.url` to a value
that would allow mounting a specific path over sshfs; one could only
mount `host.example.com:` (the default, which corresponds to the user's
home directory).

Given how the original code was written, it seems like it might have
just been a typo having the double-quote character there.

If there is nothing backed up in certbackup yet, cp in schnapps produces an
ugly error. Let's hide it.