GitLab

This can cause exception later on and prevent updater from execution.

This is major problem as packages were not verified thanks to this
error.

This also adds warning for packages not correctly verified.

Previous commit fixed problem for existing localrepo.lua but introduced
an error for non-existing script.

This fixes some problems with boolean values in uci configs.

There is no reason why plan could not be denied after it was approved or
approved after deny.

This is backport of autorun configuration API from 4.x.

All warning in events are just suppressed because we are planning on
dropping events.c anyway.

I originally was thinking that Lua is doing something nasty like
duplicating original file descriptor for stdout but it turns out that
exec was a culprit. For some reason a call to exec truncates (or at
least removes unfinished line) from stdout. I have no idea why it
behaves that way but adding flush just after callback (before exec)
solves that problem and allows us to correctly use print in callback.
The weird part is that the same thing does not happen with stderr but
non the less I also added flush for it.

This also removes possibly hack to run C/Lua code in subprocess without
providing command. It is overhead but it is more systematic to use
'true' as a command instead of possibly in code unexpected value NULL.

Instead of pretty small constant lets use system level compilation
constant BUFSIZ. Thanks to that we should have buffer exactly matched to
stdio buffer which should somewhat ensure better performance. It is
minor thing but it is better to do it non the less.

This also adds message about termination of subprocess.

I probably had some plan with it but I no longer remember what it was
suppose to been. Instead I just drop it here. It can be reverted later
if needed.

This also correctly sets read field for cookie structure. This has no
effect because we are not reading from it but just to be precise with
our code we set it to know value NULL which means that read is not
available.

This changes timeout from seconds to milliseconds. This is consistent
with previous events design.
Previously used seconds had to be multiplied and milliseconds divided
respectively to hook to current code. This just makes more sense.

We want to do sometimes more than just edit environment for subprocess.
Defining full fledge callback that is called in subprocess is better
alternative. It allows even more changes to be done before execution of
command.

This is code that hooks logging to subprocesses.

These functions are intended as a replacement for events set of
functions. We no longer need parallel script execution and also we should
get rid of embedded busybox.

This replaces way how we define state in pkgupdate. Now we have
predefined enum that we use to identify sate instead of just using
string.

Karel Koci authored Dec 07, 2018 and Karel Koci committed Dec 10, 2018

This makes localrepo.lua work with root_dir to be usable outside of current
root.  It also does not inserts localrepo.lua script unless it exists on
file system. This hides unnecessary warning that confuses users.

Karel Koci authored Dec 07, 2018 and Karel Koci committed Dec 10, 2018

This fixes execution relative to different root.

We do change directory and it makes sense to use absolute path either
way so let's go for it.