passing params for http reqeuest
the code in ripe_utils.py
if is_valid_ipv6_address(ip):
ripe_url = "https://rest.db.ripe.net/search?type-filter=inet6num"
else:
ripe_url = "https://rest.db.ripe.net/search?type-filter=inetnum"
ripe_url = ripe_url + "&source=ripe&query-string="
try:
r = requests.get(ripe_url + ip, headers={"Accept": "application/json"}, timeout=5)
is working but it's ugly. It should follow the https://requests.readthedocs.io/en/master/user/quickstart/#passing-parameters-in-urls
Proposed change is
ripe_url = "https://rest.db.ripe.net/search
ripe_params = {
'source': 'ripe',
'query-string': ip,
'type-filter': 'inetnum'
}
if is_valid_ipv6_address(ip):
ripe_params['type-filter'] = 'inet6num'
try:
r = requests.get(ripe_url, params=ripe_params, headers={"Accept": "application/json"}, timeout=5)