Skip to content
Snippets Groups Projects
Commit 13a040d8 authored by Jan Včelák's avatar Jan Včelák :rocket:
Browse files

review: fix comments

parent 824457af
Branches
Tags
No related merge requests found
...@@ -121,7 +121,7 @@ typedef struct algorithm_usage { ...@@ -121,7 +121,7 @@ typedef struct algorithm_usage {
} algorithm_usage_t; } algorithm_usage_t;
/*! /*!
* \brief Enable Single-Type Signing Scheme, check if the keys are used correctly. * \brief Check correct key usage, enable Single-Type Signing Scheme if needed.
* *
* Each record in the zone has to be signed at least by one key for each * Each record in the zone has to be signed at least by one key for each
* algorithm published in the DNSKEY RR set in the zone apex. * algorithm published in the DNSKEY RR set in the zone apex.
...@@ -157,6 +157,7 @@ static int prepare_and_check_keys(const knot_dname_t *zone_name, ...@@ -157,6 +157,7 @@ static int prepare_and_check_keys(const knot_dname_t *zone_name,
for (int i = 0; i < max_algorithms; i++) { for (int i = 0; i < max_algorithms; i++) {
algorithm_usage_t *u = &usage[i]; algorithm_usage_t *u = &usage[i];
// either KSK or ZSK keys are available
if ((u->ksk_count == 0) != (u->zsk_count == 0)) { if ((u->ksk_count == 0) != (u->zsk_count == 0)) {
u->is_stss = true; u->is_stss = true;
log_zone_info(zone_name, "DNSSEC, Single-Type Signing " log_zone_info(zone_name, "DNSSEC, Single-Type Signing "
...@@ -205,8 +206,6 @@ static int prepare_and_check_keys(const knot_dname_t *zone_name, ...@@ -205,8 +206,6 @@ static int prepare_and_check_keys(const knot_dname_t *zone_name,
/*! /*!
* \brief Load zone keys from a key directory. * \brief Load zone keys from a key directory.
*
* \todo Maybe use dynamic list instead of fixed size array.
*/ */
int knot_load_zone_keys(const char *keydir_name, const knot_dname_t *zone_name, int knot_load_zone_keys(const char *keydir_name, const knot_dname_t *zone_name,
bool nsec3_enabled, knot_zone_keys_t *keys) bool nsec3_enabled, knot_zone_keys_t *keys)
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment