eliminate in-progress comments

src/knot/events/handlers.h

@@ -16,13 +16,9 @@
 
 #pragma once
 
-// XXX: Consider forward declaration of conf_t a zone_t.
 #include "knot/conf/conf.h"
 #include "knot/zone/zone.h"
 
-// XXX: logging workaround
-#include "knot/nameserver/log.h"
-
 /*! \brief Loads or reloads potentially changed zone. */
 int event_load(conf_t *conf, zone_t *zone);
 /*! \brief Sends a SOA query to master. */

src/knot/events/handlers/refresh.c

@@ -28,10 +28,6 @@
 #define BOOTSTRAP_RETRY (30) /*!< Interval between AXFR bootstrap retries. */
 #define BOOTSTRAP_MAXTIME (24*60*60) /*!< Maximum AXFR retry cap of 24 hours. */
 
-#include "knot/nameserver/log.h"
-
-// XXX: duplicate message
-/* @note Module specific, expects some variables set. */
 #define LOG_TRANSFER(severity, pkt_type, msg, ...) \
 	if (pkt_type == KNOT_QUERY_AXFR) { \
 		ZONE_QUERY_LOG(severity, zone, master, "AXFR, incoming", msg, ##__VA_ARGS__); \

src/knot/query/query.c

@@ -17,8 +17,6 @@
 #include <stdint.h>
 #include <string.h>
 
-// XXX: mempattern + mempool?
-
 #include "contrib/mempattern.h"
 #include "contrib/ucw/mempool.h"
 #include "contrib/wire.h"
@@ -30,7 +28,7 @@
 #include "libknot/packet/pkt.h"
 #include "libknot/yparser/yptrafo.h"
 
-// XXX: temporary location of handlers
+// event handlers:
 #include "knot/nameserver/axfr.h"
 #include "knot/nameserver/internet.h"
 #include "knot/nameserver/ixfr.h"
@@ -129,7 +127,6 @@ static int process_answer(knot_layer_t *ctx, knot_pkt_t *pkt)
 	/* Verify incoming packet. */
 	int ret = tsig_verify_packet(&data->param->tsig_ctx, pkt);
 	if (ret != KNOT_EOK) {
-		// XXX: "response" operation sounds like placeholder
 		NS_PROC_LOG(LOG_WARNING, data->param->zone->name, data->param->remote,
 		            "response", "denied (%s)", knot_strerror(ret));
 		return KNOT_STATE_FAIL;

src/knot/query/query.h

@@ -20,6 +20,7 @@
 
 #include "knot/conf/conf.h"
 #include "knot/nameserver/tsig_ctx.h"
+#include "knot/nameserver/log.h"
 #include "knot/query/layer.h"
 #include "knot/zone/zone.h"
 
@@ -54,6 +55,5 @@ struct answer_data {
 
 int zone_query_execute(conf_t *conf, zone_t *zone, uint16_t pkt_type, const conf_remote_t *remote);
 
-#include "knot/nameserver/log.h"
 #define ZONE_QUERY_LOG(priority, zone, remote, operation, msg, ...) \
 	NS_PROC_LOG(priority, zone->name, &(remote)->addr, operation, msg, ##__VA_ARGS__)