util: remove old RNG and strlcpy functions

src/libknot/util/utils.c

@@ -56,59 +56,6 @@ knot_lookup_table_t *knot_lookup_by_id(knot_lookup_table_t *table,
 
 /*----------------------------------------------------------------------------*/
 
-size_t knot_strlcpy(char *dst, const char *src, size_t size)
-{
-	char *d = dst;
-	const char *s = src;
-	size_t n = size;
-
-	/* Copy as many bytes as will fit */
-	if (n != 0 && --n != 0) {
-		do {
-			if ((*d++ = *s++) == 0) {
-				break;
-			}
-		} while (--n != 0);
-	}
-
-	/* Not enough room in dst, add NUL and traverse rest of src */
-	if (n == 0) {
-		if (size != 0) {
-			*d = '\0';        /* NUL-terminate dst */
-		}
-		while (*s++)
-			;
-	}
-
-	return(s - src - 1);        /* count does not include NUL */
-}
-
-/*! \brief TLS key for rand seed. */
-static pthread_key_t _qr_key;
-static pthread_once_t _qr_once = PTHREAD_ONCE_INIT;
-
-/*! \brief TLS key initializer. */
-static void _qr_init()
-{
-	(void) pthread_key_create(&_qr_key, NULL);
-	(void) pthread_setspecific(_qr_key, (void*)time(0));
-}
-
-size_t knot_quick_rand()
-{
-	(void) pthread_once(&_qr_once, _qr_init);
-	size_t x = (size_t)pthread_getspecific(_qr_key);
-
-	/* Numerical Recipes in C.
-	 * The Art of Scientific Computing, 2nd Edition,
-	 * 1992, ISBN 0-521-43108-5.
-	 * Page 284.
-	 */
-	x = 1664525L * x + 1013904223L;
-	(void) pthread_setspecific(_qr_key, (void*)x);
-	return x;
-}
-
 uint16_t knot_random_id()
 {
 	return (uint16_t)(tls_rand() * ((uint16_t)~0));
@@ -124,4 +71,3 @@ struct flock* knot_file_lock(short type, short whence)
 	ret.l_pid = getpid();
 	return &ret;
 }
-

src/libknot/util/utils.h

@@ -68,19 +68,6 @@ knot_lookup_table_t *knot_lookup_by_name(knot_lookup_table_t *table,
 knot_lookup_table_t *knot_lookup_by_id(knot_lookup_table_t *table,
                                            int id);
 
-/*!
- * \brief Strlcpy - safe string copy function, based on FreeBSD implementation.
- *
- * http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libc/string/
- *
- * \param dst Destination string.
- * \param src Source string.
- * \param size How many characters to copy - 1.
- *
- * \return strlen(src), if retval >= siz, truncation occurred.
- */
-size_t knot_strlcpy(char *dst, const char *src, size_t size);
-
 /*
  * Writing / reading arbitrary data to / from wireformat.
  */
@@ -189,14 +176,8 @@ static inline void knot_wire_write_u64(uint8_t *pos, uint64_t data)
 }
 
 /*!
- * \brief Linear congruential generator.
- *
- * Simple pseudorandom generator for general purpose.
- * \warning Do not use for cryptography.
- * \return Random number <0, (size_t)~0>
+ * \brief Get random packet id.
  */
-size_t knot_quick_rand();
-
 uint16_t knot_random_id();
 
 /*!
@@ -212,4 +193,3 @@ struct flock* knot_file_lock(short type, short whence);
 #endif /* _KNOT_UTILS_H_ */
 
 /*! @} */
-