Skip to content
Snippets Groups Projects
Commit f5d19347 authored by Jan Kadlec's avatar Jan Kadlec
Browse files

Do not allow out-of-zone data for DDNS.

- RFC 2136 states that the server should return the 'NOTZONE' error
  code, which it is correcly doing now, so there's no need to change it.
- Minor change only, since the actual check is somewhere before this code
  executes, but I've left the new_node functions as it was, since we
  may wish to allow some malformations later.

Refs #102
parent 22e6a664
Branches
Tags
No related merge requests found
...@@ -1555,15 +1555,7 @@ static int knot_ddns_process_add(const knot_rrset_t *rr, ...@@ -1555,15 +1555,7 @@ static int knot_ddns_process_add(const knot_rrset_t *rr,
&node, knot_ddns_rr_is_nsec3(rr)); &node, knot_ddns_rr_is_nsec3(rr));
if (ret != KNOT_EOK) { if (ret != KNOT_EOK) {
dbg_xfrin("Failed to create new node in zone.\n"); dbg_xfrin("Failed to create new node in zone.\n");
ret = xfrin_handle_error(zone->apex ? zone->apex->owner : NULL, return ret;
rr->owner, ret);
if (ret == KNOT_EOK) {
// Recoverable error, continue
return KNOT_EOK;
} else {
// Fatal error, rollback update
return ret;
}
} }
} }
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment