Unify rcode mnemonics array

refs #2137

src/utils/common/exec.c

@@ -157,7 +157,7 @@ static knot_lookup_table_t opcodes[] = {
 	{ 0, NULL }
 };
 
-static knot_lookup_table_t rcodes[] = {
+knot_lookup_table_t rcodes[] = {
 	{ KNOT_RCODE_NOERROR,  "NOERROR" },
 	{ KNOT_RCODE_FORMERR,  "FORMERR" },
 	{ KNOT_RCODE_SERVFAIL, "SERVFAIL" },

src/utils/common/exec.h

@@ -30,6 +30,8 @@
 #include "libknot/packet/packet.h"	// knot_packet_t
 #include "utils/common/params.h"	// params_t
 
+knot_lookup_table_t rcodes[];
+
 knot_packet_t* create_empty_packet(knot_packet_prealloc_type_t t, int max_size);
 void process_query(const params_t *params, const query_t *query);
 void print_packet(const format_t      format,

src/utils/nsupdate/nsupdate_exec.c

@@ -132,21 +132,6 @@ enum {
 	PARSE_NAMEONLY  = 1 << 1, /* Parse only name. */
 };
 
-/* RCODE error table. */
-const char *rc_errtable[] = {
-        "NOERROR",
-        "FORMERR",
-        "SERVFAIL",
-        "NXDOMAIN",
-        "NOTIMPL",
-        "REFUSED",
-        "YXDOMAIN",
-        "YXRRSET",
-        "NXRRSET",
-        "NOTAUTH",
-        "NOTZONE"
-};
-
 static inline const char* skipspace(const char *lp) {
 	while (isspace(*lp)) ++lp; return lp;
 }
@@ -847,11 +832,11 @@ int cmd_send(const char* lp, params_t *params)
 	}
 	
 	/* Check return code. */
+	knot_lookup_table_t *rcode;
 	int rc = knot_packet_rcode(npar->resp);
 	DBG("%s: received rcode=%d\n", __func__, rc);
-	if (rc > KNOT_RCODE_NOERROR && rc <= KNOT_RCODE_NOTZONE) {
-		ERR("update failed: %s\n", rc_errtable[rc]);
-	}
+	rcode = knot_lookup_by_id(rcodes, rc);
+	ERR("update failed: %s\n", rcode->name);
 	
 	/*! \todo Should we check TC bit? */