Refusing to answer queries without RD bit makes it harder
to read what data is present in resolver's cache.

Somehow I didn't notice this field when adding ::add_selected.
We probably never put anything into answer's ADDITIONAL,
so noone's noticed a problem until now.

Tomas Krizek authored 5 years ago and Vladimír Čunát committed 5 years ago

The code incorrectly assumes GNUTLS_E_AGAIN can only be caused
by reading the entire libuv buffer. Legitime causes of GNUTLS_E_AGAIN
wouldn't be processed correctly. These could be caused by a new
session ticket sent by the server.

Fixes #489

Vladimír Čunát authored 5 years ago and Petr Špaček committed 5 years ago

- don't print a line in every checking cycle
- don't exit when cache isn't found
- reduce recommended interval to 10s (compromise)
- don't increase cache size (but keep the code for now)

This reverts commit c3a754dd, reversing
changes made to 06d01bf0.

I've have accidentally merged incorrect branch, let's try to fix that by
reverting incorrect version of GC and merging the correct one.

Vladimír Čunát authored 5 years ago and Petr Špaček committed 5 years ago

Don't stash a packet with mismatching QNAME+QTYPE.
When receiving an NXDOMAIN or NODATA packet in an insecure zone,
it would get cached with KR_RANK_INSECURE regardless of mismatch
in QNAME.  If the 0x20 pattern was preserved in the fake QNAME,
such packet would then be used to answer queries with matching QNAME,
even if there's no proof that this QNAME is insecure.

Also the log now uses the same format query UID format as elsewhere.

name of SOA record must be "."

Fixes: #474

Vladimír Čunát authored 5 years ago and Petr Špaček committed 5 years ago

- don't print a line in every checking cycle
- don't exit when cache isn't found
- reduce recommended interval to 10s (compromise)
- don't increase cache size (but keep the code for now)

Petr Špaček authored 5 years ago and Vladimír Čunát committed 5 years ago

Regression in 19ef77d1 (unreleased): Default value IN for qclass
parameter was missing.  Also consistently use A as default for qtype.

Thanks to changes in this branch the functions are called with correctly
typed parameters already, so these weird casts can be deleted.

Theoretically a lua module could have used them, but I see no motivation
for that, as they have much more convenient ways inside lua.

... when called with bad parameters, and restructure the code a bit.
Note: uv_timer_start() is documented to be OK on active timers.

They're a bit more expensive, but we won't want lots of events anyway,
so I decided to do a simple conversion.

We're very much depending on LuaJIT, for years already.
The removed stuff seems very unlikely to be useful in any LuaJIT
in forseeable future.  The Lua language is effectively forked.

... without light userdata and yet it should be efficient.
Also with checkout layer, but I have no nice way of testing that one.

In particular, throw errors when used in weird ways,
instead of the usual "return nil" semantics.
That might be surprising to some lua users.