Using 443 as the default port presents too many packaging challenges.
DoH requires configuration to be useful anyway, so users are free to
override this value as they see fit.

Avoid unnecessary and confusing restarts when starting kresd
fails to start, e.g. due to incorrect configuration. Attempt
to restart on crashes only.

Discourage use of kresd.service in distros using systemd-sysv-generator.

Unify the drop-in files for manual activation and systemd compatibility,
since it is not recommended to use manual activation if socket
activation is supported.

Also add --forks=1 to the command, otherwise the service attempts to
start in interactive mode.

To avoid using /etc/default/kresd, provide the needed arguments directly
in the ExecStart= in the kresd@.service.

The kresd.service meta-service could be confusing for users and provides
no extra functionality. The system-kresd.slice can be used to restart or
stop all running instances.

Distributions shipping with /etc/init.d/kresd should symlink the
kresd.service to /dev/null to prevent systemd-sysv-generator from
creating this service.

Daniel Kahn Gillmor authored 7 years ago and Tomas Krizek committed 7 years ago

ReusePort=true isn't needed because there is a single listening
socket, which is shared across all instances.  Nothing needs to reuse
the port.

Daniel Kahn Gillmor authored 7 years ago and Tomas Krizek committed 7 years ago

If the adminstrator of a non-socket-activated kresd installation
doesn't clear Sockets=, then they will also inherit sockets from the
process manager, which doesn't make sense.  Help them avoid that
situation.

Daniel Kahn Gillmor authored 7 years ago and Tomas Krizek committed 7 years ago

We want these files to be as simple as possible; there's no reason to
include arguments that are already the default.

--forks=1 is the default.

and the unit files indicate WorkingDirectory already.

Daniel Kahn Gillmor authored 7 years ago and Tomas Krizek committed 7 years ago

If we only install the files in this directory, there is no need for
the preset, because kresd@1.service is not enabled by default anyway.

Simplify, simplify :)

Daniel Kahn Gillmor authored 7 years ago and Tomas Krizek committed 7 years ago

Administrators using bash tab completion with the full completion
utilities enabled will be able to tab-complete instantiated services.
shipping symlinks gets confused during tarball generation, and during
package installation, so it's safer and cleaner to just ship the
regular unit files.

Daniel Kahn Gillmor authored 7 years ago and Tomas Krizek committed 7 years ago

Please see discussion at:
https://github.com/systemd/systemd/issues/8096

The new approach is:

 * non-templated kresd.socket and kresd-tls.socket, for the
   public-facing listening ports.  They know to invoke kresd@1.service
   if they're socket-activated.

 * kresd@.service *is* templated, to allow the admin to add more
   concurrent runners with:

      systemctl enable kresd@2.service

 * kresd-control@.socket is still templated, since each daemon has a
   separately-addressable different control port.

 * non-templated kresd.service is a dummy meta-service.  it is in the
   same slice as kresd@.service, and all the kresd@.service instances
   are PartOf= it, so you should be able to stop and restart all
   services together.  On systems like debian that ship
   /etc/init.d/kres, this also avoids having systemd-sysv-generator
   create a kresd.service based on the initscript.

 * no templated instances are explicitly instantiated during initial
   ship, but kresd@1.service should be socket-activated cleanly

Gbp-Pq: Name 0010-More-systemd-service-management-cleanup.patch