Skip to content
Snippets Groups Projects

networking: use proper wrapper around ip command

Merged Štěpán Balážik requested to merge pyroute_networking into master
All threads resolved!

Previously a subprocess calls were used to invoke the ip command. This is now replaced with a proper NetLink API calls wrapped in pyroute2 module.

Fixes #48 (closed).

Edited by Štěpán Balážik

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Štěpán Balážik

      This is awesome, I like it! On my system old libswrap version took 35 seconds to execute all tests, new version based on namespace + subprocess took 45 seconds and this takes 40-41 seconds.

      Besides speed improvement I very much like getting rid of parsing error messages, I do not want to image what would happen with non-english locale etc.

  • TODO:

    • document new depedency
    Edited by Štěpán Balážik
  • assigned to @sbalazik

  • added 1 commit

    • f58e5959 - networking: use proper wrapper around ip command

    Compare with previous version

  • added 4 commits

    Compare with previous version

  • added 1 commit

    • ab332f3e - docs: document new `pyroute2` dependency

    Compare with previous version

  • Petr Špaček resolved all threads

    resolved all threads

  • If you are done please un-assign the MR so I know I can merge it.

  • merged

  • Petr Špaček mentioned in commit ebb6d356

    mentioned in commit ebb6d356

  • Please register or sign in to reply
    Loading