fix leaking sockets

The old code worked most of the time thanks to garbage collector, but obviously it was unreliable/a coincidence.

@sbalazik Please have a look if this change removes need to retry socket binding in pydnstest/testserver.py around line for i in range(self.RETRIES_ON_BIND):.

If it is the case please add another commit which removes this workaround.

Binding to newly created socket still fails occasionally even on this branch. So I suggest merging this and leaving the workaround as is.

Can you describe how you test that? I'm curious.

added 1 commit

• 92a4bfb0 - don't retry socket binding

Compare with previous version

I just removed the retry logic from testserver.py (basically reverted it to what it was before the networking rewrite) and it fails on the bind on my machine again. See the commit above.

Same behavior can be seen in the corresponding pipeline https://gitlab.nic.cz/knot/deckard/pipelines/66133.

Hmm, I do not understand what is happening here so I'm postponing this problem to #52 .

added 1 commit

• 71289c9e - fix flake8 nitpick

Compare with previous version

enabled an automatic merge when the pipeline for 71289c9e succeeds

merged

mentioned in commit a8b5adda