fix leaking sockets
The old code worked most of the time thanks to garbage collector, but obviously it was unreliable/a coincidence.
Merge request reports
Activity
@sbalazik Please have a look if this change removes need to retry socket binding in
pydnstest/testserver.py
around linefor i in range(self.RETRIES_ON_BIND):
.If it is the case please add another commit which removes this workaround.
I just removed the retry logic from
testserver.py
(basically reverted it to what it was before the networking rewrite) and it fails on the bind on my machine again. See the commit above.Same behavior can be seen in the corresponding pipeline https://gitlab.nic.cz/knot/deckard/pipelines/66133.
Edited by Štěpán BalážikHmm, I do not understand what is happening here so I'm postponing this problem to #52 .
enabled an automatic merge when the pipeline for 71289c9e succeeds
mentioned in commit a8b5adda