Fixed leaks in zoneparser.

Fixes #823 @3h

samples/example.com.zone

@@ -20,8 +20,6 @@ mail          A     10.0.0.3              ; ip address for "mail.example.com", a
 sub	NS	ns.sub.example.com.	; delegation
 ns.sub	A	10.1.0.1	; glue
 
-ns.sub TYPE23444 \# abcedfg
-
 a	A	10.0.0.4
 *.a	A	10.0.0.5
 

src/zcompile/zcompile.c

@@ -506,6 +506,7 @@ uint16_t * zparser_conv_hex(const char *hex, size_t len)
 			++t;
 		}
 	}
+
 	return r;
 }
 
@@ -1392,6 +1393,7 @@ void parse_unknown_rdata(uint16_t type, uint16_t *wireformat)
 	                       rdata_count);
 	if (rdata_count < 0) {
 		fprintf(stderr, "bad unknown RDATA\n");
+		/*!< \todo leaks */
 		return;
 	}
 
@@ -1403,8 +1405,9 @@ void parse_unknown_rdata(uint16_t type, uint16_t *wireformat)
 			zadd_rdata_wireformat((uint16_t *)items[i].raw_data);
 		}
 	}
-
 	free(items);
+	/* Free wireformat */
+	free(wireformat);
 }
 
 /*

src/zcompile/zlexer.l

@@ -458,10 +458,12 @@ parse_token(int token, char *yytext, enum lexer_state *lexer_state)
 	if (strcmp(yytext, ".") == 0) {
 		free(str);
 		yylval.data.str=".";
-	}
-	else if (strcmp(yytext, "@") == 0) {
+	} else if (strcmp(yytext, "@") == 0) {
 		free(str);
 		yylval.data.str="@";
+	} else if (strcmp(yytext, "\\#") == 0) {
+		free(str);
+		yylval.data.str="\\#";
 	}
 
 	LEXOUT(("%d[%s] ", token, yytext));

src/zcompile/zparser.y

@@ -158,11 +158,6 @@ line:	NL
 //void *tmp1 = parser->current_rrset->owner;
 //void *tmp2 = parser->current_rrset->owner->name;
 
-		if (save_dnames_in_table(parser->dname_table,
-					 parser->current_rrset) != 0) {
-					 /* \todo */
-		}
-
 //if (tmp1 != parser->current_rrset->owner ||
 //tmp2 != parser->current_rrset->owner->name) {
 //printf("before: %p %p\n", tmp1, tmp2);
@@ -170,6 +165,11 @@ line:	NL
 //printf("%s\n", dnslib_dname_to_str(parser->current_rrset->owner));
 //}
 
+		if (save_dnames_in_table(parser->dname_table,
+						 parser->current_rrset) != 0) {
+						 /* \todo */
+		}
+
 		assert(parser->current_rrset->owner != NULL);
 //		printf("after cat: %s (%p)\n", dnslib_dname_to_str(parser->current_rrset->owner), parser->current_rrset->owner->name);
 
@@ -183,6 +183,19 @@ line:	NL
 				"owner: %s reason: %s\n", tmp_dname_str,
 				error_to_str(knot_zcompile_error_msgs, ret));
 			free(tmp_dname_str);
+			/* Free rdata, it will not be added and hence cannot be
+			 * freed with rest of the zone */
+			dnslib_rdata_deep_free(&tmp_rdata,
+			                       parser->current_rrset->type,
+					       0);
+
+			/* If the owner is not already in the table, free it. */
+			if (dnslib_dname_table_find_dname(parser->dname_table,
+				parser->current_rrset->owner) == NULL) {
+				dnslib_dname_free(&parser->
+				                  current_rrset->owner);
+			}
+
 			if (ret == KNOT_ZCOMPILE_EBADSOA) {
 				/*!< \todo this will crash! */
 				dnslib_rdata_free(&tmp_rdata);
@@ -192,8 +205,19 @@ line:	NL
 						      1);
 				YYABORT;
 			}
+		} else { ;
+		/* In case of adding failure, dnames have to be processed
+		 * AFTER they've been added, so that we won't pollute the table
+		 * with freed dnames */
+
+		/*!< \todo Current implementation might introduce redundant
+		 * dnames to the table (from rdata section, which was processed
+		 * and its dnames added to the table, but then was not acutally
+		 * added to the zone.
+		 */
+
 		}
-	    }
+	}
 
 //	printf("Current rrset name: %p (%s)\n", parser->current_rrset->owner->name,
 //	dnslib_dname_to_str(parser->current_rrset->owner));
@@ -225,6 +249,8 @@ ttl_directive:	DOLLAR_TTL sp STR trail
 		parser->default_ttl = DEFAULT_TTL;
 		parser->error_occurred = 0;
 	}
+
+	free($3.str);
     }
     ;
 
@@ -1354,12 +1380,13 @@ rdata_unknown:	URR sp STR sp str_sp_seq trail
     {
 	    /* $2 is the number of octects, currently ignored */
 	    $$ = zparser_conv_hex($5.str, $5.len);
-
-			free($5.str);
+	    free($5.str);
+	    free($3.str);
     }
     |	URR sp STR trail
     {
 	    $$ = zparser_conv_hex("", 0);
+	    free($3.str);
     }
     |	URR error NL
     {
@@ -1539,5 +1566,6 @@ nsec3_add_params(const char* hashalgo_str, const char* flag_str,
 							      salt_len));
 	else
 		zadd_rdata_wireformat(alloc_rdata_init("", 1));
+
 }
 #endif /* NSEC3 */