Use hidden visibility only for shared libraries

configure.ac

@@ -399,9 +399,8 @@ AC_LINK_IFELSE([AC_LANG_PROGRAM([[#include <pthread_np.h>]], [[cpuset_t set; CPU
 AC_LINK_IFELSE([AC_LANG_PROGRAM([[#include <sched.h>]], [[cpuset_t* set = cpuset_create(); cpuset_destroy(set);]])],
 [AC_DEFINE(HAVE_CPUSET_NETBSD, 1, [Define if cpuset_t and cpuset(3) exists.])])
 
-# Hide all exported symbols by default
+# Prepare CFLAG_VISIBILITY to be used where needed
 gl_VISIBILITY()
-CPPFLAGS="$CPPFLAGS $CFLAG_VISIBILITY"
 
 # Add code coverage macro
 AX_CODE_COVERAGE

src/Makefile.am

@@ -152,7 +152,7 @@ libknot_internal_la_SOURCES = 			\
 libknot_internal_la_CPPFLAGS = $(AM_CPPFLAGS) $(lmdb_CFLAGS)
 libknot_internal_la_CFLAGS = $(AM_CFLAGS)
 
-libknot_la_CPPFLAGS = $(AM_CPPFLAGS) $(lmdb_CFLAGS)
+libknot_la_CPPFLAGS = $(AM_CPPFLAGS) $(CFLAG_VISIBILITY) $(lmdb_CFLAGS)
 libknot_la_CFLAGS = $(AM_CFLAGS)
 libknot_la_LDFLAGS = $(AM_LDFLAGS) $(libknot_VERSION_INFO) $(lmdb_LIBS)
 libknot_la_LIBADD  = dnssec/libdnssec.la libknot-internal.la
@@ -335,9 +335,10 @@ libknotd_la_CPPFLAGS  = $(AM_CPPFLAGS) $(systemd_CFLAGS) $(liburcu_CFLAGS)
 libknotd_la_LDFLAGS = $(AM_LDFLAGS) $(systemd_LIBS) $(liburcu_LIBS)
 libknotd_la_LIBADD = libknot.la libknot-yparser.la libknot-internal.la zscanner/libzscanner.la $(liburcu_LIBS)
 
-knotd_CPPFLAGS = $(AM_CPPFLAGS) $(liburcu_CFLAGS)
-knotd_LDADD = libknotd.la libknot.la $(liburcu_LIBS)
+knotd_CPPFLAGS = $(AM_CPPFLAGS)
+knotd_LDADD = libknotd.la libknot.la
 knotc_LDADD = libknotd.la libknot.la
+knot1to2_LDADD = libknotd.la libknot.la
 
 ####################################
 # Optional Knot DNS Daemon modules #

src/dnssec/Makefile.am

@@ -42,7 +42,7 @@ libshared_la_SOURCES = \
 
 libdnssec_la_CPPFLAGS = \
 	$(AM_CPPFLAGS) \
-	-fvisibility=hidden
+	$(CFLAG_VISIBILITY)
 
 libdnssec_la_LDFLAGS = \
 	$(gnutls_LIBS) \

src/zscanner/Makefile.am

@@ -33,6 +33,7 @@ libzscanner_la_SOURCES =		\
 nodist_libzscanner_la_SOURCES =		\
 	scanner.c
 
+libzscanner_la_CPPFLAGS = $(AM_CPPFLAGS) $(CFLAG_VISIBILITY)
 libzscanner_la_CFLAGS = $(CODE_COVERAGE_CFLAGS)
 libzscanner_la_LDFLAGS =		\
 	$(CODE_COVERAGE_LDFLAGS)	\

tests/Makefile.am

@@ -4,13 +4,11 @@ AM_CPPFLAGS = \
 	-I$(top_srcdir)/src \
 	-I$(top_srcdir)/src/dnssec/lib
 
-AM_LDFLAGS = \
-	$(libcrypto_LIBS)
-
 LDADD = \
 	$(top_builddir)/libtap/libtap.a \
 	$(top_builddir)/src/libknot.la \
-	$(top_builddir)/src/libknotd.la
+	$(top_builddir)/src/libknotd.la \
+	$(libcrypto_LIBS)
 
 check_PROGRAMS = \
 	acl				\