tests-extra: fix node type conflict with CNAME/DNAME during generation"

tests-extra/tools/zone_generate.py

@@ -139,7 +139,7 @@ def rnd_dname(enable_sub = 1):
 def rnd_dnl(enable_sub = 1):
     dn = rnd_dname(enable_sub)
     fqdn = g_fqdn(dn)
-    while fqdn in CNAME_EXIST:
+    while fqdn.lower() in (name.lower() for name in CNAME_EXIST):
         dn = rnd_dname(enable_sub)
         fqdn = g_fqdn(dn)
     NAME_EXIST.add(fqdn)
@@ -245,7 +245,8 @@ def g_dname(rt):
     # Ensure unique owners for CNAME/DNAME
     dn = rnd_dname()
     fqdn = g_fqdn(dn)
-    while (fqdn in CNAME_EXIST) or (fqdn in NAME_EXIST):
+    while (fqdn.lower() in (name.lower() for name in CNAME_EXIST)) or \
+          (fqdn in NAME_EXIST):
         dn = rnd_dname()
         fqdn = g_fqdn(dn)
     CNAME_EXIST.add(fqdn)

[Ghost User]

This is still not correct. You should convert name to lowercase on every {NAME_EXIST, CNAME_EXIST}.add() and convert every looked-up name to lowercase, not just CNAMEs. 43137b5b