Skip to content
Snippets Groups Projects
Commit b5b646fd authored by Robert Edmonds's avatar Robert Edmonds
Browse files

kdig: compare wire format QNAMEs

This commit updates kdig's check_reply_question() function so that it
compares the original wire format QNAME of the query against the
original wire format QNAME of the response. Using knot_pkt_qname()
instead of knot_pkt_wire_qname() only compares the downcased QNAMEs.

RFC 5452:

    4.2.  Matching the Question Section

       DNS packets, both queries and responses, contain a question section.
       Incoming responses should be verified to have a question section that
       is equivalent to that of the outgoing query.

I think "equivalent" here means that the case of the QNAMEs should be
compared too.
parent 8d8ce512
Branches
Tags
Pipeline #93020 passed with warnings with stages
in 5 minutes and 16 seconds
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment