Petr Špaček authored 8 years ago and Daniel Salzman committed 8 years ago

Throwing away unexpected retun codes makes debugging harder.
TAP function is_int can nicely log mismatches which makes debugging easier.

To make our lives easier I replaced all ok(ret == KNOT_E???) checks with
is_int() calls. It was done using following command
+ manual review and reverts in libknot/test_control.c.

$ find -name '*.c' | xargs sed -i 's#ok(ret == \(KNOT_E[0-9A-Z_]\+\),#is_int(\1, ret,#'

Maximum TSIG wire size is reached only in empty error response with BADTIME.
In most cases reservation of such a size led to early truncation.

Petr Špaček authored 8 years ago and Daniel Salzman committed 8 years ago

The test might fail on 32 architectures with error message claiming
"not enough memory". This is probably caused by address space
fragmentation.

To avoid this problem we are using pretty low values for database size
in the test (which contains little data anyway).

...except OSX where the compile option is not available

eliminated compile warnings: deprecated readdir_r -> readdir; Wuninitialized few variables on make check

Vladimír Čunát authored 8 years ago and Daniel Salzman committed 8 years ago

Squashed commit. For description see the MR:
https://gitlab.labs.nic.cz/labs/knot/merge_requests/574