the heap-element-replace bug fix

See merge request !1452

David Vasek authored 2 years ago and Libor Peltan committed 2 years ago

This avoids the timeouts in master and as a result the "TCP, terminated inactive client"
messages in the master's log are eliminated. Slave seems to be busy for too long when signing
the zones under Valgrind.

David Vasek authored 2 years ago and Libor Peltan committed 2 years ago

In contrast with Knot coding style, most single line "if" constructions retained.

David Vasek authored 2 years ago and Libor Peltan committed 2 years ago

Possible as a result of modified heap_replace().

David Vasek authored 2 years ago and Libor Peltan committed 2 years ago

Current code as used by evsched_schedule() has led to a corrupted heap
(with its elements out of order), resulting in unpredictable event scheduling
behaviour, including events being processed out of order or already scheduled
events being postponed, sometimes for several days, weeks, or maybe longer.

Solving it by modifying the heap.c library a little -- the new code properly
handles a situation when the original element and the element it's being replaced by
are identical (that is, the same memory object), but already containing a modified
value than what originally was in the heap. Instead of comparing the new element
with the one it replaces, we now start comparing it with its parent.

This commit fixes an old bug introduced in:
925ad42d

It's said timercmp() == is broken in the same broken implementations too.
Furthemore, this expression is simpler and faster.
While there, fix some coding style.

MSAN is unable to correctly evaluate explicit_bzero() for memory zeroing in
wire_ctx operations. Then OSS-Fuzz creates false-positive issues. Using bzero()
seems to be a reasonable workaround.

zonedb: replan events for new zone_t instance no sooner...

See merge request !1451

This helps the server to process pending operations, which were triggered
by a signal before the poll execution in knot_ctl_accept().

Libor Peltan authored 2 years ago and Daniel Salzman committed 2 years ago

...as it might be planned by incomming NOTIFY during zonedb-reload
and in this case its not in timers

Libor Peltan authored 2 years ago and Daniel Salzman committed 2 years ago

...if e.g. SIGUSR1 signal has already arrived during
previous server/zonedb reload, dont proceed to ctl
as that ctl poll wont be interrupted by the already
processed signal

Libor Peltan authored 2 years ago and Daniel Salzman committed 2 years ago

...than all workers (UDP, TCP...) guaranteed to work...
...with new zonedb and new zone_t instance.

Otherwise they may plan events to old zone_t instance
and it gets lost.

Usually reproduced with catalogs.

Automatic ACL

See merge request !1450

tests-extra: remove security/protos as the binaries no longer work on Ubuntu 22.04 and are unavailable

Multi signer support

See merge request !1398

Libor Peltan authored 3 years ago and Daniel Salzman committed 2 years ago

...this can still be achieved by ACL/update-type

Add soft mode to semantic checks

See merge request !1446

This solves the situation when a CNAME is present at the zone apex and SOA query
is responded with the CNAME.

Preserve all zone flags (including zone XFR freeze) during reload

See merge request !1448