GitLab

JP Mens authored May 17, 2022 and Daniel Salzman committed May 17, 2022

closes #798

If a packet was successfully alloced by knot_xdp_send_alloc(),
there must be a room in the TX ring for it.

events: improve mutexing

See merge request !1454

Libor Peltan authored May 12, 2022 and Daniel Salzman committed May 13, 2022

This fixes a bug when zone_reload_modules only waits for
an event to be finished, but following reschedule is not
synchronized and might access memory freed by zone_free.

tests-extra XFR refactoring

See merge request !1453

This is a slight simplification of the test.

This is needed even without Valgrind when running massively in parallel

On slaves one common ACL for all actions has been replaced with a sequence
of ACLs for notify, one rule for one master.

the heap-element-replace bug fix

See merge request !1452

David Vasek authored Apr 29, 2022 and Libor Peltan committed May 02, 2022

This avoids the timeouts in master and as a result the "TCP, terminated inactive client"
messages in the master's log are eliminated. Slave seems to be busy for too long when signing
the zones under Valgrind.

David Vasek authored Apr 27, 2022 and Libor Peltan committed May 02, 2022

In contrast with Knot coding style, most single line "if" constructions retained.

David Vasek authored Apr 28, 2022 and Libor Peltan committed May 02, 2022

Possible as a result of modified heap_replace().

David Vasek authored Apr 27, 2022 and Libor Peltan committed May 02, 2022

Current code as used by evsched_schedule() has led to a corrupted heap
(with its elements out of order), resulting in unpredictable event scheduling
behaviour, including events being processed out of order or already scheduled
events being postponed, sometimes for several days, weeks, or maybe longer.

Solving it by modifying the heap.c library a little -- the new code properly
handles a situation when the original element and the element it's being replaced by
are identical (that is, the same memory object), but already containing a modified
value than what originally was in the heap. Instead of comparing the new element
with the one it replaces, we now start comparing it with its parent.

This commit fixes an old bug introduced in:
925ad42d

It's said timercmp() == is broken in the same broken implementations too.
Furthemore, this expression is simpler and faster.
While there, fix some coding style.

MSAN is unable to correctly evaluate explicit_bzero() for memory zeroing in
wire_ctx operations. Then OSS-Fuzz creates false-positive issues. Using bzero()
seems to be a reasonable workaround.

zonedb: replan events for new zone_t instance no sooner...

See merge request !1451

This helps the server to process pending operations, which were triggered
by a signal before the poll execution in knot_ctl_accept().

Libor Peltan authored Apr 27, 2022 and Daniel Salzman committed Apr 28, 2022

...as it might be planned by incomming NOTIFY during zonedb-reload
and in this case its not in timers

Libor Peltan authored Apr 26, 2022 and Daniel Salzman committed Apr 28, 2022

...if e.g. SIGUSR1 signal has already arrived during
previous server/zonedb reload, dont proceed to ctl
as that ctl poll wont be interrupted by the already
processed signal

Libor Peltan authored Apr 25, 2022 and Daniel Salzman committed Apr 28, 2022

...than all workers (UDP, TCP...) guaranteed to work...
...with new zonedb and new zone_t instance.

Otherwise they may plan events to old zone_t instance
and it gets lost.

Usually reproduced with catalogs.