Robert Edmonds authored Sep 30, 2022 and Daniel Salzman committed Oct 04, 2022

Some DNS queries are malformed and generate a FORMERR response from
knot, but when those broken queries are encapsulated with a PROXY v2
header they are simply dropped with no response. This doesn't seem
correct; knot shouldn't be changing its behavior (response vs. no
response) when a PROXY v2 header is added to the query.

Previously, proxyv2_header_strip() was throwing away the knot_pkt_t
result of calling knot_pkt_parse() on the inner, decapsulated query
packet. It looks like this was what was causing the non-response issue,
because the caller couldn't distinguish between the failure of the
proxyv2_header_strip() function (e.g., PROXY v2 signature was wrong) vs.
the knot_pkt_parse() on the inner packet failing.

This commit instead makes sure that the knot_pkt_t result of
knot_pkt_parse() is returned to the caller regardless of the return code
from that function. This causes knot to respond to some kinds of broken
queries that are encapsulated with PROXY v2 in the same way when the
same query is sent as an unencapsulated, bare DNS query packet.

fixes #817

Robert Edmonds authored Sep 30, 2022 and Daniel Salzman committed Oct 04, 2022

Previously, sizeof() was being called with a pointer-to-struct type
parameter when checking if the packet was large enough to contain the
PROXY v2 address block structs. This is not correct, since the correct
operand to use in these checks is the size of the structure itself.

fixes #816

kdig: JSON output format (RFC 8427)

See merge request !902

dthreads: patch early join of destructable threads

See merge request !1491

Jan Hák authored Sep 05, 2022 and Libor Peltan committed Sep 21, 2022

There is a flaw in the original implementation that causes `dt_join` to exit before the destructor runs. This patch does not fix this flaw, but covers it.

Jakub Ružička authored Sep 16, 2022 and Daniel Salzman committed Sep 16, 2022

Also remove bundled(jquery) version.

fixes #806

David Vasek authored Sep 06, 2022 and Daniel Salzman committed Sep 08, 2022

Newer dnspython needed as a result of commit 46d2fb8c.

doc: better specification of propagation-delay meaning

See merge request !1490

this is an amend to commit 6f9b568a

Also allow possibly newer versions.