1. 07 Oct, 2022 4 commits
  2. 04 Oct, 2022 3 commits
    • Daniel Salzman's avatar
      proxyv2: slight code reorganization · 7253f8b3
      Daniel Salzman authored
      7253f8b3
    • Robert Edmonds's avatar
      proxyv2_header_strip(): Operate correctly on malformed query packets · 869c025e
      Robert Edmonds authored and Daniel Salzman's avatar Daniel Salzman committed
      Some DNS queries are malformed and generate a FORMERR response from
      knot, but when those broken queries are encapsulated with a PROXY v2
      header they are simply dropped with no response. This doesn't seem
      correct; knot shouldn't be changing its behavior (response vs. no
      response) when a PROXY v2 header is added to the query.
      
      Previously, proxyv2_header_strip() was throwing away the knot_pkt_t
      result of calling knot_pkt_parse() on the inner, decapsulated query
      packet. It looks like this was what was causing the non-response issue,
      because the caller couldn't distinguish between the failure of the
      proxyv2_header_strip() function (e.g., PROXY v2 signature was wrong) vs.
      the knot_pkt_parse() on the inner packet failing.
      
      This commit instead makes sure that the knot_pkt_t result of
      knot_pkt_parse() is returned to the caller regardless of the return code
      from that function. This causes knot to respond to some kinds of broken
      queries that are encapsulated with PROXY v2 in the same way when the
      same query is sent as an unencapsulated, bare DNS query packet.
      
      fixes #817
      869c025e
    • Robert Edmonds's avatar
      proxyv2_addr_store(): Calculate packet bounds correctly · 71e6c27b
      Robert Edmonds authored and Daniel Salzman's avatar Daniel Salzman committed
      Previously, sizeof() was being called with a pointer-to-struct type
      parameter when checking if the packet was large enough to contain the
      PROXY v2 address block structs. This is not correct, since the correct
      operand to use in these checks is the size of the structure itself.
      
      fixes #816
      71e6c27b
  3. 02 Oct, 2022 1 commit
  4. 23 Sep, 2022 1 commit
  5. 22 Sep, 2022 4 commits
  6. 21 Sep, 2022 3 commits
  7. 18 Sep, 2022 3 commits
  8. 16 Sep, 2022 2 commits
  9. 15 Sep, 2022 1 commit
  10. 14 Sep, 2022 1 commit
  11. 13 Sep, 2022 1 commit
  12. 10 Sep, 2022 1 commit
  13. 08 Sep, 2022 3 commits
  14. 07 Sep, 2022 2 commits
  15. 06 Sep, 2022 3 commits
  16. 05 Sep, 2022 4 commits
  17. 04 Sep, 2022 3 commits