Skip to content

keymgr, missing check for parameter count when parsing argument

% keymgr zone key generate foo size    
ASAN:SIGSEGV
=================================================================
==2360==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x7fbbd7e60fb4 bp 0x000000000000 sp 0x7ffec6004300 T0)
    #0 0x7fbbd7e60fb3 in __GI_____strtoull_l_internal (/lib64/libc.so.6+0x3afb3)
    #1 0x4dcc26 in value_key_size /home/fcelda/devel/knot/src/dnssec/utils/cmdparse/value.c:218:24
    #2 0x4d7b22 in parse_parameters /home/fcelda/devel/knot/src/dnssec/utils/cmdparse/parameter.c:74:15
    #3 0x4ceb6f in cmd_zone_key_generate /home/fcelda/devel/knot/src/dnssec/utils/keymgr.c:565:6
    #4 0x4d6770 in subcommand /home/fcelda/devel/knot/src/dnssec/utils/cmdparse/command.c:92:9
    #5 0x4ca68f in cmd_zone_key /home/fcelda/devel/knot/src/dnssec/utils/keymgr.c:799:9
    #6 0x4d6770 in subcommand /home/fcelda/devel/knot/src/dnssec/utils/cmdparse/command.c:92:9
    #7 0x4bdc3f in cmd_zone /home/fcelda/devel/knot/src/dnssec/utils/keymgr.c:859:9
    #8 0x4d6770 in subcommand /home/fcelda/devel/knot/src/dnssec/utils/cmdparse/command.c:92:9
    #9 0x4bcbd9 in main /home/fcelda/devel/knot/src/dnssec/utils/keymgr.c:1223:14
    #10 0x7fbbd7e466ff in __libc_start_main (/lib64/libc.so.6+0x206ff)
    #11 0x4bc318 in _start (/home/fcelda/devel/knot/src/dnssec/utils/keymgr+0x4bc318)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV ??:0 __GI_____strtoull_l_internal
==2360==ABORTING