Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
Knot DNS
Knot DNS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 22
    • Issues 22
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 17
    • Merge Requests 17
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Knot projects
  • Knot DNSKnot DNS
  • Issues
  • #578

Closed
Open
Opened Mar 27, 2018 by Maxime Buquet@pep

Do not error when include clause doesn't match any file

Steps to reproduce

  • mkdir /etc/knot/conf.d for future configuration files.
  • include: "/etc/knot/conf.d/*.conf" in knot.conf.
  • Start knot.

Expected behaviour

Knot starts.

What happens

knotd[14385]: 2018-03-26T21:47:17 error: config, file '/etc/knot/knot.conf', line 12, item 'include', value '/etc/knot/conf.d/*.conf' (file error)
knotd[14385]: critical: failed to load configuration file '/etc/knot/knot.conf' (file error)
knotd[14385]: 2018-03-26T21:47:17 critical: failed to load configuration file '/etc/knot/knot.conf

I regularly use nginx and I know it handles this. Apache apparently has an IncludeOptional clause for this. I have a patch to always make it optional. I can have a look to add another clause if necessary.

(Also I can't create forks on this instance atm?)

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: knot/knot-dns#578