Skip to content

GitLab

Knot DNS
Knot DNS
Closed
Opened by Maxime Buquet@pep

Do not error when include clause doesn't match any file

Steps to reproduce

  • mkdir /etc/knot/conf.d for future configuration files.
  • include: "/etc/knot/conf.d/*.conf" in knot.conf.
  • Start knot.

Expected behaviour

Knot starts.

What happens

knotd[14385]: 2018-03-26T21:47:17 error: config, file '/etc/knot/knot.conf', line 12, item 'include', value '/etc/knot/conf.d/*.conf' (file error)
knotd[14385]: critical: failed to load configuration file '/etc/knot/knot.conf' (file error)
knotd[14385]: 2018-03-26T21:47:17 critical: failed to load configuration file '/etc/knot/knot.conf

I regularly use nginx and I know it handles this. Apache apparently has an IncludeOptional clause for this. I have a patch to always make it optional. I can have a look to add another clause if necessary.

(Also I can't create forks on this instance atm?)