Skip to content
Snippets Groups Projects

Per-zone storage and dnssec-keydir settings

Merged Per-zone storage and dnssec-keydir settings
per-zone-storage-and-keydir into master
Merged Jan Včelák requested to merge per-zone-storage-and-keydir into master

Features requested by Kamil Sopko @sopak

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ghost User
  • Ghost User
  • Ghost User
  • Ghost User
  • Ghost User
    Ghost User @ghost started a thread on the diff
    • src/knot/conf/conf.c
    173 *
    174 * \param path Path to be checked.
    175 *
    176 * \return Given path is a directory.
    177 */
    178 static bool is_existing_dir(const char *path)
    179 {
    180 assert(path);
    181
    182 struct stat st;
    183
    184 if (stat(path, &st) == -1) {
    185 return false;
    186 }
    187
    188 return S_ISDIR(st.st_mode);
  • Ghost User
    Ghost User @ghost ·
    Contributor

    process.c:182 checks for storage writeability after dropping privileges, I think now it should be checked for all zones to be sure.

  • Ghost User
    Ghost User @ghost ·
    Contributor

    otherwise lgtm

  • Jan Včelák
    Jan Včelák @jvcelak ·
    Author Contributor

    Documentation is fixed, writeability of each zone file is tested.

    • Please register or sign in to reply