Skip to content
Snippets Groups Projects

PID changes, knotc start removed, AF_UNIX socket support, doc

Merged Ghost User requested to merge pid_changes into master

Merge request reports

Approval is optional

Merged by avatar (Apr 18, 2025 4:57am UTC)

Merge details

  • Changes merged into master with 6fa4d947.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • You changed the default control port from 5553 to 5533, but knot.full.conf and documentation (texi) still refers to old port number.

  • I really like the simplification of PID file handling and communication of knotc with knotd.

  • What about removing port number from following message when AF_UNIX sockets are used for control:

    Binding remote control interface to /var/run/knot/knot.sock@0.

  • Binding to AF_UNIX socket does not work on my Linux machine - Cannot bind to socket (errno 22). EINVAL?

    :crying_cat_face:

  • Author Contributor
    • Updated control port references in knot.full.conf and manpage, didn't find it in texi files though
    • Port isn't printed for AF_UNIX sockets, reused a buffer for commands for formatting
    • Not working AF_UNIX now fixed. I must have been very tired, although it is odd that FreeBSD didn't mind...
    # These lines should be obviously switched
    uaddr.sun_family = AF_UNIX;
    memset(&uaddr, 0, sizeof(struct sockaddr_un));
  • Author Contributor

    Could you recheck please? :goberserk:

  • Looks fine now!

Please register or sign in to reply
Loading