Skip to content
Snippets Groups Projects

Get rid of node->wildcard_child pointer

Merged Get rid of node->wildcard_child pointer
wildcard_child2 into master
Merged Ghost User requested to merge wildcard_child2 into master

Some info is in issue #216 (closed). It should be quite straightforward.

The change also uncovered one other problem in the code: node's 'removed NSEC' flag could remain in the node after applying and signing an UPDATE. I forced clearing of this flag in the adjusting function. This probably renders the clearing in zone signing (zone-sign.c:569) redundant, but I'm not 100% sure about that. But feel free to remove it from zone signing if it seems alright and tests pass.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ghost User
    Ghost User @ghost ·
    Author Contributor

    Sorry about the last commit, I pushed that by accident. That should be no problem though, it's the same as in master.

  • Jan Včelák
    Jan Včelák @jvcelak ·
    Contributor

    @jkadlec I made some cleanups and fixed a possible buffer overflow in knot_zone_contents_find_wildcard_child updated by you.

    Please, can you review my changes and merge?

  • Ghost User Status changed to closed

    Status changed to closed

  • Ghost User Status changed to reopened

    Status changed to reopened

    • Please register or sign in to reply