Skip to content
Snippets Groups Projects

Node Cleanup

Merged Node Cleanup
cleanup_node into master
Merged Ghost User requested to merge cleanup_node into master

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ghost User
    Ghost User @ghost ·
    Author Contributor

    Looks good, some further notes:

    • NEEDS rebase to master :octocat: done
    • you could port it to mm_ctx_t as well :octocat: I'd need to port zone to it as well for it to make any sense now. Zone will be purged anyway, so no need to do it now.
    • node_shallow_copy could return a pointer to copy, knot_dname_copy style :octocat: done
    • node_remove_rrs -> node_remove_rdataset :octocat: done
    • still the _AUTH _NONAUTH logic

    Feel free to ignore if you feel this wasn't the goal of "cleaning up the node" :v:

  • Ghost User
    Ghost User @ghost ·
    Author Contributor

    Some issues resolved, I'll do a test run and let you know.

  • Ghost User
    Ghost User @ghost ·
    Author Contributor

    Tests look good. Good to merge IMO.

  • Ghost User
    Ghost User @ghost ·
    Author Contributor

    OK, last two patches look good. :white_check_mark:

Please register or sign in to reply