Add check for signature expiration in semantic checks (!32) · Merge requests · Knot projects / Knot DNS · GitLab

Snippets Groups Projects

Self sign-up has been disabled due to increased spam activity. If you want to get access, please send an email to a project owner (preferred) or at gitlab(at)nic(dot)cz. We apologize for the inconvenience.

Merged Daniel Salzman requested to merge rrsig_expiration_check into master 11 years ago

Activity

Ghost User @ghost started a thread on the diff 11 years ago

src/knot/zone/semantic-check.c

		Unable to load the diff
Ghost User @ghost · 11 years ago Contributor You should prepare a string containing some information about the type this RRSIG covers and pass it to the error handling function instead of NULL. Normally, only owner of the node is logged. See check_rrsig_data().

Ghost User @ghost started a thread on the diff 11 years ago

src/knot/zone/semantic-check.c

460	468	info_str);
461	469	}
462	470
463		if (knot_rrset_ttl(rrset) != knot_rrset_ttl(rrset)) {
	471	if (knot_rrset_ttl(rrset) != knot_rrset_ttl(rrsigs)) {
Ghost User @ghost · 11 years ago Contributor

Ghost User @ghost · 11 years ago

Contributor

Just one detail concerning more info about signature expiration error. Looks good otherwise.

Daniel Salzman @dsalzman · 11 years ago

Author Owner

The additional information string was added to log messages. It was missing at more places.

Please register or sign in to reply