Skip to content
Snippets Groups Projects

Separate yparser

Closed Ondřej Surý requested to merge separate-yparser into autotools-fixes

This is one of the approaches we can take to fix the symbols loop between libknot and libknot-int.

This will work only in case that neither libknot nor libknot-int will use symbols from libknot-yparser.

Other options include depending on intended usage of yparser:

  1. move yparser to libknot
  2. merge libknot and libknot-int (but only expose libknot in default headers, e.g. #include <libknot.h> vs #include <libknot-int.h>). This will also need strict GCC Visibility definitions for symbols in libknot-int, so we don't have to bump SOVERSION often
  3. move knot_dname as dname_* to libknot-int, but export them as knot_dname_* from libknot + use dname_* in yparser

O.

Merge request reports

Approval is optional

Closed by avatar (Apr 18, 2025 8:50am UTC)

Merge details

  • The changes were not merged into autotools-fixes.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ondřej Surý Added 1 new commit:

    Added 1 new commit:

    • 31aa9abd - Add pkg-config for libknot-yparser library
  • Ondřej Surý Added 4 new commits:

    Added 4 new commits:

    • a1ca3332 - Add src/libknot-yparser.pc to gitignore
    • 7ebd6089 - Add missing {CPP,LD}FLAGS for libknot-yparser.la
    • cb7e0229 - Link tests with libknot-yparser.la
    • e15a4cd1 - Set correct visibility on yp_* symbols from libknot-yparser.la library
  • Daniel Salzman Added 1 new commit:

    Added 1 new commit:

    • a7399911 - Set correct visibility on yp_* symbols from libknot-yparser.la library
  • Ondřej Surý Added 5 new commits:

    Added 5 new commits:

    • b9c98746 - Move knot_map_errno_internal to libknot-int
    • 0024dc87 - Move yparser from libknot/internal/ to libknot/
    • 1cb24811 - Cleanup libknot/errcode.h vs libknot/internal/errcode.h usage in the rest of the code
    • d2b5d25a - Finish unlooping of libknot-int
    • 60379186 - Don't overwrite --{enable,disable}-fastparser values given by user
  • Ondřej Surý Status changed to closed

    Status changed to closed

Please register or sign in to reply
Loading