Skip to content
Snippets Groups Projects

Zonefile formatters

Merged Daniel Salzman requested to merge zonefile_formatters into master

Merge request reports

Checking approval status

Merged by (Jan 10, 2025 10:01am UTC)

Merge details

  • Changes merged into with 53a1d92c.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Unit tests fail with address sanitizer.

    ==13297==ERROR: LeakSanitizer: detected memory leaks
    
    Direct leak of 12 byte(s) in 1 object(s) allocated from:
        #0 0x495c86 in strdup (/home/fcelda/devel/knot/tests/conf+0x495c86)
        #1 0x4d88b1 in get_filename /home/fcelda/devel/knot/tests/../src/knot/conf/conf.c:874:10
        #2 0x4deb90 in check_name /home/fcelda/devel/knot/tests/conf.c:31:15
        #3 0x4dd10a in test_get_filename /home/fcelda/devel/knot/tests/conf.c:86:2
        #4 0x4dc91b in main /home/fcelda/devel/knot/tests/conf.c:173:2
        #5 0x7fab6cb476ff in __libc_start_main (/lib64/libc.so.6+0x206ff)
    
    ...
    
    SUMMARY: AddressSanitizer: 69 byte(s) leaked in 17 allocation(s)
  • Journal files are being created in the storage directory. I'm not sure if this is desired. Maybe the patterns should be reflected in the journal zone file name as well.

  • The patterns support just one byte indexes. I think that sooner or later, somebody will try something like this: %c[0-1]/%c[2-255].zone

  • LeakSanitizer :white_check_mark:, journal :white_check_mark:

  • Daniel Salzman Added 4 commits:

    Added 4 commits:

    • 054694c0 - conf: add %c and %l zonefile formatters
    • 499646c6 - zonefile: add explicit zonefile path creation + refactoring
    • 76e634b4 - zonefile: code cleanup
    • 53a1d92c - conf: zonefile formatters review fixes
    Toggle commit list
  • All comments were resolved except the one digit index restriction. This can be extended in the future.

  • Jan Včelák Status changed to merged

    Status changed to merged

Please register or sign in to reply