Skip to content
Snippets Groups Projects

Semantic checks

Merged Vitezslav Kriz requested to merge semcheck_refactor into master
  • code refactor for semantic checks
  • stand-alone tool for semantic check (kzonecheck)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Vitezslav Kriz Added 1 commit:

    Added 1 commit:

    • a84bad43 - semcheck: doc
  • Vitezslav Kriz Added 3 commits:

    Added 3 commits:

    • efe90556 - semcheck: clean code and tests
    • 583465db - semcheck: refactor zone_contents_adjust
    • 19f46334 - semcheck: added comments
  • Vitezslav Kriz Unmarked this merge request as a Work In Progress

    Unmarked this merge request as a Work In Progress

  • Reassigned to @jvcelak

  • Vitezslav Kriz Added 3 commits:

    Added 3 commits:

    • f001bd96 - semcheck: fix memory leak
    • 0c2b32e0 - testcase for DNAME semantic check after zone transfer
    • 05ed0abb - mandatory semantic checks for axfr and ixfr transfer
  • Vitezslav Kriz Added 1 commit:

    Added 1 commit:

    • c5515984 - move TTL from semantic check. fix memory leak.
  • @vkriz Please, can you rebase the changes so I can start reviewing?

  • Vitezslav Kriz Added 94 commits:

    Added 94 commits:

    • c5515984...f9ba301d - 71 commits from branch master
    • e7bb67a0 - semchecks: refactoring
    • bce09f66 - semcheck: rebase: working unittests
    • 7a738d9d - semchecks: only mandatory
    • 59e6e663 - smecheck: tests
    • 62619564 - semcheck: nsec3
    • 6b53533c - smecheck: enum of check level
    • bf312026 - semcheck: unittests
    • eadd6638 - kzonecheck: standalone tool for semantic checks
    • 338a5235 - semcheck: nsec_chain fix false positive
    • 9157e97e - semcheck: check missing rrsig for NSEC under delegation node
    • 024ec30f - kzonecheck: split into two files
    • 1e466a27 - kzonecheck: missing header
    • f7dad0e0 - semchecks: long-term signed zones for tests
    • f4af95b3 - semcheck: tests fix for BSD
    • d133ffe5 - semcheck: correct zone tests
    • 72ee359f - semcheck: doc
    • 3baf15e5 - semcheck: clean code and tests
    • 7a612ef3 - semcheck: refactor zone_contents_adjust
    • 3c8067e9 - semcheck: added comments
    • 5a48b333 - semcheck: fix memory leak
    • add3470b - mandatory semantic checks for axfr and ixfr transfer
    • 7070ea2d - move TTL from semantic check. fix memory leak.
    • fb74493f - doc gitignore
  • Jan Včelák Added 65 commits:

    Added 65 commits:

    • fb74493f...c463afff - 42 commits from branch master
    • 60adbbae - semchecks: refactoring
    • 38ba857a - semcheck: rebase: working unittests
    • 57be33ef - semchecks: only mandatory
    • 2224b6bc - smecheck: tests
    • fbee8ff9 - semcheck: nsec3
    • 01f9d665 - smecheck: enum of check level
    • fd2bad81 - semcheck: unittests
    • bdb63f9b - kzonecheck: standalone tool for semantic checks
    • 525f64fc - semcheck: nsec_chain fix false positive
    • f73fb945 - semcheck: check missing rrsig for NSEC under delegation node
    • 5e106d22 - kzonecheck: split into two files
    • 62b50141 - kzonecheck: missing header
    • 37da1dc8 - semchecks: long-term signed zones for tests
    • 8e30b631 - semcheck: tests fix for BSD
    • 215a2c76 - semcheck: correct zone tests
    • aa6eb5db - semcheck: doc
    • c242a1ca - semcheck: clean code and tests
    • 9d2939ca - semcheck: refactor zone_contents_adjust
    • 0f35a8c0 - semcheck: added comments
    • b227b50e - semcheck: fix memory leak
    • 9e58d371 - mandatory semantic checks for axfr and ixfr transfer
    • 02a00a78 - move TTL from semantic check. fix memory leak.
    • 9480f922 - doc gitignore
  • Jan Včelák Added 1 commit:

    Added 1 commit:

    • 59363f0e - doc: fix language in kzonecheck manual page
723 723 Mandatory checks:
  • 480 }
    481
    482 // check glue record for delegation
    483 for (int i = 0; i < ns_rrs->rr_count; ++i) {
    484 const knot_dname_t *ns_dname = knot_ns_name(ns_rrs, i);
    485 if (!knot_dname_is_sub(ns_dname, data->zone->apex->owner)) {
    486 continue;
    487 }
    488
    489 const zone_node_t *glue_node =
    490 zone_contents_find_node(data->zone, ns_dname);
    491
    492 if (glue_node == NULL) {
    493 /* Try wildcard ([1]* + suffix). */
    494 knot_dname_t wildcard[KNOT_DNAME_MAXLEN];
    495 memcpy(wildcard, "\x1""*", 2);
    • I'm not sure if wild card glue is possible. Anyway, this check won't match:

      child.example.  NS a.ns.child.example.
      *.ns.child.example AAAA ::1
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading