Skip to content
Snippets Groups Projects

Fix kdig canonization

Merged Fix kdig canonization
fix_kdig_canonization into master
Merged Daniel Salzman requested to merge fix_kdig_canonization into master

Merge request reports

Approval is optional

Merged by avatar (Apr 11, 2025 5:55am UTC)

Merge details

  • Changes merged into master with 66e31a79.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Daniel Salzman Added 2 commits:

    Added 2 commits:

    • 47350d31 - libknot: add no canonization flag to packet parsing
    • e60828c2 - kdig: fix reply rrsets canonization
  • Daniel Salzman Added 2 commits:

    Added 2 commits:

    • 3ad781e2 - libknot: add no canonization flag to packet parsing
    • 68ca66ba - kdig: fix reply rrsets canonization
  • Jan Včelák
    Jan Včelák @jvcelak ·
    Contributor

    Just a few notes:

    • Canonicalization and canonization is something quite different. Please fix the comments.
    • The new code is not covered by unit tests. Please add a simple test for the new flag (and possibly KNOT_PF_NOCANON).
    • API change doesn't matter that much as we use the function only internally. So this is good.
  • Daniel Salzman Added 2 commits:

    Added 2 commits:

    • 1916b875 - libknot: add no canonicalization flag to packet parsing
    • ffe85e53 - kdig: fix reply rrsets canonicalization
  • Daniel Salzman Added 2 commits:

    Added 2 commits:

    • f273382b - libknot: add no canonicalization flag to packet parsing
    • 7a793852 - kdig: fix reply rrsets canonicalization
  • Daniel Salzman Added 2 commits:

    Added 2 commits:

    • 0d1f54a7 - libknot: add no canonicalization flag to packet parsing
    • d479f992 - kdig: fix reply rrsets canonicalization
  • Daniel Salzman
    Daniel Salzman @dsalzman ·
    Author Owner

    Canonization was renamed and a unit test for knot_rrset_rr_from_wire was added. :recycle:

  • Jan Včelák mentioned in commit 66e31a79

    mentioned in commit 66e31a79

  • Jan Včelák Status changed to merged

    Status changed to merged

Please register or sign in to reply