Skip to content
Snippets Groups Projects

EDNS Client Subnet API

Merged Jan Včelák requested to merge edns-client-subnet-api into master
All threads resolved!

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jan Včelák Added 2 commits:

    Added 2 commits:

    • d5bcfc0a - wire: eliminate side effect of wire_ctx_can_write
    • 2cb28f98 - wire_ctx_copy: improve error code setting
  • Jan Včelák Resolved all discussions

    Resolved all discussions

  • Daniel Salzman
    Daniel Salzman @dsalzman started a thread on commit d5bcfc0a
  • 150 150 /*!
    151 151 * \brief Check the context if reading is possible.
    152 152 */
    153 static inline bool wire_ctx_can_read(wire_ctx_t *ctx, size_t size)
    153 static inline int wire_ctx_can_read(wire_ctx_t *ctx, size_t size)
    154 154 {
    155 155 assert(ctx);
    156 156
    157 return ctx->error == KNOT_EOK && wire_ctx_available(ctx) >= size;
    157 if (ctx->error) {
  • Daniel Salzman
    Daniel Salzman @dsalzman started a thread on commit 2cb28f98
  • 445 445 assert(dst);
    446 446 assert(src);
    447 447
    448 if (dst->error != KNOT_EOK || src->error != KNOT_EOK) {
    448 if (size == 0 || dst->error != KNOT_EOK) {
    449 449 return;
    450 450 }
    451 451
    452 if (size == 0) {
    452 if (wire_ctx_can_read(src, size) != KNOT_EOK) {
  • Jan Včelák Added 1 commit:

    Added 1 commit:

    • 06afa093 - review: error checking consistency
  • Jan Včelák Added 3 commits:

    Added 3 commits:

    • 4ff58893 - review: remove extra const
    • 9a5f3192 - review: invalid order of calloc arguments
    • ef3e9d1f - review: use str_to_u8 instead of strtoul
  • Jan Včelák Resolved all discussions

    Resolved all discussions

  • Jan Včelák Added 1 commit:

    Added 1 commit:

    • b06ebaa5 - review: consistent ecs_write_address error handling
  • Daniel Salzman Status changed to merged

    Status changed to merged

  • Daniel Salzman mentioned in commit a976c3af

    mentioned in commit a976c3af

  • Daniel Salzman Mentioned in commit a976c3af

    Mentioned in commit a976c3af

  • Please register or sign in to reply
    Loading