Improve keymgr

closes issue #480 (closed)

Added 1 commit:

• 2dde7b79 - keymgr: update doc

As a first thing - could you please split the key removal into a separate request?

Resolved all discussions

Added 1 commit:

• cc5a18ff - keymgr: add more filters to zone key list and ds - see Issue #480 (closed), also move key…

Compare with previous version

Added 1 commit:

• d62ce965 - keymgr: add more filters to zone key list and ds - see Issue #480 (closed), also move key…

Compare with previous version

Changed title: WIP: Remove old dnssec keys and improve keymgr → WIP: Improve keymgr

Added 1 commit:

• 48aaee09 - keymgr: add more filters to zone key list and ds - see Issue #480 (closed)

Compare with previous version

Unmarked this merge request as a Work In Progress

Added 1 commit:

• 0b389458 - keymgr: allow combinations and add + to all filters

Compare with previous version

Marked this merge request as a Work In Progress

Added 1 commit:

• debdd24b - keymgr: update doc

Compare with previous version

Unmarked this merge request as a Work In Progress

'make check' does not work. Suggested:

diff --git a/src/dnssec/tests/event_keystate.c b/src/dnssec/tests/event_keystate.c
index da0efb9..6ae4721 100644
--- a/src/dnssec/tests/event_keystate.c
+++ b/src/dnssec/tests/event_keystate.c
@@ -17,7 +17,7 @@
 #include <tap/basic.h>
 #include <string.h>
 
-#include "event/keystate.h"
+#include "dnssec/keystate.h"
 
 #define PAST   1426852710
 #define NOW    1426852711

It is also required to update Knot.files

By the way, it is generally recommended to rebase your changes on the top of current master branch.

What is not nice:

• having keystate.c and keystate.h in different directories
• parameter-based asserts in library-public function get_key_state()
• there appear constants in the code which should be macroed or something. Hint: 257 -> DNSKEY_FLAGS_KSK (src/dnssec/lib/key/internal.h)
• doc: the formulation "also these filters require + prefix" is too unclear
• keymgr zone key list zone. +anything_stupid returns all keys like there was no parameter (hint: DNSSEC_KEY_STATE_INVALID).
• similar inconsistency in zone key ds (+stupid versus +removed). Suggestion: anything starting with + should be treated as (possibly invalid) filter? Is there a conflict with proper key tags/ids starting with + ?
• keymgr zone key ds example.com. +published returns no output, even no "nothing found" message.

Please don't take my notes too rigorously, it's just what came to my mind ;)

added 1 commit

• ece018d2 - fix include, refactor + add checks for invalid filters (TODO: only one valid filter)

Compare with previous version

Just marginal coding style:

if (condition) !no newline here but space required! { (lines 29, 938, 1082)

inconsistent empty lines in str_to_keystate()

some lines are too long (~120 chars limit)

...else it is nice !

added 1 commit

• a9304793 - rework zone key filters

Compare with previous version

added 177 commits

• a9304793...1c7c652d - 172 commits from branch master
• 419ffaf3 - keymgr: add more filters to zone key list and ds - see Issue #480 (closed)
• 68cdf5aa - keymgr: allow combinations and add + to all filters
• 051ad98b - keymgr: update doc
• 528b9c81 - fix include, refactor + add checks for invalid filters (TODO: only one valid filter)
• ab081abc - rework zone key filters

Compare with previous version

added 1 commit

• 8e98cca2 - Keymgr: simplified code

Compare with previous version

mentioned in commit d9114821

merged